Merge remote-tracking branch 'origin/master' into suraj/debug-active-rule-files

Author: szgupta

.agents/skills/dedupe-issue-local/SKILL.md

@@ -1,10 +1,10 @@
 ---
 name: dedupe-issue-local
 specializes: dedupe-issue
-description: Repo-specific dedupe guidance for warp-external. Only the categories declared overridable by the core dedupe-issue skill may be specialized here.
+description: Repo-specific dedupe guidance for warp. Only the categories declared overridable by the core dedupe-issue skill may be specialized here.
 ---
 
-# Repo-specific dedupe guidance for `warp-external`
+# Repo-specific dedupe guidance for `warp`
 
 This file is a companion to the core `dedupe-issue` skill. It does not
 redefine the duplicate-detection algorithm, the similarity thresholds,

.agents/skills/review-pr-local/SKILL.md

@@ -22,6 +22,15 @@ skill marks as overridable.
 - In WarpUI code, flag inline `MouseStateHandle::default()` usage during render or event handling. Mouse state handles should be created during construction and then cloned/referenced where needed.
 - For user-facing UI changes, mention missing validation only when it is tied to a concrete risk or when the PR changes behavior that should be verified visually.
 
+## UI-impacting changes require visual evidence
+
+- If the PR changes anything user-visible (UI components, layout, styling, copy in surfaces users see, terminal/Warp app visuals, or other behavior a user can perceive), analyze both `pr_description.txt` and any PR comments available in the workflow context for attached screenshots, GIFs, or videos demonstrating the change end to end.
+  - Treat markdown image/video embeds (`![...](...)`, `<img ...>`, `<video ...>`), GitHub user-attachment links (e.g. `https://github.com/user-attachments/...`, `https://user-images.githubusercontent.com/...`), Loom links, and similar hosted media as valid evidence.
+  - The `Screenshots / Videos` section from `.github/pull_request_template.md` being present but empty does not count as evidence.
+- If the change is UI-impacting and no screenshots or videos are attached in the description or comments, add an inline or summary-level comment requesting them. Use wording such as: "For faster review, please upload screenshots or a video of the feature working end to end."
+- When required visual evidence is missing for a UI-impacting change, set the final recommendation in `summary` to `Request changes`, even if no other blocking issues were found. Call this out explicitly in the `## Verdict` section.
+- If the PR is clearly not user-visible (pure refactor, internal tooling, build scripts, server-only logic with no UI surface, tests, docs-only), do not request screenshots or videos.
+
 ## User-facing strings
 
 - Flag interpolated text that would read unnaturally at runtime or combine sentence fragments with the wrong casing.

.agents/skills/triage-issue-local/SKILL.md

@@ -1,10 +1,10 @@
 ---
 name: triage-issue-local
 specializes: triage-issue
-description: Repo-specific triage guidance for warp-external. Only the categories declared overridable by the core triage-issue skill may be specialized here.
+description: Repo-specific triage guidance for warp. Only the categories declared overridable by the core triage-issue skill may be specialized here.
 ---
 
-# Repo-specific triage guidance for `warp-external`
+# Repo-specific triage guidance for `warp`
 
 This file is a companion to the core `triage-issue` skill. It does not
 redefine the triage output schema, safety rules, or follow-up-question
@@ -13,7 +13,7 @@ marks as overridable.
 
 ## Heuristics
 
-- `warp-external` is the public-facing Warp desktop client repository. Treat public issue reports as potentially incomplete and avoid asking for secrets, tokens, private workspace names, private repository names, or account identifiers in the public issue thread.
+- `warp` is the public-facing Warp desktop client repository. Treat public issue reports as potentially incomplete and avoid asking for secrets, tokens, private workspace names, private repository names, or account identifiers in the public issue thread.
 - Distinguish the user's observed Warp behavior from their guesses about Rust modules, UI components, server behavior, feature flags, or product intent.
 - For issue reports that mention another terminal, editor, shell, or CLI tool, identify whether the problem is Warp-specific or generally reproducible outside Warp before assigning Warp ownership.
 - When the issue includes screenshots, videos, logs, stack traces, or command output, use them as primary evidence and ask follow-up questions only for missing details that cannot be inferred from that evidence.
@@ -28,6 +28,8 @@ Ask **at most 2 follow-up questions** per triage response. Each question must be
 
 The label taxonomy for this repository is managed in `.github/issue-triage/config.json`. Prefer labels from that configuration, especially the `area:*`, `os:*`, `repro:*`, `accessibility`, `needs-info`, `duplicate`, and primary issue-type labels. Do not invent new labels unless the prompt explicitly allows it.
 
+Evaluate `ready-to-implement` during triage instead of relying on issue-template defaults. For bug reports, apply `ready-to-implement` only when the issue is reproducible from the provided evidence or straightforward local verification and the likely fix appears narrow enough to implement without a product spec, design mocks, or substantial investigation. If the bug is not reproducible, lacks a clear fix path, requires product/design decisions, or needs deeper technical discovery, omit `ready-to-implement` and prefer `needs-info`, `ready-to-spec`, `needs-mocks`, or the appropriate `repro:*` label.
+
 Use area labels based on the user's reported surface:
 
 - `area:shell-terminal` for terminal output, block rendering, shell integration, prompt rendering, command execution display, and terminal-emulation behavior.

.github/ISSUE_TEMPLATE/01_bug_report.yml

@@ -1,6 +1,6 @@
 name: Bug Report
 description: "Found a bug? Please search through our open issues and docs, to make sure it isn't already submitted. If you have an SSH related issue, please use the SSH Template below"
-labels: ["bug", "ready-to-implement"]
+labels: ["bug"]
 body:
   - type: checkboxes
     attributes:
@@ -134,4 +134,3 @@ body:
         - Ignore
     validations:
       required: false
-

.github/STAKEHOLDERS

@@ -54,7 +54,6 @@
 /app/src/search/command_palette/ @acarl005
 
 # @ context, slash commands, and global search / file tree
-/app/src/context_chips/ @moirahuang
 /app/src/search/ai_context_menu/ @moirahuang
 /app/src/search/files/ @moirahuang
 /app/src/search/search_results_menu/ @moirahuang

.github/actions/bundle_arch_package/action.yml

@@ -37,5 +37,6 @@ runs:
           -e GIT_RELEASE_TAG="$GIT_RELEASE_TAG" \
           -e GITHUB_ACTIONS="$GITHUB_ACTIONS" \
           -e GITHUB_OUTPUT="/dev/null" \
+          ${SETTINGS_SCHEMA_CACHE:+-e SETTINGS_SCHEMA_CACHE=/github/workspace/.settings_schema_cache.json} \
           arch-bundle-builder \
           ${{ inputs.channel }} ${{ inputs.release-tag }} ${{ inputs.arch }} ${{ inputs.artifact }}

.github/workflows/comment-on-unready-assigned-issue-local.yml

@@ -111,6 +111,9 @@ jobs:
         shell: bash
         env:
           CHANNEL: ${{ steps.get-config.outputs.channel }}
+          # See https://github.com/orgs/community/discussions/151442 for why we need to use
+          # a PAT here.
+          GITHUB_TOKEN: ${{ secrets.CREATE_RELEASE_TAG_PUSH_PAT }}
 
       - name: Create GitHub release
         if: ${{ steps.set_publish.outputs.should_publish == 'true' }}
@@ -519,6 +522,9 @@ jobs:
       # them with FUSE, which isn't available on GitHub runners (and this is
       # easier and less error-prone than trying to install it).
       APPIMAGE_EXTRACT_AND_RUN: "1"
+      # Cache the generated settings schema so prepare_bundled_resources only
+      # compiles and runs the generator once per job instead of per-package.
+      SETTINGS_SCHEMA_CACHE: ${{ github.workspace }}/.settings_schema_cache.json
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
 
@@ -669,6 +675,10 @@ jobs:
     needs: prepare_release
     if: ${{ inputs.build_linux != false }}
     timeout-minutes: 90
+    env:
+      # Cache the generated settings schema so prepare_bundled_resources only
+      # compiles and runs the generator once per job instead of per-package.
+      SETTINGS_SCHEMA_CACHE: ${{ github.workspace }}/.settings_schema_cache.json
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
 
@@ -845,6 +855,9 @@ jobs:
       # them with FUSE, which isn't available on GitHub runners (and this is
       # easier and less error-prone than trying to install it).
       APPIMAGE_EXTRACT_AND_RUN: "1"
+      # Cache the generated settings schema so prepare_bundled_resources only
+      # compiles and runs the generator once per job instead of per-package.
+      SETTINGS_SCHEMA_CACHE: ${{ github.workspace }}/.settings_schema_cache.json
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
 
@@ -1011,6 +1024,10 @@ jobs:
     needs: [ prepare_release, build_linux_arm_binaries, build_linux_cli_arm_binaries ]
     if: ${{ inputs.build_linux != false }}
     timeout-minutes: 60
+    env:
+      # Cache the generated settings schema so prepare_bundled_resources only
+      # compiles and runs the generator once per job instead of per-package.
+      SETTINGS_SCHEMA_CACHE: ${{ github.workspace }}/.settings_schema_cache.json
     steps:
       - name: Checkout sources
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/create_release.yml

@@ -92,7 +92,6 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           ref: ${{ inputs.branch }}
-          fetch-depth: 0
 
       - name: Rename branch to deleted/
         env:

.github/workflows/delete_release.yml

@@ -0,0 +1,66 @@
+# ======================================================================================
+# Workflow: Label External Contributors
+# ======================================================================================
+# Usage:
+#   - Runs whenever a pull request is opened.
+#   - Adds the `external-contributor` label to the PR if the PR head repository is
+#     a fork (i.e. it does not belong to the same repository as the base), and the
+#     PR is not authored by a bot.
+#
+# Notes:
+#   - The workflow triggers on `pull_request_target` rather than `pull_request` so
+#     that it has the `pull-requests: write` permission needed to apply labels even
+#     when the PR is opened from a fork. Because we never check out the PR's code
+#     and only read the event payload, this trigger is safe.
+# ======================================================================================
+
+name: Label External Contributors
+
+on:
+  pull_request_target:
+    types: [opened]
+
+# Default to a read-only token. The job below widens permissions explicitly.
+permissions:
+  contents: read
+
+jobs:
+  label-external-contributor:
+    name: Label external-contributor PRs
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Determine and apply external-contributor label
+        uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
+        with:
+          script: |
+            const pr = context.payload.pull_request;
+            const author = pr.user.login;
+
+            // Ignore PRs authored by bots.
+            if (pr.user.type === 'Bot' || author.endsWith('[bot]')) {
+              console.log(`Skipping bot user: ${author}`);
+              return;
+            }
+
+            // The PR comes from a fork if its head repo differs from its base repo.
+            const isFork =
+              !pr.head.repo ||
+              pr.head.repo.full_name !== pr.base.repo.full_name;
+
+            console.log(
+              `PR #${pr.number} by ${author}: isFork=${isFork}`,
+            );
+
+            if (!isFork) {
+              return;
+            }
+
+            await github.rest.issues.addLabels({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: pr.number,
+              labels: ['external-contributor'],
+            });
+            console.log(`Labeled PR #${pr.number} as external-contributor`);