Skip to content

Commit 7102088

Browse files
committed
WIP: linting
1 parent bce528c commit 7102088

3 files changed

Lines changed: 5 additions & 10 deletions

File tree

internal/plugin/components/plugin.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ func (noopPlugin) IsRegistered() bool { return false }
1919

2020
// ------------------------------------------------------------------------------
2121

22+
// NewPlugin returns a Plugin implementation whose underlying instance type is
23+
// Component.
2224
func NewPlugin[Component any]() *Plugin[Component] {
2325
p := &Plugin[Component]{}
2426
plugin = p

public/wasm/examples/flip/main.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,6 @@ func flip(s string) string {
4848
return result.String()
4949
}
5050

51-
func reverse(s string) string {
52-
r := []rune(s)
53-
for i, j := 0, len(r)-1; i < len(r)/2; i, j = i+1, j-1 {
54-
r[i], r[j] = r[j], r[i]
55-
}
56-
return string(r)
57-
}
58-
5951
func (p *flipProc) ProcessBatch(ctx context.Context, batch service.MessageBatch) ([]service.MessageBatch, error) {
6052
outBatch := make(service.MessageBatch, len(batch))
6153
for i, msg := range batch {

public/wasm/examples/uppercase_processor/plugin_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ func TestPluginExecute(t *testing.T) {
7474
uppercase:
7575
prefix: ">> "
7676
`)
77+
require.NoError(t, err)
7778

7879
p, err := mgr.NewProcessor(conf)
7980
require.NoError(t, err)
@@ -88,10 +89,10 @@ uppercase:
8889
require.Len(t, res, 1)
8990
require.Len(t, res[0], 3)
9091

91-
require.Equal(t, message.GetAllBytes(res[0]), expectedData)
92+
require.Equal(t, expectedData, message.GetAllBytes(res[0]))
9293

9394
for _, msg := range res[0] {
9495
meta := msg.MetaGetStr("processed_by")
95-
require.Equal(t, meta, "uppercase_wasm")
96+
require.Equal(t, "uppercase_wasm", meta)
9697
}
9798
}

0 commit comments

Comments
 (0)