Workspace CI fixes

Author: MarcGuiselin

.githooks/pre-push

@@ -37,12 +37,12 @@ fi
 
 echo "🔎 pre-push: running checks that mirror GitHub CI"
 echo "• cargo test"
-cargo test
+cargo test --workspace --all-features
 
-echo "• cargo clippy -- -D warnings"
-cargo clippy -- -D warnings
+echo "• cargo clippy"
+cargo clippy --workspace --all-targets --all-features -- -D warnings
 
-echo "• cargo fmt --all -- --check"
+echo "• cargo fmt"
 cargo fmt --all -- --check
 
 echo "✅ pre-push: all checks passed"

.github/workflows/ci.yaml

@@ -33,9 +33,9 @@ jobs:
       - name: Install Dependencies
         run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev
       - name: Run cargo test
-        run: cargo test
+        run: cargo test --workspace --all-features
 
-  # Run cargo clippy -- -D warnings
+  # Run cargo clippy
   clippy_check:
     name: Clippy
     runs-on: ubuntu-latest
@@ -60,7 +60,7 @@ jobs:
       - name: Install Dependencies
         run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev
       - name: Run clippy
-        run: cargo clippy -- -D warnings
+        run: cargo clippy --workspace --all-targets --all-features -- -D warnings
 
   # Run cargo doc with rustdoc warnings denied
   docs:
@@ -85,9 +85,9 @@ jobs:
       - name: Install Dependencies
         run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev libwayland-dev
       - name: Run cargo doc
-        run: RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --workspace --all-features --exclude guest_wit_example --exclude host_wit_example --exclude simple
+        run: RUSTDOCFLAGS="-D warnings" cargo doc --no-deps --workspace --all-features
 
-  # Run cargo fmt --all -- --check
+  # Run cargo fmt
   format:
     name: Format
     runs-on: ubuntu-latest

crates/wasvy_cli/src/dependency.rs

@@ -73,7 +73,7 @@ impl Dependency {
     }
 
     pub fn resolve(&self, path: impl AsRef<Path>, resolve: &mut Resolve) -> Result<PackageId> {
-        let path = path.as_ref().join(&self.file_name());
+        let path = path.as_ref().join(self.file_name());
         resolve.push_str(path, &self.interface)
     }
 
@@ -109,7 +109,7 @@ impl Dependency {
 
 impl WriteTo for Dependency {
     fn write(&self, path: impl AsRef<Path>) -> Result<()> {
-        let path = path.as_ref().join(&self.file_name());
+        let path = path.as_ref().join(self.file_name());
         write(&path, self.interface.as_bytes())
     }
 }

crates/wasvy_cli/src/languages/python.rs

@@ -105,7 +105,7 @@ impl Language for Python {
 }
 
 fn get_name(path: &Path) -> Option<String> {
-    let contents = fs::read_to_string(&path).ok()?;
+    let contents = fs::read_to_string(path).ok()?;
     let value = contents.parse::<toml::Table>().ok()?;
     value
         .get("project")?

crates/wasvy_cli/src/languages/rust.rs

@@ -125,7 +125,7 @@ impl Language for Rust {
 }
 
 fn get_name(path: &Path) -> Option<String> {
-    let contents = fs::read_to_string(&path).ok()?;
+    let contents = fs::read_to_string(path).ok()?;
     let value = contents.parse::<toml::Table>().ok()?;
     value
         .get("package")?

crates/wasvy_cli/src/main.rs

@@ -15,7 +15,7 @@ fn main() {
     // Create the CLI runtime
     let runtime = {
         let mut config = Config::default();
-        for dep in remote.dependencies {
+        for dep in remote.dependencies.iter() {
             let name = format!("{dep}");
             if let Err(err) = config.add_dependency(dep) {
                 println!("Could not resolve remote dependency {name} because: {err:?}");