Skip to content

Need to add examples and benchmarks for other PhreeqcDatabases #13

@avdudchenko

Description

@avdudchenko

Current testing is done exclusivly with pitzer.dat, but it was observed that other databases could produce unexpected results. This was partly due to commission of pH balance on any of block with exact speciation and observed for llnl.dat and wateq4f database. This would typically result in unexpected pH changes for exact speciated block ( adding acid increases pH rather then drops it).

The PR on ph Balance should solve the problem, but needs explicit benchmarks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions