Skip to content

Commit 462a475

Browse files
germanattanasiomingzhi22dpopp07w0okant
authored
fix: Use readable-stream to enable angular users (#118)
Fixes #103 and could also solve the problem with #83. I made a mistake with the rebase so we should squash this with a `fix: Add support for Angular` commit message Co-authored-by: Michael Chou <[email protected]> Co-authored-by: Dustin Popp <[email protected]> Co-authored-by: null <[email protected]> Co-authored-by: Darío Hereñú <[email protected]> Co-authored-by: Gurvinder Singh <[email protected]>
1 parent 72b0b70 commit 462a475

11 files changed

+637
-209
lines changed

Diff for: README.md

+11
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,17 @@ In a local environment you should set only the `TEXT_TO_SPEECH_IAM_APIKEY` and `
4343

4444
Once that is set up, the token can be used in your SDK request with the parameter `access_token`. See [this example](https://github.com/watson-developer-cloud/speech-javascript-sdk/blob/master/examples/static/microphone-streaming.html#L36).
4545

46+
## Using with Angular
47+
48+
Make sure `polyfills.ts` has following entries:
49+
50+
```js
51+
(window as any).global = window;
52+
(window as any).process = require('process/browser');
53+
import 'zone.js/dist/zone'; // Included with Angular CLI.
54+
global.Buffer = global.Buffer || require('buffer').Buffer;
55+
```
56+
4657
## Changes
4758

4859
See [CHANGELOG.md](CHANGELOG.md) for a complete list of changes.

Diff for: package-lock.json

+610-196
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+7-5
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@
3434
}
3535
],
3636
"devDependencies": {
37-
"@babel/cli": "^7.2.3",
38-
"@babel/core": "^7.4.0",
39-
"@babel/preset-env": "^7.4.2",
37+
"@babel/cli": "^7.4.3",
38+
"@babel/core": "^7.4.3",
39+
"@babel/preset-env": "^7.4.3",
4040
"babel-loader": "^8.0.5",
4141
"babelify": "^10.0.0",
4242
"browserify": "^16.2.3",
@@ -68,18 +68,20 @@
6868
"webpack-cli": "^3.3.0"
6969
},
7070
"dependencies": {
71-
"@babel/polyfill": "^7.4.0",
71+
"@babel/polyfill": "^7.4.3",
7272
"buffer-from": "^1.1.1",
7373
"clone": "^2.1.2",
7474
"core-js": "^3.0.0",
7575
"defaults": "^1.0.3",
7676
"get-user-media-promise": "^1.1.4",
7777
"lodash.pullallwith": "^4.7.0",
78-
"microphone-stream": "^4.1.3",
78+
"microphone-stream": "^5.0.1",
7979
"nodeify-fetch": "^1.0.1",
8080
"object.assign": "^4.1.0",
8181
"object.pick": "^1.3.0",
82+
"path": "^0.12.7",
8283
"readable-blob-stream": "^1.1.0",
84+
"readable-stream": "^3.3.0",
8385
"watson-developer-cloud": "^3.18.3",
8486
"websocket": "^1.0.28",
8587
"whatwg-fetch": "^2.0.4"

Diff for: speech-to-text/format-stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
var Transform = require('stream').Transform;
3+
var { Transform } = require('readable-stream');
44
var util = require('util');
55
var clone = require('clone');
66
var defaults = require('defaults');

Diff for: speech-to-text/recognize-microphone.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ var L16 = require('./webaudio-l16-stream.js');
2222
var FormatStream = require('./format-stream.js');
2323
var assign = require('object.assign/polyfill')();
2424
var WritableElementStream = require('./writable-element-stream');
25-
var Writable = require('stream').Writable;
25+
var { Writable } = require('readable-stream');
2626
var ResultStream = require('./result-stream');
2727
var SpeakerStream = require('./speaker-stream');
2828

Diff for: speech-to-text/recognize-stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
'use strict';
1818

19-
var Duplex = require('stream').Duplex;
19+
var { Duplex } = require('readable-stream');
2020
var util = require('util');
2121
var pick = require('object.pick');
2222
var W3CWebSocket = require('websocket').w3cwebsocket;

Diff for: speech-to-text/result-stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
'use strict';
1818

19-
var Transform = require('stream').Transform;
19+
var { Transform } = require('readable-stream');
2020
var util = require('util');
2121
var clone = require('clone');
2222

Diff for: speech-to-text/speaker-stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
'use strict';
1818

19-
var Transform = require('stream').Transform;
19+
var { Transform } = require('readable-stream');
2020
var util = require('util');
2121
var pullAllWith = require('lodash.pullallwith');
2222
var noTimestamps = require('./no-timestamps');

Diff for: speech-to-text/timing-stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
var Transform = require('stream').Transform;
3+
var { Transform } = require('readable-stream');
44
var util = require('util');
55
var defaults = require('defaults');
66
var noTimestamps = require('./no-timestamps');

Diff for: speech-to-text/webaudio-l16-stream.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
2-
var Transform = require('stream').Transform;
2+
3+
var { Transform } = require('readable-stream');
34
var util = require('util');
45
var defaults = require('defaults');
56
// some versions of the buffer browser lib don't support Buffer.from (such as the one included by the current version of express-browserify)

Diff for: speech-to-text/writable-element-stream.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
var Writable = require('stream').Writable;
3+
var { Writable } = require('readable-stream');
44
var util = require('util');
55
var defaults = require('defaults');
66

0 commit comments

Comments
 (0)