Add CentOS 8/Python3 support (#16)

* Update dispatcher version; add Galaxy tags

* Fix tarball name for >=4.3.3

* Fix indentation error

* Fix dispatcher tarball name tokens

* Fix tarball name when using libssl1.1

* Improve libssl version referencing

* Split setting SSL facts in two steps

* Include var file when setting up RedHat

* Fix inclusion of distro-specific variables

* Fix openssl version number for CentOS distros

* Fix SELinux package names for Python3

* Fix typo

* Change way of including RedHat-specific variables

* Replace YAML multiline strings

* Skip Ansible lint on two files

* Fix skip_ansible_lint tagging

* Fix multiline YAML syntax

* Remove (hopefully) redundant regex

* Fix typo

* Fix regex for Maven classifier coordinate

* Fix version cast; Remove extra_opts in unpack_module.yml

* Fix dispatcher module filename regex

* Fix dispatcher module filename regex for good

* Use version comparators

Author: bellackn

defaults/main.yml

@@ -1,5 +1,5 @@
 # Dispatcher version to install
-aem_dispatcher_version: 4.3.2
+aem_dispatcher_version: 4.3.3
 # Whether to install dispatcher with SSL support
 aem_dispatcher_ssl_support: true
 

meta/main.yml

@@ -12,13 +12,15 @@ galaxy_info:
     versions:
     - trusty
     - xenial
+    - bionic
   - name: Debian
     versions:
     - jessie
     - stretch
   - name: EL
     versions:
     - 7
+    - 8
 
   galaxy_tags:
     - aem

tasks/download/maven_repository.yml

@@ -22,5 +22,6 @@
     username: "{{ aem_dispatcher_maven_repository_username | default(omit) }}"
     password: "{{ aem_dispatcher_maven_repository_password | default(omit) }}"
     version: "{{ item.version | default(aem_dispatcher_version) }}"
-    classifier: "{{ item.classifier | default(aem_dispatcher_tarball_name | regex_replace('dispatcher-(.*)-([\\d\\.]*)\\.tar\\.gz', '\\1')) }}"
+    classifier: "{{ item.classifier | default(aem_dispatcher_tarball_name |
+      regex_replace('dispatcher-[\\d|\\.]*-(.*)\\.tar\\.gz', '\\1') ) }}"
   with_items: "{{ aem_dispatcher_maven_repository_coordinates }}"

tasks/main.yml

@@ -23,4 +23,4 @@
   when: aem_dispatcher_install_source != "package"
 
 - name: Include OS-specific setup.
-  include_tasks: "setup_{{ ansible_os_family }}.yml"
+  include_tasks: "setup_{{ ansible_os_family }}.yml"

tasks/setup_RedHat.yml

@@ -6,7 +6,8 @@
 
 - name: Install SELinux Python dependencies.
   package:
-    name: libsemanage-python
+    name: >-
+      {{ 'libsemanage-python' if ansible_distribution_major_version is version('8', '<') else 'libsemanage-python3' }}
     state: present
 
 - name: Configure SELinux to allow Apache to create outbound connections.

tasks/tarball_name.yml

@@ -14,15 +14,24 @@
   set_fact:
     aem_dispatcher_tarball_tokens:
       - "dispatcher"
+      - "{{ aem_dispatcher_version }}"
       - "apache{{ apache_version | regex_replace('(\\d+\\.\\d+).*', '\\1') }}"
       - "{{ ansible_system | lower }}"
-      - "{{ ansible_architecture | regex_replace('_', '-') }}"
+      - "{{ ansible_architecture if aem_dispatcher_version is version('4.3.3', '>=')
+        else ansible_architecture | regex_replace('_', '-') }}"
 
-- name: Add SSL filename token.
+- name: Create SSL token name from used libssl version.
   set_fact:
-    aem_dispatcher_tarball_tokens: "{{ aem_dispatcher_tarball_tokens + ['ssl'] }}"
+    aem_dispatcher_ssl_token: "{{ 'ssl' + aem_dispatcher_libssl_version | regex_replace('(\\d+\\.\\d+).*', '\\1')
+      if aem_dispatcher_version is version('4.3.3', '>=')
+      else 'ssl' }}"
+  when: aem_dispatcher_ssl_support
+
+- name: Add SSL token to filename tokens.
+  set_fact:
+    aem_dispatcher_tarball_tokens: "{{ aem_dispatcher_tarball_tokens + [aem_dispatcher_ssl_token] }}"
   when: aem_dispatcher_ssl_support
 
 - name: Build dispatcher tarball name.
   set_fact:
-    aem_dispatcher_tarball_name: "{{ aem_dispatcher_tarball_tokens | join('-') }}-{{ aem_dispatcher_version }}.tar.gz"
+    aem_dispatcher_tarball_name: "{{ aem_dispatcher_tarball_tokens | join('-') }}.tar.gz"

tasks/unpack_module.yml

@@ -1,14 +1,13 @@
 ---
 - name: Derive module filename from tarball name.
   set_fact:
-    _aem_dispatcher_module_filename:
-      "{{ aem_dispatcher_tarball_name | regex_replace('(dispatcher-apache.*?)-.*-(.*).tar.gz', '\\1-\\2.so') }}"
+    _aem_dispatcher_module_filename: >-
+      {{ aem_dispatcher_tarball_name | regex_replace('(dispatcher)-([\d|\.]*)-(apache[\d|\.]*).*', '\1-\3-\2.so') }}
 
 - name: Unpack Dispatcher module.
   unarchive:
     src: "{{ aem_dispatcher_download_path }}/{{ aem_dispatcher_tarball_name }}"
     remote_src: yes
-    extra_opts: ["{{ _aem_dispatcher_module_filename }}"]
     dest: "{{ aem_dispatcher_module_path }}"
     mode: 0755
     owner: root

vars/family_RedHat.yml

@@ -1,2 +1,6 @@
 aem_dispatcher_module_path: /usr/lib64/httpd/modules
-_aem_dispatcher_apache_server_root: "{{ aem_dispatcher_apache_server_root | default(apache_server_root) | default('/etc/httpd') }}"
+_aem_dispatcher_apache_server_root: >-
+  {{ aem_dispatcher_apache_server_root | default(apache_server_root) | default('/etc/httpd') }}
+
+aem_dispatcher_libssl_version: >-
+  {{ '1.1.1' if ansible_distribution_major_version is version('8', '>=') else '1.0.2k' }}