Skip to content

Commit 0187e1b

Browse files
committed
fix: e2e workflows
Signed-off-by: will <[email protected]>
1 parent 490308f commit 0187e1b

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

.github/workflows/test-chart.yml

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,22 @@ jobs:
4949
- name: Update Helm chart dependencies
5050
run: helm dependency update ./dist/chart
5151

52+
- name: Install cert-manager
53+
run: |
54+
helm repo add jetstack https://charts.jetstack.io
55+
helm repo update
56+
helm install cert-manager jetstack/cert-manager \
57+
--namespace cert-manager \
58+
--create-namespace \
59+
--version v1.16.3 \
60+
--set crds.enabled=true
61+
62+
- name: Wait for cert-manager to be ready
63+
run: |
64+
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager
65+
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager-cainjector
66+
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager-webhook
67+
5268
# TODO: Uncomment if Prometheus is enabled
5369
# - name: Install Prometheus Operator CRDs
5470
# run: |
@@ -68,19 +84,13 @@ jobs:
6884

6985
- name: Install Helm chart for project
7086
run: |
71-
helm install my-release ./dist/chart --create-namespace --namespace imageshift-v2-system --set certmanager.install=true
72-
73-
- name: Wait for cert-manager to be ready
74-
run: |
75-
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager
76-
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager-cainjector
77-
kubectl wait --namespace cert-manager --for=condition=available --timeout=300s deployment/cert-manager-webhook
87+
helm install my-release ./dist/chart --create-namespace --namespace imageshift --set certmanager.install=false
7888
7989
- name: Check Helm release status
8090
run: |
81-
helm status my-release --namespace imageshift-v2-system
91+
helm status my-release --namespace imageshift
8292
8393
# TODO: Uncomment if prometheus.enabled is set to true to confirm that the ServiceMonitor gets created
8494
# - name: Check Presence of ServiceMonitor
8595
# run: |
86-
# kubectl wait --namespace imageshift-v2-system --for=jsonpath='{.kind}'=ServiceMonitor servicemonitor/imageshift-v2-controller-manager-metrics-monitor
96+
# kubectl wait --namespace imageshift --for=jsonpath='{.kind}'=ServiceMonitor servicemonitor/imageshift-v2-controller-manager-metrics-monitor

test/e2e/e2e_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
)
3232

3333
// namespace where the project is deployed in
34-
const namespace = "imageshift-v2-system"
34+
const namespace = "imageshift"
3535

3636
// serviceAccountName created for the project
3737
const serviceAccountName = "imageshift-v2-controller-manager"

0 commit comments

Comments
 (0)