Skip to content

Commit 8b11788

Browse files
committed
Fix USD detection for v24.08 compatibility
1 parent e46068b commit 8b11788

File tree

5 files changed

+39
-8
lines changed

5 files changed

+39
-8
lines changed

.github/workflows/test-linux.yml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
strategy:
2222
fail-fast: false
2323
matrix:
24-
usd: ["v25.05"]
24+
usd: ["v24.08", "v25.05"]
2525
python: ["3.10", "3.12"]
2626

2727
name: "USD-${{ matrix.usd }}-py${{ matrix.python }}"
@@ -42,11 +42,23 @@ jobs:
4242
mkdir -p ${{github.workspace}}/build
4343
mkdir -p ${{runner.temp}}/USD
4444
45-
- name: Install USD
45+
- name: Download USD
4646
working-directory: ${{runner.temp}}/USD
4747
run: |
4848
git clone https://github.com/PixarAnimationStudios/OpenUSD.git \
4949
--depth 1 --branch ${{ matrix.usd }} ./src
50+
51+
- name: Apply patch for USD v24.08
52+
if: matrix.usd == 'v24.08'
53+
working-directory: ${{runner.temp}}/USD
54+
run: |
55+
sed -i '/BOOST_URL/ s|boostorg.jfrog.io.*/release|sourceforge.net/projects/boost/files/boost|' src/build_scripts/build_usd.py
56+
sed -i '/BOOST_URL/ s|source/boost|boost|' src/build_scripts/build_usd.py
57+
sed -i '/BOOST_URL/ s|\.zip"|.zip/download"|' src/build_scripts/build_usd.py
58+
59+
- name: Install USD
60+
working-directory: ${{runner.temp}}/USD
61+
run: |
5062
python ./src/build_scripts/build_usd.py . \
5163
--no-tests \
5264
--no-examples \

.github/workflows/test-windows.yml

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
strategy:
2222
fail-fast: false
2323
matrix:
24-
usd: ["v25.05"]
24+
usd: ["v24.08", "v25.05"]
2525
python: ["3.10", "3.12"]
2626

2727
name: "USD-${{ matrix.usd }}-py${{ matrix.python }}"
@@ -41,15 +41,29 @@ jobs:
4141
cmake -E make_directory ${{github.workspace}}\build
4242
cmake -E make_directory ${{runner.temp}}\USD
4343
44+
- name: Download USD
45+
working-directory: ${{runner.temp}}/USD
46+
shell: cmd
47+
run: |
48+
git clone https://github.com/PixarAnimationStudios/OpenUSD.git ^
49+
--depth 1 --branch ${{ matrix.usd }} ./src
50+
51+
- name: Apply patch for USD v24.08
52+
if: matrix.usd == 'v24.08'
53+
working-directory: ${{runner.temp}}/USD
54+
shell: bash
55+
run: |
56+
sed -i '/BOOST_URL/ s|boostorg.jfrog.io.*/release|sourceforge.net/projects/boost/files/boost|' src/build_scripts/build_usd.py
57+
sed -i '/BOOST_URL/ s|source/boost|boost|' src/build_scripts/build_usd.py
58+
sed -i '/BOOST_URL/ s|\.zip"|.zip/download"|' src/build_scripts/build_usd.py
59+
4460
- name: Install USD
4561
working-directory: ${{runner.temp}}/USD
4662
shell: cmd
4763
run: |
4864
call "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat"
4965
set VCPKG_TARGET_TRIPLET=x64-windows
5066
set CMAKE_TOOLCHAIN_FILE=%VCPKG_INSTALLATION_ROOT%/scripts/buildsystems/vcpkg.cmake
51-
git clone https://github.com/PixarAnimationStudios/OpenUSD.git ^
52-
--depth 1 --branch ${{ matrix.usd }} ./src
5367
python ./src/build_scripts/build_usd.py . ^
5468
--generator "Visual Studio 16 2019" ^
5569
--no-tests ^

cmake/modules/FindUSD.cmake

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,6 @@ find_package_handle_standard_args(
111111
plug_LIBRARY
112112
arch_LIBRARY
113113
vt_LIBRARY
114-
boost_LIBRARY
115-
python_LIBRARY
116114
VERSION_VAR
117115
USD_VERSION
118116
)

doc/sphinx/release/release_notes.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@
44
Release Notes
55
*************
66

7+
.. release:: Upcoming
8+
9+
.. change:: fixed
10+
11+
Fixed CMake module to detect USD without requiring `usd::boost` or `usd::python`,
12+
maintaining compatibility with OpenUSD v24.08.
13+
714
.. release:: 0.8.1
815
:date: 2025-05-13
916

src/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ target_link_libraries(unf
4242

4343
# Transitive Pixar libraries depend on vendorized Boost.Python
4444
# (Required due to manual CMake module used to locate USD)
45-
if (BUILD_PYTHON_BINDINGS)
45+
if (BUILD_PYTHON_BINDINGS AND USD_USE_INTERNAL_BOOST_PYTHON)
4646
target_link_libraries(unf PUBLIC usd::boost usd::python)
4747
endif()
4848

0 commit comments

Comments
 (0)