Fix: Empty any arrays if item in group is an object to remove from group#317
Fix: Empty any arrays if item in group is an object to remove from group#317tmurph21 wants to merge 1 commit into
Conversation
|
Interesting, can you provide a reproduction example of how the current state is insufficient or incorrect? I need some convincing that splicing an array (which could have object references outside of the scope of VF) makes the most sense here as opposed to just removing it's reference from the model, but I'm genuinely interested to see the use case. If we move forward on this one, it would be great to get a backing test(s) for it in this PR too. Thanks! |
|
Here is an example: https://codesandbox.io/s/peaceful-sanderson-0cwco?file=/src/App.vue The error occurs when you attempt to remove an item in the group IF the nested group an object with keys Conditions: Note: I have not tested more than 1 level deep (so probably need to test this to see if recursion is needed) |
Currently the removeItem method does not fully remove an object from the group if the object has any nested arrays as values