Remove ApiServlet.LADYBUG_API_PATH from path annotations

[nielsm5]

If the path never changes, why not set it globally:

ladybug/src/main/resources/ladybug/cxf-beans.xml

Lines 18 to 22 in 7fef56e

	<jaxrs:server id="Ladybug-Api" bus="ladybug-api-bus" address="/" basePackages="nl.nn.testtool.web.api">
	<jaxrs:inInterceptors>
	<ref bean="gZipInterceptor" />
	</jaxrs:inInterceptors>
	<jaxrs:providers>

Change address to the path you wish to use.

That should also make the ApiServlet class absolute.

[nielsm5]

It seems that since Spring-Security 6.5.0 they have implemented new ways to ensure the correct endpoints are being called, this results in the following exception: Invalid contextPath '/iaf-test/iaf/ladybug/api': must match the start of requestPath: 'ladybug-api/testtool/stub-strategies'.

[jacodg]

I added it primarily for use with Ladybug in a Quarkus application. Quarkus does not use CXF and will utilize the @Path annotations in the API classes of the package nl.nn.testtool.web.api, exposing them directly at the root of the application. E.g. when /ladybug-api/ isn't used in the @Path annotations this would result in url's like:

http://localhost:8080/metadata
http://localhost:8080/report
http://localhost:8080/runner
...

instead of:

http://localhost:8080/ladybug-api/metadata
http://localhost:8080/ladybug-api/report
http://localhost:8080/ladybug-api/runner
...

This could potentially conflict with @Path annotations in the user's application or other libraries.

For the Frank!Framework it would result in url's like http://localhost/iaf/ladybug/api/ladybug-api/metadata. With the ApiServlet this is changed to http://localhost/iaf/ladybug/api/metadata.

Possible options:

• Remove /ladybug-api/ and ignore potential conflicts in @Path's in case of working with Quarkus.
• Remove the ApiServlet and accept the longer http://localhost/iaf/ladybug/api/ladybug-api url in Frank!Framework.
• Change /ladybug-api/ to /ladybug/ and remove ApiServlet and map Ladybug API to http://localhost/iaf/api/ladybug
• Change /ladybug-api/ to /ladybug/ and remove ApiServlet and map both Ladybug API and Ladybug frontend to http://localhost/ladybug.

I didn't test the last two options with Frank!Framework but I think it is possible. Did a quick test with Quarkus that has the following in web.xml:

<servlet-mapping>
	<servlet-name>LadybugFrontendServlet</servlet-name>
	<url-pattern>/ladybug/*</url-pattern>
</servlet-mapping>

This can be combined with a resource with @Path("/ladybug/hello") making the Ladybug frontend available at http://localhost:8080/ladybug and the annotated resource at http://localhost:8080/ladybug/hello