Skip to content

TCP sends block forever #125

Open
Open
@bboreham

Description

@bboreham

We set a deadline on reads but not on writes. This means if something is blocking the other end of the connection we will wait forever.

Since we expect connected peers to be fairly live, a deadline around the length of a heartbeat should allow us to error on stalled peers while not affecting normal operation.
Worst case, a connection would be torn down then re-established.

Seen at weaveworks/weave#3762

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions