Skip to content

encryptedTCPSender.Send() holds a lock over a TCP send #126

Open
@bboreham

Description

@bboreham

Lock is not released until the Send() returns.

Taken together with #125 this means it can hold a lock forever.

Sender and receiver each maintain state including a sequence number, so if we unlock before calling Send() it's possible that messages get out of order.

Seen at weaveworks/weave#3762

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions