Skip to content

Commit 5c4e306

Browse files
authored
Merge pull request #11 from weaveworks/switch-to-flux-logging
Switch to using Flux logging.
2 parents b6c5b56 + f912836 commit 5c4e306

File tree

3 files changed

+20
-21
lines changed

3 files changed

+20
-21
lines changed

go.mod

+6-6
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ module github.com/weaveworks/templates-controller
33
go 1.19
44

55
require (
6-
github.com/fluxcd/pkg/runtime v0.31.0
6+
github.com/fluxcd/pkg/runtime v0.33.0
7+
github.com/google/go-cmp v0.5.9
8+
github.com/spf13/pflag v1.0.5
79
github.com/stretchr/testify v1.8.2
8-
k8s.io/apimachinery v0.26.2
9-
k8s.io/client-go v0.26.2
10+
k8s.io/apimachinery v0.26.3
11+
k8s.io/client-go v0.26.3
1012
sigs.k8s.io/controller-runtime v0.14.5
1113
)
1214

@@ -26,7 +28,6 @@ require (
2628
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
2729
github.com/golang/protobuf v1.5.2 // indirect
2830
github.com/google/gnostic v0.6.9 // indirect
29-
github.com/google/go-cmp v0.5.9 // indirect
3031
github.com/google/gofuzz v1.2.0 // indirect
3132
github.com/google/uuid v1.3.0 // indirect
3233
github.com/imdario/mergo v0.3.13 // indirect
@@ -43,7 +44,6 @@ require (
4344
github.com/prometheus/client_model v0.3.0 // indirect
4445
github.com/prometheus/common v0.37.0 // indirect
4546
github.com/prometheus/procfs v0.8.0 // indirect
46-
github.com/spf13/pflag v1.0.5 // indirect
4747
go.uber.org/atomic v1.10.0 // indirect
4848
go.uber.org/multierr v1.8.0 // indirect
4949
go.uber.org/zap v1.24.0 // indirect
@@ -59,7 +59,7 @@ require (
5959
gopkg.in/inf.v0 v0.9.1 // indirect
6060
gopkg.in/yaml.v2 v2.4.0 // indirect
6161
gopkg.in/yaml.v3 v3.0.1 // indirect
62-
k8s.io/api v0.26.2 // indirect
62+
k8s.io/api v0.26.3 // indirect
6363
k8s.io/apiextensions-apiserver v0.26.1 // indirect
6464
k8s.io/component-base v0.26.2 // indirect
6565
k8s.io/klog/v2 v2.90.1 // indirect

go.sum

+8-8
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ github.com/evanphx/json-patch v5.6.0+incompatible h1:jBYDEEiFBPxA0v50tFdvOzQQTCv
7676
github.com/evanphx/json-patch/v5 v5.6.0 h1:b91NhWfaz02IuVxO9faSllyAtNXHMPkC5J8sJCLunww=
7777
github.com/evanphx/json-patch/v5 v5.6.0/go.mod h1:G79N1coSVB93tBe7j6PhzjmR3/2VvlbKOFpnXhI9Bw4=
7878
github.com/flowstack/go-jsonschema v0.1.1/go.mod h1:yL7fNggx1o8rm9RlgXv7hTBWxdBM0rVwpMwimd3F3N0=
79-
github.com/fluxcd/pkg/runtime v0.31.0 h1:addyXaANHl/A68bEjCbiR4HzcFKgfXv1eaG7B7ZHxOo=
80-
github.com/fluxcd/pkg/runtime v0.31.0/go.mod h1:toGOOubMo4ZC1aWhB8C3drdTglr1/A1dETeNwjiIv0g=
79+
github.com/fluxcd/pkg/runtime v0.33.0 h1:y6mFOj22mU/BXAxSTucTlT7vrWUjd0+iccK0pRN5CF0=
80+
github.com/fluxcd/pkg/runtime v0.33.0/go.mod h1:oDTerqMMtOQVNZeidwAPG7g/ai2xuidUduJzQh1IBVI=
8181
github.com/fsnotify/fsnotify v1.6.0 h1:n+5WquG0fcWoWp6xPWfHdbskMCQaFnG6PfBrh1Ky4HY=
8282
github.com/fsnotify/fsnotify v1.6.0/go.mod h1:sl3t1tCWJFWoRz9R8WJCbQihKKwmorjAbSClcnxKAGw=
8383
github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
@@ -619,14 +619,14 @@ honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWh
619619
honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
620620
honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
621621
honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
622-
k8s.io/api v0.26.2 h1:dM3cinp3PGB6asOySalOZxEG4CZ0IAdJsrYZXE/ovGQ=
623-
k8s.io/api v0.26.2/go.mod h1:1kjMQsFE+QHPfskEcVNgL3+Hp88B80uj0QtSOlj8itU=
622+
k8s.io/api v0.26.3 h1:emf74GIQMTik01Aum9dPP0gAypL8JTLl/lHa4V9RFSU=
623+
k8s.io/api v0.26.3/go.mod h1:PXsqwPMXBSBcL1lJ9CYDKy7kIReUydukS5JiRlxC3qE=
624624
k8s.io/apiextensions-apiserver v0.26.1 h1:cB8h1SRk6e/+i3NOrQgSFij1B2S0Y0wDoNl66bn8RMI=
625625
k8s.io/apiextensions-apiserver v0.26.1/go.mod h1:AptjOSXDGuE0JICx/Em15PaoO7buLwTs0dGleIHixSM=
626-
k8s.io/apimachinery v0.26.2 h1:da1u3D5wfR5u2RpLhE/ZtZS2P7QvDgLZTi9wrNZl/tQ=
627-
k8s.io/apimachinery v0.26.2/go.mod h1:ats7nN1LExKHvJ9TmwootT00Yz05MuYqPXEXaVeOy5I=
628-
k8s.io/client-go v0.26.2 h1:s1WkVujHX3kTp4Zn4yGNFK+dlDXy1bAAkIl+cFAiuYI=
629-
k8s.io/client-go v0.26.2/go.mod h1:u5EjOuSyBa09yqqyY7m3abZeovO/7D/WehVVlZ2qcqU=
626+
k8s.io/apimachinery v0.26.3 h1:dQx6PNETJ7nODU3XPtrwkfuubs6w7sX0M8n61zHIV/k=
627+
k8s.io/apimachinery v0.26.3/go.mod h1:ats7nN1LExKHvJ9TmwootT00Yz05MuYqPXEXaVeOy5I=
628+
k8s.io/client-go v0.26.3 h1:k1UY+KXfkxV2ScEL3gilKcF7761xkYsSD6BC9szIu8s=
629+
k8s.io/client-go v0.26.3/go.mod h1:ZPNu9lm8/dbRIPAgteN30RSXea6vrCpFvq+MateTUuQ=
630630
k8s.io/component-base v0.26.2 h1:IfWgCGUDzrD6wLLgXEstJKYZKAFS2kO+rBRi0p3LqcI=
631631
k8s.io/component-base v0.26.2/go.mod h1:DxbuIe9M3IZPRxPIzhch2m1eT7uFrSBJUBuVCQEBivs=
632632
k8s.io/klog/v2 v2.90.1 h1:m4bYOKall2MmOiRaR1J+We67Do7vm9KiQVlT96lnHUw=

main.go

+6-7
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,19 @@ limitations under the License.
1717
package main
1818

1919
import (
20-
"flag"
2120
"os"
2221

2322
// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
2423
// to ensure that exec-entrypoint and run can make use of them.
2524
_ "k8s.io/client-go/plugin/pkg/client/auth"
2625

26+
"github.com/fluxcd/pkg/runtime/logger"
27+
flag "github.com/spf13/pflag"
2728
"k8s.io/apimachinery/pkg/runtime"
2829
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
2930
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
3031
ctrl "sigs.k8s.io/controller-runtime"
3132
"sigs.k8s.io/controller-runtime/pkg/healthz"
32-
"sigs.k8s.io/controller-runtime/pkg/log/zap"
3333

3434
capiv1alpha1 "github.com/weaveworks/templates-controller/apis/capi/v1alpha1"
3535
capiv1alpha2 "github.com/weaveworks/templates-controller/apis/capi/v1alpha2"
@@ -63,13 +63,12 @@ func main() {
6363
flag.BoolVar(&enableLeaderElection, "leader-elect", false,
6464
"Enable leader election for controller manager. "+
6565
"Enabling this will ensure there is only one active controller manager.")
66-
opts := zap.Options{
67-
Development: true,
68-
}
69-
opts.BindFlags(flag.CommandLine)
66+
67+
var logOptions logger.Options
68+
logOptions.BindFlags(flag.CommandLine)
7069
flag.Parse()
7170

72-
ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts)))
71+
ctrl.SetLogger(logger.NewLogger(logOptions))
7372

7473
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
7574
Scheme: scheme,

0 commit comments

Comments
 (0)