New tests

Author: Spomky

src/webauthn/src/PublicKeyCredentialSource.php

@@ -186,8 +186,10 @@ public function setOtherUI(?array $otherUI): self
     public static function createFromArray(array $data): self
     {
         $keys = array_keys(get_class_vars(self::class));
-        unset($keys['otherUI']);
         foreach ($keys as $key) {
+            if ('otherUI' === $key) {
+                continue;
+            }
             Assertion::keyExists($data, $key, sprintf('The parameter "%s" is missing', $key));
         }
         switch (true) {

tests/library/Unit/PublicKeyCredentialSourceTest.php

@@ -0,0 +1,63 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * The MIT License (MIT)
+ *
+ * Copyright (c) 2014-2020 Spomky-Labs
+ *
+ * This software may be modified and distributed under the terms
+ * of the MIT license.  See the LICENSE file for details.
+ */
+
+namespace Webauthn\Tests\Unit;
+
+use PHPUnit\Framework\TestCase;
+use Ramsey\Uuid\Uuid;
+use function Safe\json_decode;
+use Webauthn\PublicKeyCredentialSource;
+use Webauthn\TrustPath\EmptyTrustPath;
+
+/**
+ * @group unit
+ * @group Fido2
+ *
+ * @covers \Webauthn\TokenBinding\TokenBinding
+ *
+ * @internal
+ */
+class PublicKeyCredentialSourceTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function backwardCompatibilityIsEnsured(): void
+    {
+        $data = '{"publicKeyCredentialId":"cHVibGljS2V5Q3JlZGVudGlhbElk","type":"type","transports":["transport1","transport2"],"attestationType":"attestationType","trustPath":{"type":"Webauthn\\\\TrustPath\\\\EmptyTrustPath"},"aaguid":"014c0f17-f86f-4586-9914-2779922ba877","credentialPublicKey":"cHVibGljS2V5","userHandle":"dXNlckhhbmRsZQ","counter":123456789}';
+        $json = json_decode($data, true);
+        $source = PublicKeyCredentialSource::createFromArray($json);
+
+        static::assertEquals('publicKeyCredentialId', $source->getPublicKeyCredentialId());
+    }
+
+    /**
+     * @test
+     */
+    public function objectSerialization(): void
+    {
+        $tokenBinding = new PublicKeyCredentialSource(
+            'publicKeyCredentialId',
+            'type',
+            ['transport1', 'transport2'],
+            'attestationType',
+            EmptyTrustPath::createFromArray([]),
+            Uuid::fromString('02ffd35d-7f0c-46b5-9eae-851ee4807b25'),
+            'publicKey',
+            'userHandle',
+            123456789
+        );
+
+        static::assertEquals('{"publicKeyCredentialId":"cHVibGljS2V5Q3JlZGVudGlhbElk","type":"type","transports":["transport1","transport2"],"attestationType":"attestationType","trustPath":{"type":"Webauthn\\\\TrustPath\\\\EmptyTrustPath"},"aaguid":"02ffd35d-7f0c-46b5-9eae-851ee4807b25","credentialPublicKey":"cHVibGljS2V5","userHandle":"dXNlckhhbmRsZQ","counter":123456789,"otherUI":null}', json_encode($tokenBinding, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_SLASHES));
+    }
+}