From bdff171da6b5f0de87aa1c6a0d9178ae37569245 Mon Sep 17 00:00:00 2001 From: Zhou Xiao Date: Mon, 10 Feb 2025 16:35:03 +0800 Subject: [PATCH] fix(ui-tars): resolve page down and page up event error (#370) --- packages/shared/src/us-keyboard-layout.ts | 15 ++++++--------- packages/shared/tests/unit-test/keyboard.test.ts | 5 +++++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/packages/shared/src/us-keyboard-layout.ts b/packages/shared/src/us-keyboard-layout.ts index 199eb163f..397c18704 100644 --- a/packages/shared/src/us-keyboard-layout.ts +++ b/packages/shared/src/us-keyboard-layout.ts @@ -712,15 +712,12 @@ const keyMap: Record = { }; export function transformHotkeyInput(keyInput: string): string[] { + // page down + if (keyMap[keyInput.toLowerCase()]) { + return [getKeyDefinition(keyMap[keyInput.toLowerCase()])]; + } + return keyInput.split(' ').map((key) => { - let newKey = key; - if (keyMap[key.toLowerCase()]) { - newKey = keyMap[key.toLowerCase()]; - } - const keyDefinition = getKeyDefinition(newKey); - if (keyDefinition) { - return keyDefinition; - } - return newKey; + return getKeyDefinition(keyMap[key.toLowerCase()] || key); }); } diff --git a/packages/shared/tests/unit-test/keyboard.test.ts b/packages/shared/tests/unit-test/keyboard.test.ts index f5b4227b4..b781b29bf 100644 --- a/packages/shared/tests/unit-test/keyboard.test.ts +++ b/packages/shared/tests/unit-test/keyboard.test.ts @@ -59,4 +59,9 @@ describe('transformHotkeyInput', () => { it('should handle empty input', () => { expect(transformHotkeyInput('')).toEqual(['']); }); + + it('should handle page down', () => { + expect(transformHotkeyInput('page down')).toEqual(['PageDown']); + expect(transformHotkeyInput('page up')).toEqual(['PageUp']); + }); });