feat: use require.resolve to check react version to support pnpm catalog (#6919)

Author: caohuilin

.changeset/hungry-eggs-live.md

@@ -0,0 +1,7 @@
+---
+'@modern-js/utils': patch
+---
+
+feat: use require.resolve to check react version to fix use pnpm catalog in pnpm workspace
+
+feat: 使用 require.resolve 来检查 react 版本，以修复 pnpm workspace 中使用 pnpm catalog 的问题

packages/toolkit/utils/src/cli/is/project.ts

@@ -83,10 +83,7 @@ export const isVersionBeyond17 = (version: string): boolean => {
   return semver.gte(semver.minVersion(version)!, '17.0.0');
 };
 
-/**
- * @deprecated Use {@link isSupportAutomaticJsx} to check if the project supports automatic JSX instead.
- */
-export const isBeyondReact17 = (cwd: string) => {
+export const getReactVersion = (cwd: string): string | false => {
   const pkgPath = pkgUp.sync({ cwd });
 
   if (!pkgPath) {
@@ -102,48 +99,46 @@ export const isBeyondReact17 = (cwd: string) => {
   if (typeof deps.react !== 'string') {
     return false;
   }
+  try {
+    const reactPath = require.resolve('react/package.json', { paths: [cwd] });
 
-  return isVersionBeyond17(deps.react);
-};
-
-export const isSupportAutomaticJsx = (cwd: string) => {
-  const pkgPath = pkgUp.sync({ cwd });
+    const reactVersion = JSON.parse(fs.readFileSync(reactPath, 'utf8')).version;
 
-  if (!pkgPath) {
+    return reactVersion;
+  } catch (error) {
+    console.error('Failed to resolve React version:', error);
     return false;
   }
+};
+/**
+ * @deprecated Use {@link isSupportAutomaticJsx} to check if the project supports automatic JSX instead.
+ */
+export const isBeyondReact17 = (cwd: string) => {
+  const reactVersion = getReactVersion(cwd);
 
-  const pkgInfo = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
-  const deps = {
-    ...pkgInfo.devDependencies,
-    ...pkgInfo.dependencies,
-  };
-
-  if (typeof deps.react !== 'string') {
+  if (!reactVersion) {
     return false;
   }
-
-  return semver.satisfies(semver.minVersion(deps.react)!, '>=16.14.0');
+  return isVersionBeyond17(reactVersion);
 };
 
-export const isReact18 = (cwd: string = process.cwd()) => {
-  const pkgPath = path.join(cwd, 'package.json');
+export const isSupportAutomaticJsx = (cwd: string) => {
+  const reactVersion = getReactVersion(cwd);
 
-  if (!fs.existsSync(pkgPath)) {
+  if (!reactVersion) {
     return false;
   }
 
-  const pkgInfo = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
-  const deps = {
-    ...pkgInfo.devDependencies,
-    ...pkgInfo.dependencies,
-  };
+  return semver.satisfies(semver.minVersion(reactVersion)!, '>=16.14.0');
+};
 
-  if (typeof deps.react !== 'string') {
+export const isReact18 = (cwd: string = process.cwd()) => {
+  const reactVersion = getReactVersion(cwd);
+
+  if (!reactVersion) {
     return false;
   }
-
-  return semver.gte(semver.minVersion(deps.react)!, '18.0.0');
+  return semver.gte(semver.minVersion(reactVersion)!, '18.0.0');
 };
 
 /**