fix(env-dir): remove MODERN_ENV_DIR fallback behavior

Co-Authored-By: Aiden

Author: GiveMe-A-Name

packages/server/core/src/adapters/node/helper/loadEnv.ts

@@ -11,8 +11,7 @@ import type { ServerBaseOptions } from '../../../serverBase';
 export async function loadServerEnv(options: ServerBaseOptions) {
   const { pwd, envDir } = options;
   const serverEnv = process.env.MODERN_ENV;
-  const resolvedEnvDir = envDir ?? process.env.MODERN_ENV_DIR;
-  const envDirectory = resolveInsideOrFallback(pwd, resolvedEnvDir, pwd);
+  const envDirectory = resolveInsideOrFallback(pwd, envDir, pwd);
   const defaultEnvPath = path.resolve(envDirectory, `.env`);
   const serverEnvPath = path.resolve(envDirectory, `.env.${serverEnv}`);
 

packages/server/core/tests/adapters/loadEnv.test.ts

@@ -66,19 +66,4 @@ describe('test load serve env file', () => {
     delete process.env.USER_NAME;
     delete process.env.ENV;
   });
-
-  it('should load env from MODERN_ENV_DIR when envDir is not provided', async () => {
-    process.env.MODERN_ENV = 'prod';
-    process.env.MODERN_ENV_DIR = 'env';
-    await loadServerEnv({
-      pwd: envPwd,
-    } as any);
-
-    expect(process.env.USER_NAME).toBe('dir_prod_root');
-    expect(process.env.ENV).toBe('dir_prod');
-
-    delete process.env.USER_NAME;
-    delete process.env.ENV;
-    delete process.env.MODERN_ENV_DIR;
-  });
 });

packages/toolkit/plugin/src/cli/run/create.ts

@@ -77,7 +77,7 @@ export const createCli = <Extends extends CLIPluginExtends>() => {
     setProgramVersion(version);
 
     const envName = metaName === 'modern-js' ? 'MODERN' : metaName;
-    const envDir = options.envDir ?? process.env.MODERN_ENV_DIR;
+    const envDir = options.envDir;
     const envCwd = ensureAbsolutePath(appDirectory, envDir || '.');
 
     if (!isPathInside(appDirectory, envCwd)) {