Skip to content

Commit 1fc2a26

Browse files
authored
chore: use rslint for type checking (#7495)
1 parent 2461673 commit 1fc2a26

File tree

7 files changed

+13
-17
lines changed

7 files changed

+13
-17
lines changed

.github/workflows/test.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,3 @@ jobs:
107107
- name: Run E2E tests
108108
if: steps.changes.outputs.changed == 'true'
109109
run: node --run e2e
110-
111-
- name: Run E2E type checker
112-
if: steps.changes.outputs.changed == 'true'
113-
run: cd e2e && node --run type-check

e2e/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ This folder contains the E2E test cases of Rsbuild. The E2E suite is powered by
77
- `cases`: Test cases covering different Rsbuild features.
88
- `assets`: Common static assets, can be accessed using the `@e2e/assets` package.
99
- `scripts`: Shared helpers, can be accessed using the `@e2e/helper` package.
10+
- `type-tests`: Test cases for type checking, checked via `rslint --type-check`.
1011

1112
## Commands
1213

e2e/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
"version": "1.0.0",
66
"scripts": {
77
"setup": "pnpm exec playwright install chromium --with-deps",
8-
"e2e": "cross-env NODE_OPTIONS=\"$NODE_OPTIONS --experimental-vm-modules --no-warnings\" playwright test",
9-
"type-check": "tsc && pnpm run --filter @type-tests/* type-check"
8+
"e2e": "cross-env NODE_OPTIONS=\"$NODE_OPTIONS --experimental-vm-modules --no-warnings\" playwright test"
109
},
1110
"dependencies": {
1211
"@module-federation/runtime-tools": "2.3.2",
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
22
"name": "@type-tests/resolution-bundler",
33
"private": true,
4-
"type": "module",
5-
"scripts": {
6-
"type-check": "tsc --noEmit"
7-
}
4+
"type": "module"
85
}
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
22
"name": "@type-tests/resolution-nodenext",
33
"private": true,
4-
"type": "module",
5-
"scripts": {
6-
"type-check": "tsc --noEmit"
7-
}
4+
"type": "module"
85
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"doc": "cd website && node --run dev",
1313
"e2e": "cd ./e2e && pnpm e2e",
1414
"format": "prettier --experimental-cli --write . && heading-case --write",
15-
"lint": "rslint",
15+
"lint": "rslint --type-check",
1616
"prebundle": "pnpm --parallel --filter \"./packages/*\" run prebundle",
1717
"prepare": "simple-git-hooks && node --run prebundle && node --run build",
1818
"sort-package-json": "pnpx sort-package-json \"./package.json\" \"packages/*/package.json\"",
@@ -25,7 +25,7 @@
2525
"nano-staged": {
2626
"*.{md,mdx,json,css,less,scss}": "prettier --experimental-cli --write",
2727
"*.{js,jsx,ts,tsx,mjs,cjs}": [
28-
"rslint",
28+
"rslint --type-check",
2929
"prettier --experimental-cli --write"
3030
]
3131
},

rslint.config.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,13 @@ export default defineConfig([
55
{
66
languageOptions: {
77
parserOptions: {
8-
project: ['./packages/*/tsconfig.json', './e2e/tsconfig.json'],
8+
project: [
9+
'./packages/*/tsconfig.json',
10+
'./scripts/*/tsconfig.json',
11+
'./examples/*/tsconfig.json',
12+
'./e2e/tsconfig.json',
13+
'./e2e/type-tests/*/tsconfig.json',
14+
],
915
},
1016
},
1117
rules: {

0 commit comments

Comments
 (0)