feat(eslint-plugin-jest): add no-disabled-tests (#574)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: eryue0220

go.work.sum

@@ -14,6 +14,7 @@ golang.org/x/crypto v0.39.0/go.mod h1:L+Xg3Wf6HoL4Bn4238Z6ft6KfEpN0tJGo53AAPC632
 golang.org/x/crypto v0.41.0 h1:WKYxWedPGCTVVl5+WHSSrOBT0O8lx32+zxmHxijgXp4=
 golang.org/x/crypto v0.41.0/go.mod h1:pO5AFd7FA68rFak7rOAGVuygIISepHftHnr8dr6+sUc=
 golang.org/x/crypto v0.47.0/go.mod h1:ff3Y9VzzKbwSSEzWqJsJVBnWmRwRSHt/6Op5n9bQc4A=
+golang.org/x/crypto v0.49.0/go.mod h1:ErX4dUh2UM+CFYiXZRTcMpEcN8b/1gxEuv3nODoYtCA=
 golang.org/x/mod v0.31.0/go.mod h1:43JraMp9cGx1Rx3AqioxrbrhNsLl2l/iNAvuBkrezpg=
 golang.org/x/mod v0.32.0/go.mod h1:SgipZ/3h2Ci89DlEtEXWUk/HteuRin+HHhN+WbNhguU=
 golang.org/x/net v0.35.0/go.mod h1:EglIi67kWsHKlRzzVMUD93VMSWGFOMSZgxFjparz1Qk=
@@ -25,6 +26,7 @@ golang.org/x/net v0.43.0 h1:lat02VYK2j4aLzMzecihNvTlJNQUq316m2Mr9rnM6YE=
 golang.org/x/net v0.43.0/go.mod h1:vhO1fvI4dGsIjh73sWfUVjj3N7CA9WkKJNQm2svM6Jg=
 golang.org/x/net v0.49.0/go.mod h1:/ysNB2EvaqvesRkuLAyjI1ycPZlQHM3q01F02UY/MV8=
 golang.org/x/net v0.50.0/go.mod h1:UgoSli3F/pBgdJBHCTc+tp3gmrU4XswgGRgtnwWTfyM=
+golang.org/x/net v0.52.0/go.mod h1:R1MAz7uMZxVMualyPXb+VaqGSa3LIaUqk0eEt3w36Sw=
 golang.org/x/sync v0.12.0 h1:MHc5BpPuC30uJk597Ri8TV3CNZcTLu6B6z4lJy+g6Jw=
 golang.org/x/sync v0.12.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
 golang.org/x/sync v0.15.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
@@ -38,7 +40,12 @@ golang.org/x/telemetry v0.0.0-20250807160809-1a19826ec488 h1:3doPGa+Gg4snce233aC
 golang.org/x/telemetry v0.0.0-20250807160809-1a19826ec488/go.mod h1:fGb/2+tgXXjhjHsTNdVEEMZNWA0quBnfrO+AfoDSAKw=
 golang.org/x/telemetry v0.0.0-20260109210033-bd525da824e2/go.mod h1:b7fPSJ0pKZ3ccUh8gnTONJxhn3c/PS6tyzQvyqw4iA8=
 golang.org/x/telemetry v0.0.0-20260209163413-e7419c687ee4/go.mod h1:g5NllXBEermZrmR51cJDQxmJUHUOfRAaNyWBM+R+548=
+golang.org/x/telemetry v0.0.0-20260311193753-579e4da9a98c/go.mod h1:TpUTTEp9frx7rTdLpC9gFG9kdI7zVLFTFFlqaH2Cncw=
 golang.org/x/term v0.32.0/go.mod h1:uZG1FhGx848Sqfsq4/DlJr3xGGsYMu/L5GW4abiaEPQ=
+golang.org/x/term v0.41.0 h1:QCgPso/Q3RTJx2Th4bDLqML4W6iJiaXFq2/ftQF13YU=
+golang.org/x/term v0.41.0/go.mod h1:3pfBgksrReYfZ5lvYM0kSO0LIkAl4Yl2bXOkKP7Ec2A=
+golang.org/x/text v0.35.0 h1:JOVx6vVDFokkpaq1AEptVzLTpDe9KGpj5tR4/X+ybL8=
+golang.org/x/text v0.35.0/go.mod h1:khi/HExzZJ2pGnjenulevKNX1W67CUy0AsXcNubPGCA=
 golang.org/x/tools v0.13.0/go.mod h1:HvlwmtVNQAhOuCjW7xxvovg8wbNq7LwfXh/k7wXUl58=
 golang.org/x/tools v0.40.0/go.mod h1:Ik/tzLRlbscWpqqMRjyWYDisX8bG13FrdXp3o4Sr9lc=
 golang.org/x/tools v0.41.0/go.mod h1:XSY6eDqxVNiYgezAVqqCeihT4j1U2CCsqvH3WhQpnlg=

internal/plugins/jest/all.go

@@ -1,13 +1,15 @@
 package jest
 
 import (
+	"github.com/web-infra-dev/rslint/internal/plugins/jest/rules/no_disabled_tests"
 	"github.com/web-infra-dev/rslint/internal/plugins/jest/rules/no_hooks"
 	"github.com/web-infra-dev/rslint/internal/plugins/jest/rules/valid_describe_callback"
 	"github.com/web-infra-dev/rslint/internal/rule"
 )
 
 func GetAllRules() []rule.Rule {
 	return []rule.Rule{
+		no_disabled_tests.NoDisabledTestsRule,
 		no_hooks.NoHooksRule,
 		valid_describe_callback.ValidDescribeCallbackRule,
 	}

internal/plugins/jest/recommended.go

@@ -1,12 +1,14 @@
 package jest
 
 import (
+	"github.com/web-infra-dev/rslint/internal/plugins/jest/rules/no_disabled_tests"
 	"github.com/web-infra-dev/rslint/internal/plugins/jest/rules/valid_describe_callback"
 	"github.com/web-infra-dev/rslint/internal/rule"
 )
 
 func GetRecommendedRules() []rule.Rule {
 	return []rule.Rule{
+		no_disabled_tests.NoDisabledTestsRule,
 		valid_describe_callback.ValidDescribeCallbackRule,
 	}
 }

internal/plugins/jest/rules/no_disabled_tests/no_disabled_tests.go

@@ -0,0 +1,101 @@
+package no_disabled_tests
+
+import (
+	"slices"
+	"strings"
+
+	"github.com/microsoft/typescript-go/shim/ast"
+	"github.com/web-infra-dev/rslint/internal/plugins/jest/utils"
+	"github.com/web-infra-dev/rslint/internal/rule"
+)
+
+// Message Builder
+
+func buildErrorMissingFunctionMessage() rule.RuleMessage {
+	return rule.RuleMessage{
+		Id:          "missingFunction",
+		Description: "Test is missing function argument",
+	}
+}
+
+func buildErrorSkippedTestMessage() rule.RuleMessage {
+	return rule.RuleMessage{
+		Id:          "skippedTest",
+		Description: "Tests should not be skipped",
+	}
+}
+
+func isPendingCall(node *ast.Node, ctx rule.RuleContext) bool {
+	if node == nil || node.Kind != ast.KindCallExpression {
+		return false
+	}
+
+	callExpr := node.AsCallExpression()
+	if callExpr == nil || callExpr.Expression == nil || callExpr.Expression.Kind != ast.KindIdentifier {
+		return false
+	}
+
+	identifier := callExpr.Expression.AsIdentifier()
+	if identifier == nil || identifier.Text != "pending" {
+		return false
+	}
+
+	if ctx.TypeChecker == nil {
+		return true
+	}
+
+	symbol := ctx.TypeChecker.GetSymbolAtLocation(callExpr.Expression)
+	if symbol == nil {
+		return true
+	}
+
+	for _, decl := range symbol.Declarations {
+		if decl == nil {
+			continue
+		}
+		if decl.Kind != ast.KindImportSpecifier {
+			return false
+		}
+
+		importDecl := utils.FindImportDeclaration(decl)
+		if importDecl == nil || importDecl.ModuleSpecifier == nil {
+			return false
+		}
+
+		return importDecl.ModuleSpecifier.Text() == "@jest/globals"
+	}
+
+	return true
+}
+
+var NoDisabledTestsRule = rule.Rule{
+	Name: "jest/no-disabled-tests",
+	Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
+		return rule.RuleListeners{
+			ast.KindCallExpression: func(node *ast.Node) {
+				if isPendingCall(node, ctx) {
+					ctx.ReportNode(node, buildErrorSkippedTestMessage())
+					return
+				}
+
+				jestFnCall := utils.ParseJestFnCall(node, ctx)
+				if jestFnCall == nil ||
+					jestFnCall.Kind != utils.JestFnTypeDescribe &&
+						jestFnCall.Kind != utils.JestFnTypeTest {
+					return
+				}
+
+				if strings.HasPrefix(jestFnCall.Name, "x") ||
+					slices.Contains(jestFnCall.Members, "skip") {
+					ctx.ReportNode(node, buildErrorSkippedTestMessage())
+				}
+
+				if jestFnCall.Kind == utils.JestFnTypeTest {
+					if len(node.Arguments()) < 2 && !slices.Contains(jestFnCall.Members, "todo") {
+						ctx.ReportNode(node, buildErrorMissingFunctionMessage())
+					}
+				}
+			},
+		}
+	},
+}

internal/plugins/jest/rules/no_disabled_tests/no_disabled_tests.md

@@ -0,0 +1,56 @@
+# jest/no-disabled-tests
+
+## Rule Details
+
+Disallow disabled or incomplete Jest tests. This rule reports skipped suites/tests via `.skip` and `x*` aliases, disallows `pending()` in test bodies, and flags `it()` / `test()` calls that omit the callback function (except `test.todo(...)`). It helps prevent accidentally committing tests that are skipped or not actually executed.
+
+Examples of **incorrect** code for this rule:
+
+```javascript
+describe.skip('foo', () => {});
+it.skip('foo', () => {});
+test.skip('foo', () => {});
+
+describe['skip']('bar', () => {});
+it['skip']('bar', () => {});
+test['skip']('bar', () => {});
+
+xdescribe('foo', () => {});
+xit('foo', () => {});
+xtest('foo', () => {});
+
+it('bar');
+test('bar');
+
+it('foo', () => {
+  pending();
+});
+```
+
+Examples of **correct** code for this rule:
+
+```javascript
+describe('foo', () => {});
+it('foo', () => {});
+test('foo', () => {});
+
+describe.only('bar', () => {});
+it.only('bar', () => {});
+test.only('bar', () => {});
+```
+
+## Limitations
+
+The plugin looks at the literal function names within test code, so will not catch more complex examples of disabled tests, such as:
+
+```javascript
+const testSkip = test.skip;
+testSkip('skipped test', () => {});
+
+const myTest = test;
+myTest('does not have function body');
+```
+
+## Original Documentation
+
+- [jest/no-disabled-tests](https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-disabled-tests.md)