fix: handle cjs export assignment side effects

Author: JSerFeng

crates/rspack_plugin_javascript/src/dependency/commonjs/common_js_exports_dependency.rs

@@ -2,13 +2,14 @@ use rspack_cacheable::{
   cacheable, cacheable_dyn,
   with::{AsPreset, AsVec},
 };
+use rspack_collections::{IdentifierMap, IdentifierSet};
 use rspack_core::{
-  AsContextDependency, AsModuleDependency, Dependency, DependencyCategory,
+  AsContextDependency, AsModuleDependency, ConnectionState, Dependency, DependencyCategory,
   DependencyCodeGeneration, DependencyId, DependencyRange, DependencyTemplate,
   DependencyTemplateType, DependencyType, ExportNameOrSpec, ExportSpec, ExportsInfoArtifact,
   ExportsOfExportsSpec, ExportsSpec, InitFragmentExt, InitFragmentKey, InitFragmentStage,
-  ModuleGraph, ModuleGraphCacheArtifact, NormalInitFragment, TemplateContext,
-  TemplateReplaceSource, UsedName, property_access,
+  ModuleGraph, ModuleGraphCacheArtifact, NormalInitFragment, SideEffectsStateArtifact,
+  TemplateContext, TemplateReplaceSource, UsedName, property_access,
 };
 use swc_atoms::Atom;
 
@@ -123,6 +124,17 @@ impl Dependency for CommonJsExportsDependency {
   fn could_affect_referencing_module(&self) -> rspack_core::AffectType {
     rspack_core::AffectType::False
   }
+
+  fn get_module_evaluation_side_effects_state(
+    &self,
+    _module_graph: &ModuleGraph,
+    _module_graph_cache: &ModuleGraphCacheArtifact,
+    _side_effects_state_artifact: &SideEffectsStateArtifact,
+    _module_chain: &mut IdentifierSet,
+    _connection_state_cache: &mut IdentifierMap<ConnectionState>,
+  ) -> ConnectionState {
+    ConnectionState::Active(false)
+  }
 }
 
 impl AsModuleDependency for CommonJsExportsDependency {}

crates/rspack_plugin_javascript/src/dependency/commonjs/common_js_self_reference_dependency.rs

@@ -2,11 +2,13 @@ use rspack_cacheable::{
   cacheable, cacheable_dyn,
   with::{AsPreset, AsVec},
 };
+use rspack_collections::{IdentifierMap, IdentifierSet};
 use rspack_core::{
-  AsContextDependency, Dependency, DependencyCategory, DependencyCodeGeneration, DependencyId,
-  DependencyRange, DependencyTemplate, DependencyTemplateType, DependencyType, ExportsInfoArtifact,
-  ExtendedReferencedExport, FactorizeInfo, ModuleDependency, ModuleGraph, ModuleGraphCacheArtifact,
-  RuntimeSpec, TemplateContext, TemplateReplaceSource, UsedName, property_access_with_optional,
+  AsContextDependency, ConnectionState, Dependency, DependencyCategory, DependencyCodeGeneration,
+  DependencyId, DependencyRange, DependencyTemplate, DependencyTemplateType, DependencyType,
+  ExportsInfoArtifact, ExtendedReferencedExport, FactorizeInfo, ModuleDependency, ModuleGraph,
+  ModuleGraphCacheArtifact, RuntimeSpec, SideEffectsStateArtifact, TemplateContext,
+  TemplateReplaceSource, UsedName, property_access_with_optional,
 };
 use swc_atoms::Atom;
 
@@ -22,6 +24,7 @@ pub struct CommonJsSelfReferenceDependency {
   names: Vec<Atom>,
   names_optionals: Vec<bool>,
   is_call: bool,
+  evaluation_side_effect_free: bool,
   factorize_info: FactorizeInfo,
 }
 
@@ -32,6 +35,7 @@ impl CommonJsSelfReferenceDependency {
     names: Vec<Atom>,
     names_optionals: Vec<bool>,
     is_call: bool,
+    evaluation_side_effect_free: bool,
   ) -> Self {
     Self {
       id: DependencyId::new(),
@@ -40,6 +44,7 @@ impl CommonJsSelfReferenceDependency {
       names,
       names_optionals,
       is_call,
+      evaluation_side_effect_free,
       factorize_info: Default::default(),
     }
   }
@@ -90,6 +95,17 @@ impl Dependency for CommonJsSelfReferenceDependency {
   fn could_affect_referencing_module(&self) -> rspack_core::AffectType {
     rspack_core::AffectType::True
   }
+
+  fn get_module_evaluation_side_effects_state(
+    &self,
+    _module_graph: &ModuleGraph,
+    _module_graph_cache: &ModuleGraphCacheArtifact,
+    _side_effects_state_artifact: &SideEffectsStateArtifact,
+    _module_chain: &mut IdentifierSet,
+    _connection_state_cache: &mut IdentifierMap<ConnectionState>,
+  ) -> ConnectionState {
+    ConnectionState::Active(!self.evaluation_side_effect_free)
+  }
 }
 
 #[cacheable_dyn]

crates/rspack_plugin_javascript/src/parser_and_generator/mod.rs

@@ -311,6 +311,7 @@ impl ParserAndGenerator for JavaScriptParserAndGenerator {
       presentational_dependencies,
       mut warning_diagnostics,
       mut side_effects_item,
+      module_has_side_effects,
     } = match scan_dependencies(
       &source_string,
       &parsed_ast,
@@ -338,7 +339,7 @@ impl ParserAndGenerator for JavaScriptParserAndGenerator {
     let mut side_effects_bailout = None;
 
     if compiler_options.optimization.side_effects.is_true() {
-      let has_side_effects = side_effects_item.is_some();
+      let has_side_effects = module_has_side_effects;
       build_meta.side_effect_free = Some(!has_side_effects);
       if has_side_effects {
         build_info.deferred_pure_checks.clear();

crates/rspack_plugin_javascript/src/parser_plugin/common_js_exports_parse_plugin.rs

@@ -245,6 +245,7 @@ fn handle_access_export(
     remaining.to_vec(),
     remaining_optionals.to_vec(),
     call_args.is_some(),
+    parser.in_assign_target,
   )));
   if let Some(call_args) = call_args {
     parser.walk_expr_or_spread(call_args);