ci: consolidate static checks in lint workflow (#1430)

Author: 9aoy

.github/workflows/test.yml

@@ -75,19 +75,27 @@ jobs:
 
       - name: Build Packages
         run: pnpm run build
+        env:
+          # Publish checks are comparatively expensive and only need to run once
+          # as part of the lint/static-check gate.
+          RSTEST_PUBLISH_CHECK: true
 
       - name: Lint
         run: pnpm run lint
 
       - name: Check Dependency Version
         run: pnpm run check-dependency-version
 
-      - name: Check pnpm Dedupe
-        run: pnpm dedupe --check --config.minimum-release-age=0
-
       - name: Check Unused Code
         run: pnpm run check-unused
 
+      - name: Check pnpm Dedupe
+        # Keep dedupe last: `pnpm dedupe --check` may leave pnpm's modules
+        # state needing a reconcile. If another `pnpm run ...` follows it,
+        # pnpm can enter its implicit install path and rerun lifecycle scripts
+        # such as the root `prepare`.
+        run: pnpm dedupe --check --config.minimum-release-age=0
+
   # ======== ut ========
   ut:
     # Gate behind lint so a lint failure skips the (billed-premium) macOS +
@@ -129,13 +137,6 @@ jobs:
       - name: Setup Playwright
         uses: ./.github/actions/setup-playwright
 
-      - name: Run Type Check
-        # tsc is OS-independent, so PR runs it on macOS only; the post-merge
-        # FULL run still typechecks both OSes so push-to-main stays a literal
-        # superset of PR coverage.
-        if: needs.prepare.outputs.is_full_run == 'true' || matrix.os == 'macos-latest'
-        run: pnpm run typecheck
-
       - name: Run Test
         run: pnpm run test
 

package.json

@@ -11,13 +11,13 @@
     "check-unused": "knip",
     "e2e": "cd e2e && pnpm test && pnpm test:commonjs && pnpm test:no-isolate",
     "format": "prettier --write . && heading-case --write",
-    "lint": "prettier --check . && pnpm run check-spell && pnpm lint:type",
-    "lint:type": "rslint",
+    "lint": "prettier --check . && pnpm run check-spell && pnpm run lint:type",
+    "lint:type": "rslint --type-check",
     "prepare": "lefthook install && pnpm run build",
     "test": "rstest",
     "test:examples": "pnpm --filter \"@examples/*\" test",
     "test:vscode": "pnpm --filter ./packages/vscode test",
-    "typecheck": "rslint --type-check-only"
+    "typecheck": "pnpm run lint:type"
   },
   "devDependencies": {
     "@rsdoctor/rspack-plugin": "^1.5.13",

scripts/publishCheckPlugins.ts

@@ -12,6 +12,10 @@ import { pluginPublint } from 'rsbuild-plugin-publint';
  * needing dynamic import are intentional, not bugs.
  */
 export function publishCheckPlugins() {
+  if (process.env.RSTEST_PUBLISH_CHECK !== 'true') {
+    return [];
+  }
+
   return [
     pluginPublint(),
     pluginAreTheTypesWrong({