From 41270753e168d83bbbf4fe8533afb8e27f291c8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Wed, 6 Jul 2022 09:45:24 +0200 Subject: [PATCH 1/2] RFC 117: Remove dated tags for epoch branches --- rfcs/epochs_tags.md | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 rfcs/epochs_tags.md diff --git a/rfcs/epochs_tags.md b/rfcs/epochs_tags.md new file mode 100644 index 00000000..50fa42e7 --- /dev/null +++ b/rfcs/epochs_tags.md @@ -0,0 +1,29 @@ +# RFC 117: Remove dated tags for epoch branches + +## Summary + +Stop creating periodic tags for the `epochs/*` branches, such as +`epochs/daily/2022-06-30_02H` created for `epochs/daily`. Also remove all such +tags created so far. + +## Details + +[wpt#26122](https://github.com/web-platform-tests/wpt/pull/26122) introduced +these tags in order to help identify which commit had triggered CI runs in the +past. However, the `./wpt rev-list` command already supports listing those +commits. This will be documented. + +## Risks + +The `./wpt rev-list` depends on the `merge_pr_*` tags, but the CI job that +creates them is not 100% reliable, see +[wpt#23426](https://github.com/web-platform-tests/wpt/issues/23426). If the tags +are missing but later backfilled, what `./wpt rev-list` lists can change, so +that the commits listed aren't the ones that were pushed to `epochs/*` branches. +In 2020 ~1-3% of tags were missing, and it continues to happen at least a few +times a year. No mitigiation is suggested since backfilling tags is only done +manually and rarely. + +Since these tags have been created since October 2020 there is a risk that +someone has grown a dependency on them in their workflow. This RFC is mainly to +make the change visible to uncover such uses. From d331c9768cc3d94b7a726a3122f60b320497c5f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Wed, 6 Jul 2022 12:22:34 +0200 Subject: [PATCH 2/2] Update epochs_tags.md --- rfcs/epochs_tags.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rfcs/epochs_tags.md b/rfcs/epochs_tags.md index 50fa42e7..2e4925fe 100644 --- a/rfcs/epochs_tags.md +++ b/rfcs/epochs_tags.md @@ -15,8 +15,8 @@ commits. This will be documented. ## Risks -The `./wpt rev-list` depends on the `merge_pr_*` tags, but the CI job that -creates them is not 100% reliable, see +The `./wpt rev-list` command depends on the `merge_pr_*` tags, but the CI job +that creates them is not 100% reliable, see [wpt#23426](https://github.com/web-platform-tests/wpt/issues/23426). If the tags are missing but later backfilled, what `./wpt rev-list` lists can change, so that the commits listed aren't the ones that were pushed to `epochs/*` branches.