Skip to content

Commit 04f09ed

Browse files
janvargamoz-wptsync-bot
authored andcommitted
Fix computed value testing for offset-rotate keywords
The default keyword testing does not handle the special computed values of offset-rotate correctly. For example, "reverse" computes to "auto 180deg", while "auto" may be exposed as either "auto" or "auto 0deg" depending on the engine. Add custom computed value checks for these keyword cases so the tests match the property-specific computed value behavior. Differential Revision: https://phabricator.services.mozilla.com/D298938 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2037446 gecko-commit: f3c574159a013e064289c870860bfb67ad0178ba gecko-commit-git: 58dc4f5be7b75198c23a35d5423c5df1bb5567cf gecko-reviewers: emilio, firefox-style-system-reviewers
1 parent bf64191 commit 04f09ed

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

css/css-typed-om/the-stylepropertymap/properties/offset-rotate.html

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,20 @@
1313
'use strict';
1414

1515
runPropertyTests('offset-rotate', [
16-
{ syntax: 'auto' },
17-
{ syntax: 'reverse' },
16+
{
17+
syntax: 'auto',
18+
computed: (input, result) => {
19+
try {
20+
assert_is_unsupported(result);
21+
} catch(e) {
22+
assert_style_value_equals(result, input);
23+
}
24+
}
25+
},
26+
{
27+
syntax: 'reverse',
28+
computed: (_, result) => assert_is_unsupported(result)
29+
},
1830
{
1931
syntax: '<angle>',
2032
specified: (input, result, alternateExpected) => {

0 commit comments

Comments
 (0)