From 1691e2c6a184e2eff0a5c29b22b82aaa01840f9f Mon Sep 17 00:00:00 2001 From: Blink WPT Bot Date: Thu, 16 Sep 2021 09:19:03 -0700 Subject: [PATCH] [Re-Factor Client Hints] (5) Remove (unlaunched) `lang` client hint (#30781) Now that we've cleaned up the array indexing that was blocking this, let's move forward with removing this unused client hint. This is a part of a series of CLs to re-factor the client hints code: (1) Label hints with legacy names (2) Fix the naming of (unlaunched) `lang` client hint (3) Consolidate client hint name lists (4) Migrate from array to map indexing for client hint names (5) Remove (unlaunched) `lang` client hint Bug: 1227043 Change-Id: I57404516cd1f39f738f0fbd7c202de7adf063d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160286 Auto-Submit: Ari Chivukula Commit-Queue: Matt Falkenhagen Reviewed-by: Matt Falkenhagen Reviewed-by: David Dorwin Reviewed-by: Yoav Weiss Reviewed-by: Dominick Ng Cr-Commit-Position: refs/heads/main@{#921893} Co-authored-by: Ari Chivukula --- client-hints/accept-ch-cache-revalidation.https.html | 1 - client-hints/http-equiv-accept-ch-merge.https.html | 3 +-- client-hints/resources/echo-client-hints-received.py | 2 -- client-hints/resources/stale-echo-client-hints.py | 1 - 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/client-hints/accept-ch-cache-revalidation.https.html b/client-hints/accept-ch-cache-revalidation.https.html index 217a490ba5c8fc..60c61603b39564 100644 --- a/client-hints/accept-ch-cache-revalidation.https.html +++ b/client-hints/accept-ch-cache-revalidation.https.html @@ -23,7 +23,6 @@ "rtt", "downlink", "ect", - "lang", "sec-ch-ua", "sec-ch-ua-arch", "sec-ch-ua-platform", diff --git a/client-hints/http-equiv-accept-ch-merge.https.html b/client-hints/http-equiv-accept-ch-merge.https.html index 4ed2291de2999d..940554b9286924 100644 --- a/client-hints/http-equiv-accept-ch-merge.https.html +++ b/client-hints/http-equiv-accept-ch-merge.https.html @@ -1,7 +1,7 @@ - + @@ -19,7 +19,6 @@ // Verify that the browser includes client hints in the headers. assert_true(r.headers.has("device-memory-received"), "device-memory-received"); assert_true(r.headers.has("dpr-received"), "dpr-received"); - assert_true(r.headers.has("lang-received"), "lang-received"); assert_true(r.headers.has("viewport-width-received"), "viewport-width-received"); assert_true(r.headers.has("rtt-received"), "rtt-received"); diff --git a/client-hints/resources/echo-client-hints-received.py b/client-hints/resources/echo-client-hints-received.py index 798e380237d369..0aa4faeed932ed 100644 --- a/client-hints/resources/echo-client-hints-received.py +++ b/client-hints/resources/echo-client-hints-received.py @@ -22,8 +22,6 @@ def main(request, response): response.headers.set(b"downlink-received", request.headers.get(b"downlink")) if b"ect" in request.headers: response.headers.set(b"ect-received", request.headers.get(b"ect")) - if b"Lang" in request.headers: - response.headers.set(b"lang-received", request.headers.get(b"Lang")) if b"sec-ch-ua-mobile" in request.headers: response.headers.set(b"mobile-received", request.headers.get(b"sec-ch-ua-mobile")) if b"sec-ch-prefers-color-scheme" in request.headers: diff --git a/client-hints/resources/stale-echo-client-hints.py b/client-hints/resources/stale-echo-client-hints.py index a9caae80ccc86a..f4d2fb2647305c 100644 --- a/client-hints/resources/stale-echo-client-hints.py +++ b/client-hints/resources/stale-echo-client-hints.py @@ -16,7 +16,6 @@ def main(request, response): b"rtt", b"downlink", b"ect", - b"lang", b"sec-ch-ua", b"sec-ch-ua-arch", b"sec-ch-ua-platform",