Skip to content

Commit 1c3cc2e

Browse files
Javier Contreraschromium-wpt-export-bot
authored andcommitted
[gap-decorations] Address remaining flex test failures
One test failure was actually a incorrect reference file, we already had the correct behavior, which is that a column rule in a column flex box stretches until the end of the fragment/container. The other was a genuine bug, in flex fragmentation we were using the item offsets rather than the line offsets for the `line_cross_end`. While this works for most cases, cases with `align-items` introduce discrepancies between the item offsets and the line offsets. Moreover, the ref file was also incorrect. Bug: 440123087 Change-Id: I5cc0670ea82736acf35aa31f8d421197bf638420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7804568 Commit-Queue: Javier Contreras <javiercon@microsoft.com> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1623263}
1 parent ddfef57 commit 1c3cc2e

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-005-ref.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,12 @@
3939
}
4040
</style>
4141

42+
<div style="left: 175px; height: 10px; width: 110px; position: absolute; background-color: gold; top: 5px"></div>
4243

4344
<div class="column-rule" style="left: 52px; height: 45px; top: 2px"></div>
4445
<div class="column-rule" style="left: 225px;"></div>
4546
<div class="column-rule" style="left: 398px; height: 18px;"></div>
4647

47-
<div style="left: 175px; height: 10px; width: 110px; position: absolute; background-color: gold; top: 5px"></div>
48-
4948
<div class="multi-column">
5049
<div id="flexbox">
5150
<div class="items">One</div>

css/css-gaps/flex/fragmentation/flex-gap-decorations-fragmentation-006-ref.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@
4747
}
4848
</style>
4949

50-
<div class="column-rule" style="top: 2px; left: 47px;"></div>
51-
<div class="column-rule" style="top: 0px; left: 220px;"></div>
50+
<div class="row-rule" style="left: 2px; top: 42px"></div>
51+
<div class="row-rule" style="left: 175px; top: 30px"></div>
5252

53-
<div class="row-rule" style="left: 7px; top: 42px"></div>
54-
<div class="row-rule" style="left: 180px; top: 30px"></div>
53+
<div class="column-rule" style="top: 2px; left: 42px;"></div>
54+
<div class="column-rule" style="top: 0px; left: 215px;"></div>
5555

5656
<div class="multi-column">
5757
<div id="flexbox">

0 commit comments

Comments
 (0)