Commit 1c3cc2e
[gap-decorations] Address remaining flex test failures
One test failure was actually a incorrect reference file, we already had
the correct behavior, which is that a column rule in a column flex box
stretches until the end of the fragment/container.
The other was a genuine bug, in flex fragmentation we were using the
item offsets rather than the line offsets for the `line_cross_end`.
While this works for most cases, cases with `align-items` introduce
discrepancies between the item offsets and the line offsets. Moreover,
the ref file was also incorrect.
Bug: 440123087
Change-Id: I5cc0670ea82736acf35aa31f8d421197bf638420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7804568
Commit-Queue: Javier Contreras <javiercon@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1623263}1 parent ddfef57 commit 1c3cc2e
2 files changed
Lines changed: 5 additions & 6 deletions
File tree
- css/css-gaps/flex/fragmentation
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
47 | | - | |
48 | | - | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
| |||
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
| 50 | + | |
| 51 | + | |
52 | 52 | | |
53 | | - | |
54 | | - | |
| 53 | + | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
0 commit comments