Remove broken NoCorsSubresourceCookiesFromFrame helper (#50613)

If a request's mode is no-cors, then the response is opaque to
JavaScript. This helper relies on reading the response via the
`Response.text()` method, so it can't return anything except the empty
string.

Change-Id: I77828ab229d3175f607a4ed62a9e4895fc9f7185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6243093
Commit-Queue: Dylan Cutler <[email protected]>
Auto-Submit: Chris Fredrickson <[email protected]>
Reviewed-by: Dylan Cutler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1418242}

Co-authored-by: Chris Fredrickson <[email protected]>

Author: chromium-wpt-export-bot

storage-access-api/helpers.js

@@ -277,21 +277,14 @@ function FetchFromFrame(frame, url) {
     { command: "cors fetch", url }, frame.contentWindow);
 }
 
-// Makes a subresource request to the provided host in the given frame with
-// the mode set to 'no-cors'
+// Makes a subresource request to the provided host in the given frame with the
+// mode set to 'no-cors'. Returns a promise that resolves with undefined, since
+// no-cors responses are opaque to JavaScript.
 function NoCorsFetchFromFrame(frame, url) {
   return PostMessageAndAwaitReply(
     { command: "no-cors fetch", url }, frame.contentWindow);
 }
 
-// Makes a subresource request to the provided host in the given frame with
-// the mode set to 'no-cors', and returns the cookies that were included in the
-// request.
-function NoCorsSubresourceCookiesFromFrame(frame, host) {
-  const url = `${host}/storage-access-api/resources/echo-cookie-header.py`;
-  return NoCorsFetchFromFrame(frame, url);
-}
-
 // Tries to set storage access policy, ignoring any errors.
 //
 // Note: to discourage the writing of tests that assume unpartitioned cookie

storage-access-api/requestStorageAccess-cross-site-sibling-iframes.sub.https.window.js

@@ -76,7 +76,6 @@
 
     assert_false(cookieStringHasCookie("foo", "bar",  await FetchSubresourceCookiesFromFrame(crossOriginFrame, wwwAlt)), "crossOriginFrame making cross-site subresource request to sibling iframe's host should not include cookies.");
 
-    assert_false(cookieStringHasCookie("foo", "bar", await NoCorsSubresourceCookiesFromFrame(crossOriginFrame, www)), "crossSiteFrame making no-cors cross-site subresource request to sibling iframe's host should not include cookies.");
     assert_false(cookieStringHasCookie("cookie", "monster", await FetchSubresourceCookiesFromFrame(crossSiteFrame, www)),"crossSiteFrame making cross-site subresource request to sibling iframe's host should not include cookies.");
 
   }, "Cross-site sibling iframes should not be able to take advantage of the existing permission grant requested by others.");

storage-access-api/resources/embedded_responder.js

@@ -82,9 +82,12 @@ window.addEventListener("message", async (event) => {
     case "cors fetch":
       reply(await fetch(event.data.url, {mode: 'cors', credentials: 'include'}).then((resp) => resp.text()));
       break;
-    case "no-cors fetch":
-      reply(await fetch(event.data.url, {mode: 'no-cors', credentials: 'include'}).then((resp) => resp.text()));
+    case "no-cors fetch": {
+      const resp = await fetch(event.data.url, {mode: 'no-cors', credentials: 'include'});
+      await resp.text();
+      reply(undefined);
       break;
+    }
     case "start_dedicated_worker":
       worker = new Worker("embedded_worker.py");
       reply(undefined);