Skip to content

Commit 35d6194

Browse files
bfgeekchromium-wpt-export-bot
bfgeek
authored and
chromium-wpt-export-bot
committed
[webkit-box] Ensure that display:-webkit-box blockifies its children.
There should be minimal behaviour differences between display:flex and display:-webkit-box. Previously we didn't blockify our children for -webkit-box. This meant that we could have "inline-level" anonymous tables sitting within the tree. This patch blockifies all children similar to flex. Adds a WPT compat test for this. This doesn't affect -webkit-line-clamp boxes as their computed value for display is coerced to "flow-root" This allows us to make LayoutBlock::AddChildBeforeDescendant have the exact same structure as LayoutTable, LayoutTableSection, LayoutTableRow AddChildBeforeDescendant. (new_child->IsInline() may be able to be converted to new_child->IsText() at a later stage). Change-Id: I2e2a141f9477602a60b463998080e10a196dcde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7836695 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1629284}
1 parent b15dab0 commit 35d6194

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎compat/webkit-box-blockify.html‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<!DOCTYPE html>
2+
<link rel="help" href="https://compat.spec.whatwg.org/#valdef-flex--webkit-box">
3+
<link rel="match" href="green-ref.html">
4+
<div style="display: -webkit-box; width: 100px; height: 100px;">
5+
<span style="background: green; color: transparent; -webkit-box-flex: 1;">content</span>
6+
</div>

0 commit comments

Comments
 (0)