[FedCM] Adding mark_signed_in to fedcm_test

Adding mark_signed_in to the beginning of fedcm_test ensures that user
is in a signed in state for each test. Tests calling mark_signed_out but
never sign back in cause flakiness in repeated test runs. This change
fixes that.

Bug: 41482163
Change-Id: Ib533bba63e73f59da32ce597f6a690873d0cf884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6804547
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1495722}

Author: Survey845

fedcm/fedcm-accounts-endpoint-rejects-redirects.https.html

@@ -10,12 +10,9 @@
 import {request_options_with_mediation_required,
         fedcm_test,
         select_manifest,
-        mark_signed_in,
         fedcm_get_dialog_type_promise} from './support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in();
-
   let test_options = request_options_with_mediation_required("manifest_redirect_accounts.json");
   await select_manifest(t, test_options);
 

fedcm/fedcm-auto-reauthn-without-approved-clients.https.html

@@ -9,12 +9,10 @@
 <script type="module">
 import {request_options_with_mediation_optional,
         fedcm_test,
-        mark_signed_in,
         select_manifest,
         fedcm_get_and_select_first_account} from './support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in();
   let test_options = request_options_with_mediation_optional(
       "manifest_with_single_account.json");
   test_options.identity.providers[0].clientId = 'nomatch';

fedcm/fedcm-disconnect-errors.https.html

@@ -10,17 +10,13 @@
 
 <script type="module">
 import {fedcm_test,
-        mark_signed_in,
-        set_fedcm_cookie,
         fedcm_get_and_select_first_account,
         manifest_origin,
         request_options_with_mediation_required,
         select_manifest,
         disconnect_options} from './support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in();
-  await set_fedcm_cookie();
   // Get at least one connected account that can be disconnected.
   const cred = await fedcm_get_and_select_first_account(t,
       request_options_with_mediation_required());
@@ -41,8 +37,6 @@
 }, "disconnect requires 3 parameters: configURL, clientId, and accountHint");
 
 fedcm_test(async t => {
-  await mark_signed_in();
-  await set_fedcm_cookie();
   // Get at least one connected account that can be disconnected.
   const cred = await fedcm_get_and_select_first_account(t,
       request_options_with_mediation_required());
@@ -55,8 +49,6 @@
 to the config file");
 
 fedcm_test(async t => {
-  await mark_signed_in();
-  await set_fedcm_cookie();
   // Get at least one connected account that can be disconnected.
   const cred = await fedcm_get_and_select_first_account(t,
       request_options_with_mediation_required());

fedcm/fedcm-disconnect.sub.https.html

@@ -11,7 +11,6 @@
 
 <script type="module">
 import {fedcm_test,
-        mark_signed_in,
         disconnect_options,
         fedcm_get_and_select_first_account,
         fedcm_select_account_promise,
@@ -22,7 +21,6 @@
         set_alt_fedcm_cookie} from './support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in(alt_manifest_origin);
   // Get at least one connected account that can be disconnected.
   const cred = await fedcm_get_and_select_first_account(t, alt_request_options_with_mediation_required());
   // The IDP implementation will accept any account hint, so this is really testing that the user
@@ -48,14 +46,12 @@
 }, 'Test that disconnect fails when there is no account to disconnect');
 
 fedcm_test(async t => {
-  await mark_signed_in(alt_manifest_origin);
   const cred = await fedcm_get_and_select_first_account(t, alt_request_options_with_mediation_required());
 
   return IdentityCredential.disconnect(alt_disconnect_options("1234"));
 }, 'Test that disconnect succeeds when there is an account to disconnect');
 
 fedcm_test(async t => {
-  await mark_signed_in(alt_manifest_origin);
   const cred = await fedcm_get_and_select_first_account(t, alt_request_options_with_mediation_required());
 
   await IdentityCredential.disconnect(alt_disconnect_options("1234"));
@@ -65,16 +61,13 @@
 }, 'Test that disconnecting the same account twice results in failure.');
 
 fedcm_test(async t => {
-  await mark_signed_in(alt_manifest_origin);
   const cred = await fedcm_get_and_select_first_account(t, alt_request_options_with_mediation_required());
   // A connected account is guaranteed by the above, and IDP accepts any account hint, so this tests
   // that the user agent allows the request to go through to the IDP.
   return IdentityCredential.disconnect(alt_disconnect_options("noMatch"));
 }, 'Disconnect passing an incorrect ID can still succeed');
 
 fedcm_test(async t => {
-  await mark_signed_in();
-  await mark_signed_in(alt_manifest_origin);
   await fedcm_get_and_select_first_account(t, alt_request_options_with_mediation_required());
   await fedcm_get_and_select_first_account(t,
       request_options_with_mediation_required());
@@ -86,7 +79,6 @@
 }, 'Disconnect is bound to each IDP');
 
 fedcm_test(async t => {
-  await mark_signed_in(alt_manifest_origin);
   // Get at least one connected account that can be disconnected.
   await fedcm_get_and_select_first_account(t, alt_request_options_with_mediation_required());
 

fedcm/fedcm-identity-assertion-nocors.https.html

@@ -10,12 +10,10 @@
 import {alt_request_options_with_mediation_required,
         fedcm_test,
         select_manifest,
-        mark_signed_in,
         fedcm_error_dialog_dismiss,
         fedcm_select_account_promise} from './support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in();
   let test_options = alt_request_options_with_mediation_required("manifest-token-nocors.json");
   await select_manifest(t, test_options);
   try {

fedcm/fedcm-login-status-unknown.https.html

@@ -10,12 +10,9 @@
 import {request_options_with_mediation_required,
         fedcm_test,
         fedcm_get_dialog_type_promise,
-        select_manifest,
-        mark_signed_in} from '../support/fedcm-helper.sub.js';
+        select_manifest} from '../support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in();
-
   let test_options = request_options_with_mediation_required("manifest_with_variable_accounts.json");
   await select_manifest(t, test_options);
 

fedcm/fedcm-login-status/confirm-idp-login.https.html

@@ -10,12 +10,9 @@
 import {request_options_with_mediation_required,
         fedcm_test,
         fedcm_get_dialog_type_promise,
-        select_manifest,
-        mark_signed_in} from '../support/fedcm-helper.sub.js';
+        select_manifest} from '../support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in();
-
   let test_options = request_options_with_mediation_required("manifest_broken_login.json");
   await select_manifest(t, test_options);
 

fedcm/fedcm-login-status/login-page-broken.https.html

@@ -11,13 +11,10 @@
 import {fedcm_test,
         request_options_with_login_hint,
         select_manifest,
-        mark_signed_in,
         fedcm_get_dialog_type_promise,
         fedcm_get_and_select_first_account} from './support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in();
-
   let options = request_options_with_login_hint('manifest.py', 'nomatch');
   const cred = navigator.credentials.get(options);
   // We expect a mismatch dialog.

fedcm/fedcm-loginhint.https.html

@@ -11,14 +11,11 @@
 import {
   fedcm_test,
   request_options_with_domain_hint,
-  mark_signed_in,
   fedcm_get_dialog_type_promise,
   fedcm_expect_dialog,
 } from './support/fedcm-helper.sub.js';
 
 fedcm_test(async t => {
-  await mark_signed_in();
-
   let options = request_options_with_domain_hint('manifest.py',
     'nomatch');
   const cred = navigator.credentials.get(options);