Skip to content

Commit 4219c86

Browse files
committed
Add variant: exclude PerformanceEventTiming.targetSelector
Test variants which exclude a specific attribute were added to: - event-timing/idlharness.any.js - event-timing/idlharness.window.js In order for this change to work, a change to resources/idlharness.js was made so that idl attribute tests are now named by their full description: previously, the test for PerformanceEventTiming.targetSelector was simply named PerformanceEventTiming, lumping it together with all other attributes. Now the test is named "PerformanceEventTiming interface: attribute targetSelector", allowing it to be excluded by the regex "PerformanceEventTiming.*targetSelector".
1 parent fd3fcf8 commit 4219c86

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

event-timing/idlharness.any.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1+
// META: variant=?exclude=PerformanceEventTiming.*targetSelector
2+
// META: variant=?include=PerformanceEventTiming.*targetSelector
13
// META: global=window,worker
4+
// META: script=/common/subset-tests-by-key.js
25
// META: script=/resources/WebIDLParser.js
36
// META: script=/resources/idlharness.js
47

event-timing/idlharness.window.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1+
// META: variant=?exclude=PerformanceEventTiming.*targetSelector
2+
// META: variant=?include=PerformanceEventTiming.*targetSelector
13
// META: global=window
4+
// META: script=/common/subset-tests-by-key.js
25
// META: script=/resources/WebIDLParser.js
36
// META: script=/resources/idlharness.js
47

resources/idlharness.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2163,7 +2163,7 @@ IdlInterface.prototype.test_member_const = function(member)
21632163

21642164
IdlInterface.prototype.test_member_attribute = function(member)
21652165
{
2166-
if (!shouldRunSubTest(this.name)) {
2166+
if (!shouldRunSubTest(this.name + " interface: attribute " + member.name)) {
21672167
return;
21682168
}
21692169
var a_test = subsetTestByKey(this.name, async_test, this.name + " interface: attribute " + member.name);
@@ -2256,7 +2256,7 @@ IdlInterface.prototype.test_member_attribute = function(member)
22562256

22572257
IdlInterface.prototype.test_member_operation = function(member)
22582258
{
2259-
if (!shouldRunSubTest(this.name)) {
2259+
if (!shouldRunSubTest(this.name + " interface: operation " + member)) {
22602260
return;
22612261
}
22622262
var a_test = subsetTestByKey(this.name, async_test, this.name + " interface: operation " + member);
@@ -3351,7 +3351,7 @@ IdlNamespace.prototype.do_member_operation_asserts = function (memberHolderObjec
33513351

33523352
IdlNamespace.prototype.test_member_operation = function(member)
33533353
{
3354-
if (!shouldRunSubTest(this.name)) {
3354+
if (!shouldRunSubTest(this.name + ' namespace: operation ' + member)) {
33553355
return;
33563356
}
33573357
var a_test = subsetTestByKey(
@@ -3370,7 +3370,7 @@ IdlNamespace.prototype.test_member_operation = function(member)
33703370

33713371
IdlNamespace.prototype.test_member_attribute = function (member)
33723372
{
3373-
if (!shouldRunSubTest(this.name)) {
3373+
if (!shouldRunSubTest(this.name + ' namespace: attribute ' + member.name)) {
33743374
return;
33753375
}
33763376
var a_test = subsetTestByKey(

0 commit comments

Comments
 (0)