Skip to content

Commit 556a203

Browse files
mfreed7chromium-wpt-export-bot
authored andcommitted
Update UA stylesheet for ::interest-button
This updates the UA stylesheet for the ::interest-button pseudo element to match the proposal on the issue: - w3c/csswg-drafts#12437 Bug: 453705247 Change-Id: I92fbcd047e1f7cdd011800f3e0514548d747adcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7793652 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1621336}
1 parent 604369f commit 556a203

4 files changed

Lines changed: 36 additions & 35 deletions

html/semantics/interestfor/interestfor-keyboard-invalidation.tentative.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@
3535
[interestfor] {
3636
interest-delay: 0s;
3737
}
38+
[interestfor]::interest-button {
39+
display: none;
40+
}
3841
#target {
3942
inset:auto;
4043
top:50px;

html/semantics/interestfor/interestfor-plain-inline-element.tentative.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,20 @@
1717
border: none;
1818
padding: 0;
1919
}
20+
[interestfor] {
21+
interest-delay: 0s;
22+
}
23+
[interestfor]::interest-button {
24+
display: none;
25+
}
2026
</style>
2127
<script src="/resources/testdriver.js"></script>
2228
<script src="/resources/testdriver-actions.js"></script>
2329
<script src="/resources/testdriver-vendor.js"></script>
2430
<script src="resources/invoker-utils.js"></script>
2531
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
2632
<div id="container" style="font:20px/1 Ahem; width:100px; height:100px; color:green; background:red;">
27-
<a id="anchor" href="#" interestfor="doohickey" style="interest-delay:0s;">x</a>xxxx
33+
<a id="anchor" href="#" interestfor="doohickey">x</a>xxxx
2834
</div>
2935
<div popover="hint" id="doohickey">
3036
<div style="margin-left:-20px; width:100px; height:80px; background:green;"></div>

html/semantics/interestfor/interestfor-pseudo-element-appearance-ref.html

Lines changed: 24 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3,63 +3,58 @@
33
<link rel="author" href="mailto:masonf@chromium.org">
44

55
<div class=example>
6-
<button class=invoker><span class=before>::before</span><span>Button</span><span class=after>::after</span></button>
7-
<button class=interestbutton>::interest-button</button>
6+
<button class=invoker>
7+
<span class=before>::before</span><span class=content>Button</span><span class=interestbutton>::interest-button</span><span class=after>::after</span></button>
88
</div>
99
<div class=example>
10-
<a href=# class=invoker><span class=before>::before</span><span>Link</span><button class=interestbutton>::interest-button</button><span class=after>::after</span></a>
10+
<a href=# class=invoker><span class=before>::before</span><span class=content>Link</span><span class=interestbutton>::interest-button</span><span class=after>::after</span></a>
1111
</div>
1212
<div class=example>
1313
<img src="/images/blue.png" usemap="#map1" width=40 height=40>
14-
<span class=before>::before</span><map id="map1"><area href="/" shape="default" class=invoker></map><button class=interestbutton>::interest-button</button><span class=after>::after</span>
14+
<span class=before>::before</span><map id="map1"><area href="/" shape="default" class=invoker></map><span class=interestbutton>::interest-button</span><span class=after>::after</span>
1515
</div>
1616

1717
<div id=target></div>
1818

1919
<style>
2020
.before {
2121
content: "::before";
22-
border: 1px solid green;
22+
border: 1px solid lime;
2323
}
2424
/* UA stylesheet for ::interest-button: */
2525
.interestbutton {
26-
user-select: none;
27-
color: buttontext;
2826
display: inline-block;
27+
box-sizing: border-box;
28+
border: 1px solid currentColor;
29+
border-radius: 0.5em;
30+
color: inherit;
31+
background-color: transparent;
32+
padding-block: 0.25em;
33+
padding-inline: 0.5em;
34+
min-block-size: max(24px, 1lh);
35+
min-inline-size: 24px;
2936
text-align: center;
30-
cursor: default;
31-
background-color: buttonface;
3237
margin-inline-start: 0.5em;
33-
padding-block: 1px;
34-
padding-inline: 6px;
35-
border-width: 1px;
36-
border-radius: 5px;
37-
border-style: outset;
38-
border-color: buttonborder;
38+
user-select: none;
39+
}
40+
41+
.interestbutton:hover {
42+
background-color: color-mix(in lab, currentColor 10%, transparent);
43+
}
44+
.interestbutton:active {
45+
background-color: color-mix(in lab, currentColor 20%, transparent);
3946
}
4047
.after {
4148
content: "::after";
42-
border: 1px solid green;
49+
border: 1px solid lime;
4350
}
4451
/* Test convenience: */
4552
.example {
46-
display:block;
4753
width: 400px;
4854
height: 50px;
4955
}
50-
.invoker>span {
56+
.content {
5157
border: 1px solid black;
5258
}
53-
.interestbutton {
54-
font-family: arial;
55-
font-size: 13px;
56-
}
5759
</style>
5860

59-
<script>
60-
// Fix up parser moving out the button
61-
const interestButton = document.querySelector('button.invoker');
62-
const movedButton = document.querySelector('button.invoker + button.interestbutton');
63-
const afterSpan = interestButton.querySelector('.after');
64-
interestButton.insertBefore(movedButton, afterSpan);
65-
</script>

html/semantics/interestfor/interestfor-pseudo-element-appearance.tentative.html

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,17 @@
2020
<style>
2121
[interestfor]::before {
2222
content: "::before";
23-
border: 1px solid green;
23+
border: 1px solid lime;
2424
}
2525
[interestfor]::interest-button {
2626
content: "::interest-button";
27-
font-family: arial;
28-
font-size: 13px;
2927
}
3028
[interestfor]::after {
3129
content: "::after";
32-
border: 1px solid green;
30+
border: 1px solid lime;
3331
}
3432
/* Test convenience: */
3533
.example {
36-
display:block;
3734
width: 400px;
3835
height: 50px;
3936
}

0 commit comments

Comments
 (0)