Commit 5670df7
Fix 3d transform check in HasDistortingVisualEffects
https://crrev.com/1629048 relies on `HasDistortingVisualEffects`
catching all cases where the target has a 3d transform. Unfortunately,
this was not the case because
`GeometryMapper::SourceToDestinationProjection` will flatten 3d
transforms, so the following check is insufficient:
```
gfx::Transform projection = SourceToDestinationProjection(
paint_properties.Transform(), root_properties.Transform());
if (!projection.Is2dProportionalUpscaleAndOr2dTranslation())
return true;
```
This patch fixes this issue by ensuring that the target and the root
are coplanar before relying on the projection.
Fixed: 517176673
Change-Id: Ia03596324a88252c054f0963f7aa08b60d1a5497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7877217
Reviewed-by: Stefan Zager <szager@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637326}1 parent 1038655 commit 5670df7
1 file changed
Lines changed: 45 additions & 0 deletions
Lines changed: 45 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
0 commit comments