Skip to content

Commit 61aa60a

Browse files
Javier Contreras Tenorio (from Dev Box)chromium-wpt-export-bot
Javier Contreras Tenorio (from Dev Box)
authored andcommitted
[gap-decorations] Parse row-rule-style property
This CL introduces parsing for the `row-rule-style` property which sets the styles of gap decorations in rows see: https://drafts.csswg.org/css-gaps-1/#column-row-rule-style Bug: 357648037 Change-Id: Idcf7575a720812cf5dec7221b09adc82f1ec43f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6283305 Reviewed-by: Sam Davis Omekara <[email protected]> Reviewed-by: Alison Maher <[email protected]> Commit-Queue: Javier Contreras <[email protected]> Reviewed-by: Kevin Babbitt <[email protected]> Cr-Commit-Position: refs/heads/main@{#1423236}
1 parent ef74bdd commit 61aa60a

File tree

3 files changed

+45
-3
lines changed

3 files changed

+45
-3
lines changed

css/css-gaps/tentative/parsing/gap-decorations-style-computed.html

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<title>CSS Gap Decoration: column-rule-style getComputedStyle()</title>
66
<link rel="help" href="https://drafts.csswg.org/css-gaps-1/#column-row-rule-style">
77
<link rel="author" title="Sam Davis Omekara Jr." href="mailto:[email protected]">
8-
<meta name="assert" content="column-rule-style computed value is as specified.">
8+
<meta name="assert" content="*-rule-style computed value is as specified.">
99
<script src="/resources/testharness.js"></script>
1010
<script src="/resources/testharnessreport.js"></script>
1111
<script src="/css/support/computed-testcommon.js"></script>
@@ -22,6 +22,15 @@
2222
test_computed_value("column-rule-style", "groove");
2323
test_computed_value("column-rule-style", "ridge");
2424
test_computed_value("column-rule-style", "inset");
25+
test_computed_value("row-rule-style", "none");
26+
test_computed_value("row-rule-style", "hidden");
27+
test_computed_value("row-rule-style", "dotted");
28+
test_computed_value("row-rule-style", "dashed");
29+
test_computed_value("row-rule-style", "solid");
30+
test_computed_value("row-rule-style", "double");
31+
test_computed_value("row-rule-style", "groove");
32+
test_computed_value("row-rule-style", "ridge");
33+
test_computed_value("row-rule-style", "inset");
2534

2635
test_computed_value("column-rule-style", "dotted dashed solid");
2736
test_computed_value("column-rule-style", "repeat(10, double)");
@@ -35,6 +44,18 @@
3544
test_computed_value("column-rule-style", "repeat(4, dotted double dashed) repeat(auto, solid) repeat(4, none groove hidden)");
3645
test_computed_value("column-rule-style", "ridge repeat(auto, solid)");
3746
test_computed_value("column-rule-style", "ridge repeat(auto, solid) ridge");
47+
test_computed_value("row-rule-style", "dotted dashed solid");
48+
test_computed_value("row-rule-style", "repeat(10, double)");
49+
test_computed_value("row-rule-style", "repeat(3, groove) repeat(4, ridge)");
50+
test_computed_value("row-rule-style", "repeat(auto, solid)");
51+
test_computed_value("row-rule-style", "repeat(auto, dotted solid inset)");
52+
test_computed_value("row-rule-style", "repeat(4, none ridge solid) repeat(auto, hidden)");
53+
test_computed_value("row-rule-style", "inset repeat(auto, solid ridge) repeat(4, none groove hidden)");
54+
test_computed_value("row-rule-style", "repeat(calc(5 + 3), ridge)", "repeat(8, ridge)");
55+
test_computed_value("row-rule-style", "repeat(4, dotted double dashed) repeat(auto, solid) ridge");
56+
test_computed_value("row-rule-style", "repeat(4, dotted double dashed) repeat(auto, solid) repeat(4, none groove hidden)");
57+
test_computed_value("row-rule-style", "ridge repeat(auto, solid)");
58+
test_computed_value("row-rule-style", "ridge repeat(auto, solid) ridge");
3859

3960
</script>
4061
</body>

css/css-gaps/tentative/parsing/gap-decorations-style-invalid.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,26 @@
55
<title>CSS Gap Decorations: column-rule-style parsing</title>
66
<link rel="help" href="https://drafts.csswg.org/css-gaps-1/#column-row-rule-style">
77
<link rel="author" title="Sam Davis Omekara Jr." href="mailto:[email protected]">
8-
<meta name="assert" content="column-rule-style supports only the grammar '[ <line-style-list> | <auto-line-style-list> ]'.">
8+
<meta name="assert" content="*-rule-style supports only the grammar '[ <line-style-list> | <auto-line-style-list> ]'.">
99
<script src="/resources/testharness.js"></script>
1010
<script src="/resources/testharnessreport.js"></script>
1111
<script src="/css/support/parsing-testcommon.js"></script>
1212
</head>
1313
<body>
1414
<script>
1515
test_invalid_value("column-rule-style", "auto");
16+
test_invalid_value("row-rule-style", "auto");
1617

1718
test_invalid_value("column-rule-style", "dashed, dotted, solid");
19+
test_invalid_value("row-rule-style", "dotted, dashed");
1820
test_invalid_value("column-rule-style", "repeat(auto, groove, dotted, ridge)");
21+
test_invalid_value("row-rule-style", "repeat(auto, solid, dashed, double)");
1922
test_invalid_value("column-rule-style", "repeat(0, dotted, solid, double)");
23+
test_invalid_value("row-rule-style", "repeat(0, dotted)");
2024
test_invalid_value("column-rule-style", "repeat(-1, dotted, dashed, double)");
25+
test_invalid_value("row-rule-style", "repeat(-1 dotted)");
2126
test_invalid_value("column-rule-style", "repeat(auto, dotted) red repeat(auto, ridge)");
27+
test_invalid_value("row-rule-style", "dotted repeat(auto, solid) blue repeat(auto, ridge)");
2228
</script>
2329
</body>
2430
</html>

css/css-gaps/tentative/parsing/gap-decorations-style-valid.html

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<title>CSS Gap Decorations: parsing column-rule-style with valid values</title>
66
<link rel="help" href="https://drafts.csswg.org/css-gaps-1/#column-row-rule-style">
77
<link rel="author" title="Sam Davis Omekara Jr." href="mailto:[email protected]">
8-
<meta name="assert" content="column-rule-style supports the full grammar '[ <line-style-list> | <auto-line-style-list> ]'.">
8+
<meta name="assert" content="*-rule-style supports the full grammar '[ <line-style-list> | <auto-line-style-list> ]'.">
99
<script src="/resources/testharness.js"></script>
1010
<script src="/resources/testharnessreport.js"></script>
1111
<script src="/css/support/parsing-testcommon.js"></script>
@@ -16,28 +16,43 @@
1616
test_valid_value("column-rule-style", "repeat(4, dotted)");
1717
test_valid_value("column-rule-style", "repeat(3, dashed double dotted)");
1818
test_valid_value("column-rule-style", "repeat(1, dashed double dotted solid)");
19+
test_valid_value("row-rule-style", "repeat(5, dashed)");
20+
test_valid_value("row-rule-style", "repeat(4, dashed dotted)");
21+
test_valid_value("row-rule-style", "repeat(1, dashed double dotted solid)");
1922

2023
// <line-style-or-repeat> = [ <style> | <repeat-line-style> ]
2124
test_valid_value("column-rule-style", "dashed");
2225
test_valid_value("column-rule-style", "repeat(4, double)");
26+
test_valid_value("row-rule-style", "ridge");
27+
test_valid_value("row-rule-style", "repeat(5, solid)");
2328

2429
// <line-style-list> = [ <line-style-or-repeat> ]+
2530
test_valid_value("column-rule-style", "dotted ridge");
2631
test_valid_value("column-rule-style", "dotted dashed solid groove ridge");
2732
test_valid_value("column-rule-style", "repeat(3, groove) repeat(4, ridge)");
2833
test_valid_value("column-rule-style", "inset repeat(3, ridge) none repeat(4, groove hidden dashed)");
2934
test_valid_value("column-rule-style", "repeat(4, none ridge solid) repeat(5, hidden) double");
35+
test_valid_value("row-rule-style", "dotted");
36+
test_valid_value("row-rule-style", "dotted dashed ridge");
37+
test_valid_value("row-rule-style", "repeat(4, solid) repeat(5, double) repeat(6, dotted)");
38+
test_valid_value("row-rule-style", "ridge repeat(4, solid) double repeat(6, dotted)");
39+
test_valid_value("row-rule-style", "repeat(4, none ridge solid) solid repeat(5, hidden) double");
3040

3141
// <auto-repeat-line-style> = repeat( auto , [ <style> ]+ )
3242
test_valid_value("column-rule-style", "repeat(auto, solid)");
3343
test_valid_value("column-rule-style", "repeat(auto, dotted solid inset)");
44+
test_valid_value("row-rule-style", "repeat(auto, dotted)");
45+
test_valid_value("row-rule-style", "repeat(auto, dashed solid inset double)");
3446

3547
// <auto-line-style-list> = [ <line-style-or-repeat> ]*
3648
// <auto-repeat-line-style>
3749
// [ <line-style-or-repeat> ]*
3850
test_valid_value("column-rule-style", "repeat(auto, dashed groove) ridge");
3951
test_valid_value("column-rule-style", "repeat(4, dotted double dashed) repeat(auto, solid)");
4052
test_valid_value("column-rule-style", "inset repeat(auto, solid ridge) repeat(4, none groove hidden)");
53+
test_valid_value("row-rule-style", "repeat(auto, dashed groove) repeat(4, solid) double");
54+
test_valid_value("row-rule-style", "repeat(4, dotted double dashed) repeat(auto, solid) repeat(4, none groove hidden)");
55+
test_valid_value("row-rule-style", "dotted repeat(auto, solid ridge) solid");
4156
</script>
4257
</body>
4358
</html>

0 commit comments

Comments
 (0)