-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit 6640144
Revert "Revert "[LNA] rename fetch targetAddressSpace options""
This reverts commit c088885ba810847bbd8f35fe039144ebefd39148.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6225501782802432
Sample build with failed test: https://ci.chromium.org/b/8713760342038285425
Affected test(s):
[ninja://chrome/test:browser_tests/LocalNetworkAccessBrowserTest.CheckPrivateAliasFeatureCounterLocalNotCounted](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FLocalNetworkAccessBrowserTest.CheckPrivateAliasFeatureCounterLocalNotCounted?q=VHash%3A1b090004a0f6be54)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6225501782802432&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6588736&type=BUG
Original change's description:
> Revert "[LNA] rename fetch targetAddressSpace options"
>
> This reverts commit d3158d4e53f9c6bcf080da32eb3ab03b5fbe748c.
>
> Reason for revert: Chrome build gardener: It caused new failing tests b/420455025
>
> Bug: 418737577
> Original change's description:
> > [LNA] rename fetch targetAddressSpace options
> >
> > Rename the targetAddressSpace args based on LNA's naming. Mapping of PNA
> > names -> LNA names:
> >
> > PNA | LNA
> > -------------------
> > local | loopback
> > private | local
> > public | public
> >
> > keep private as an alias for local.
> >
> > Removing
> > private-network-access/mixed-content-fetch.tentative.https.window.js as
> > PNA is being removed and its not straightforward to keep this test
> > working with the rename.
> >
> > LNA = Local Network Access = new hotness
> > PNA = Private Network Access = old and busted
> >
> > Bug: 418737577
> > Change-Id: I195a63e90a1300e58c40761069daad00b3680696
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6564545
> > Reviewed-by: Chris Thompson <[email protected]>
> > Reviewed-by: Adam Rice <[email protected]>
> > Commit-Queue: Hubert Chao <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1465461}
>
> Bug: 418737577
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I60ab2127ac0f54d24290234ebd1bb781c4ffc1e9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6588736
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Adam Rice <[email protected]>
> Reviewed-by: Adam Rice <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1465696}
>
Bug: 418737577
Bug: 418737577
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I05b4ae8a803cc0098a9f4f8c996ddc59422b7a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6589416
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1465790}1 parent f995712 commit 6640144Copy full SHA for 6640144
File tree
Expand file treeCollapse file tree
1 file changed
+0
-278
lines changedFilter options
- fetch/private-network-access
Expand file treeCollapse file tree
1 file changed
+0
-278
lines changedfetch/private-network-access/mixed-content-fetch.tentative.https.window.js
Copy file name to clipboardExpand all lines: fetch/private-network-access/mixed-content-fetch.tentative.https.window.js-278Lines changed: 0 additions & 278 deletions
This file was deleted.
0 commit comments