Add more tests for returnValue behaviour

Author: lukewarlow

html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior.html

@@ -138,6 +138,69 @@
         `invoking to close (with command ${setType} as ${command}) open dialog closes and sets returnValue`,
       );
 
+      promise_test(
+        async function (t) {
+          t.add_cleanup(resetState);
+          invokee.show();
+          assert_true(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+          if (setType === "property") {
+            containedinvoker.command = command;
+          } else {
+            containedinvoker.setAttribute("command", command);
+          }
+          invokee.returnValue = "test";
+          containedinvoker.setAttribute("value", "foo");
+          await clickOn(containedinvoker);
+          assert_equals(invokee.returnValue, "foo");
+          assert_false(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+        },
+        `invoking to close (with command ${setType} as ${command}) open dialog closes and overrides returnValue`,
+      );
+
+      promise_test(
+        async function (t) {
+          t.add_cleanup(resetState);
+          invokee.show();
+          assert_true(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+          if (setType === "property") {
+            containedinvoker.command = command;
+          } else {
+            containedinvoker.setAttribute("command", command);
+          }
+          invokee.returnValue = "test";
+          containedinvoker.setAttribute("value", "");
+          await clickOn(containedinvoker);
+          assert_equals(invokee.returnValue, "");
+          assert_false(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+        },
+        `invoking to close (with command ${setType} as ${command}) open dialog closes and overrides returnValue when empty string`,
+      );
+
+      promise_test(
+        async function (t) {
+          t.add_cleanup(resetState);
+          invokee.show();
+          assert_true(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+          if (setType === "property") {
+            containedinvoker.command = command;
+          } else {
+            containedinvoker.setAttribute("command", command);
+          }
+          invokee.returnValue = "test";
+          containedinvoker.removeAttribute("value");
+          await clickOn(containedinvoker);
+          assert_equals(invokee.returnValue, "test");
+          assert_false(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+        },
+        `invoking to close (with command ${setType} as ${command}) open dialog closes and doesn't override returnValue when missing value attribute`,
+      );
+
       promise_test(
         async function (t) {
           t.add_cleanup(resetState);
@@ -277,6 +340,69 @@
         `invoking to close (with command ${setType} as ${command}) open dialog closes and sets returnValue`,
       );
 
+      promise_test(
+        async function (t) {
+          t.add_cleanup(resetState);
+          invokee.show();
+          assert_true(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+          if (setType === "property") {
+            containedinvoker.command = command;
+          } else {
+            containedinvoker.setAttribute("command", command);
+          }
+          invokee.returnValue = "test";
+          containedinvoker.setAttribute("value", "foo");
+          await clickOn(containedinvoker);
+          assert_equals(invokee.returnValue, "foo");
+          assert_false(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+        },
+        `invoking to close (with command ${setType} as ${command}) open dialog closes and overrides returnValue`,
+      );
+
+      promise_test(
+        async function (t) {
+          t.add_cleanup(resetState);
+          invokee.show();
+          assert_true(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+          if (setType === "property") {
+            containedinvoker.command = command;
+          } else {
+            containedinvoker.setAttribute("command", command);
+          }
+          invokee.returnValue = "test";
+          containedinvoker.setAttribute("value", "");
+          await clickOn(containedinvoker);
+          assert_equals(invokee.returnValue, "");
+          assert_false(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+        },
+        `invoking to close (with command ${setType} as ${command}) open dialog closes and overrides returnValue when empty string`,
+      );
+
+      promise_test(
+        async function (t) {
+          t.add_cleanup(resetState);
+          invokee.show();
+          assert_true(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+          if (setType === "property") {
+            containedinvoker.command = command;
+          } else {
+            containedinvoker.setAttribute("command", command);
+          }
+          invokee.returnValue = "test";
+          containedinvoker.removeAttribute("value");
+          await clickOn(containedinvoker);
+          assert_equals(invokee.returnValue, "test");
+          assert_false(invokee.open, "invokee.open");
+          assert_false(invokee.matches(":modal"), "invokee :modal");
+        },
+        `invoking to close (with command ${setType} as ${command}) open dialog closes and doesn't override returnValue when missing value attribute`,
+      );
+
       promise_test(
         async function (t) {
           t.add_cleanup(resetState);