Rename TextCluster begin attribute to start

This CL renames the begin attribute of TextCluster objects into start.
This matches how the function arguments defining character ranges are
named, therefore making it consistent.

This new naming came to be from the discussion around the spec for the
TextMetrics additions: whatwg/html#11000

Bug: 341213359
Change-Id: I55fa6a40d624b29aca56a6af3703efbdab39a541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330469
Reviewed-by: Jean-Philippe Gravel <[email protected]>
Commit-Queue: Andres Ricardo Perez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1430259}

Author: AndresRPerez12

html/canvas/element/text/2d.text.measure.text-clusters-split.tentative.html

@@ -28,22 +28,22 @@ <h1>2d.text.measure.text-clusters-split.tentative</h1>
   // Should return 6 clusters(A|B|C| |☺️|❤️).
   _assertSame(clusters.length, 6, "clusters.length", "6");
   // A from position 0 to 1.
-  _assertSame(clusters[0].begin, 0, "clusters[\""+(0)+"\"].begin", "0");
+  _assertSame(clusters[0].start, 0, "clusters[\""+(0)+"\"].start", "0");
   _assertSame(clusters[0].end, 1, "clusters[\""+(0)+"\"].end", "1");
   // B from position 1 to 2.
-  _assertSame(clusters[1].begin, 1, "clusters[\""+(1)+"\"].begin", "1");
+  _assertSame(clusters[1].start, 1, "clusters[\""+(1)+"\"].start", "1");
   _assertSame(clusters[1].end, 2, "clusters[\""+(1)+"\"].end", "2");
   // C from position 2 to 3.
-  _assertSame(clusters[2].begin, 2, "clusters[\""+(2)+"\"].begin", "2");
+  _assertSame(clusters[2].start, 2, "clusters[\""+(2)+"\"].start", "2");
   _assertSame(clusters[2].end, 3, "clusters[\""+(2)+"\"].end", "3");
   // space from position 3 to 4.
-  _assertSame(clusters[3].begin, 3, "clusters[\""+(3)+"\"].begin", "3");
+  _assertSame(clusters[3].start, 3, "clusters[\""+(3)+"\"].start", "3");
   _assertSame(clusters[3].end, 4, "clusters[\""+(3)+"\"].end", "4");
   // ☺️ from position 4 to 6.
-  _assertSame(clusters[4].begin, 4, "clusters[\""+(4)+"\"].begin", "4");
+  _assertSame(clusters[4].start, 4, "clusters[\""+(4)+"\"].start", "4");
   _assertSame(clusters[4].end, 6, "clusters[\""+(4)+"\"].end", "6");
   // ❤️ from position 6 to 8.
-  _assertSame(clusters[5].begin, 6, "clusters[\""+(5)+"\"].begin", "6");
+  _assertSame(clusters[5].start, 6, "clusters[\""+(5)+"\"].start", "6");
   _assertSame(clusters[5].end, 8, "clusters[\""+(5)+"\"].end", "8");
 
 });

html/canvas/offscreen/text/2d.text.measure.text-clusters-split.tentative.html

@@ -29,22 +29,22 @@ <h1>2d.text.measure.text-clusters-split.tentative</h1>
   // Should return 6 clusters(A|B|C| |☺️|❤️).
   _assertSame(clusters.length, 6, "clusters.length", "6");
   // A from position 0 to 1.
-  _assertSame(clusters[0].begin, 0, "clusters[\""+(0)+"\"].begin", "0");
+  _assertSame(clusters[0].start, 0, "clusters[\""+(0)+"\"].start", "0");
   _assertSame(clusters[0].end, 1, "clusters[\""+(0)+"\"].end", "1");
   // B from position 1 to 2.
-  _assertSame(clusters[1].begin, 1, "clusters[\""+(1)+"\"].begin", "1");
+  _assertSame(clusters[1].start, 1, "clusters[\""+(1)+"\"].start", "1");
   _assertSame(clusters[1].end, 2, "clusters[\""+(1)+"\"].end", "2");
   // C from position 2 to 3.
-  _assertSame(clusters[2].begin, 2, "clusters[\""+(2)+"\"].begin", "2");
+  _assertSame(clusters[2].start, 2, "clusters[\""+(2)+"\"].start", "2");
   _assertSame(clusters[2].end, 3, "clusters[\""+(2)+"\"].end", "3");
   // space from position 3 to 4.
-  _assertSame(clusters[3].begin, 3, "clusters[\""+(3)+"\"].begin", "3");
+  _assertSame(clusters[3].start, 3, "clusters[\""+(3)+"\"].start", "3");
   _assertSame(clusters[3].end, 4, "clusters[\""+(3)+"\"].end", "4");
   // ☺️ from position 4 to 6.
-  _assertSame(clusters[4].begin, 4, "clusters[\""+(4)+"\"].begin", "4");
+  _assertSame(clusters[4].start, 4, "clusters[\""+(4)+"\"].start", "4");
   _assertSame(clusters[4].end, 6, "clusters[\""+(4)+"\"].end", "6");
   // ❤️ from position 6 to 8.
-  _assertSame(clusters[5].begin, 6, "clusters[\""+(5)+"\"].begin", "6");
+  _assertSame(clusters[5].start, 6, "clusters[\""+(5)+"\"].start", "6");
   _assertSame(clusters[5].end, 8, "clusters[\""+(5)+"\"].end", "8");
   t.done();
 

html/canvas/offscreen/text/2d.text.measure.text-clusters-split.tentative.worker.js

@@ -24,22 +24,22 @@ t.step(function() {
   // Should return 6 clusters(A|B|C| |☺️|❤️).
   _assertSame(clusters.length, 6, "clusters.length", "6");
   // A from position 0 to 1.
-  _assertSame(clusters[0].begin, 0, "clusters[\""+(0)+"\"].begin", "0");
+  _assertSame(clusters[0].start, 0, "clusters[\""+(0)+"\"].start", "0");
   _assertSame(clusters[0].end, 1, "clusters[\""+(0)+"\"].end", "1");
   // B from position 1 to 2.
-  _assertSame(clusters[1].begin, 1, "clusters[\""+(1)+"\"].begin", "1");
+  _assertSame(clusters[1].start, 1, "clusters[\""+(1)+"\"].start", "1");
   _assertSame(clusters[1].end, 2, "clusters[\""+(1)+"\"].end", "2");
   // C from position 2 to 3.
-  _assertSame(clusters[2].begin, 2, "clusters[\""+(2)+"\"].begin", "2");
+  _assertSame(clusters[2].start, 2, "clusters[\""+(2)+"\"].start", "2");
   _assertSame(clusters[2].end, 3, "clusters[\""+(2)+"\"].end", "3");
   // space from position 3 to 4.
-  _assertSame(clusters[3].begin, 3, "clusters[\""+(3)+"\"].begin", "3");
+  _assertSame(clusters[3].start, 3, "clusters[\""+(3)+"\"].start", "3");
   _assertSame(clusters[3].end, 4, "clusters[\""+(3)+"\"].end", "4");
   // ☺️ from position 4 to 6.
-  _assertSame(clusters[4].begin, 4, "clusters[\""+(4)+"\"].begin", "4");
+  _assertSame(clusters[4].start, 4, "clusters[\""+(4)+"\"].start", "4");
   _assertSame(clusters[4].end, 6, "clusters[\""+(4)+"\"].end", "6");
   // ❤️ from position 6 to 8.
-  _assertSame(clusters[5].begin, 6, "clusters[\""+(5)+"\"].begin", "6");
+  _assertSame(clusters[5].start, 6, "clusters[\""+(5)+"\"].start", "6");
   _assertSame(clusters[5].end, 8, "clusters[\""+(5)+"\"].end", "8");
   t.done();
 });

html/canvas/tools/yaml/text.yaml

@@ -2058,22 +2058,22 @@
     // Should return 6 clusters(A|B|C| |☺️|❤️).
     @assert clusters.length === 6;
     // A from position 0 to 1.
-    @assert clusters[0].begin === 0;
+    @assert clusters[0].start === 0;
     @assert clusters[0].end === 1;
     // B from position 1 to 2.
-    @assert clusters[1].begin === 1;
+    @assert clusters[1].start === 1;
     @assert clusters[1].end === 2;
     // C from position 2 to 3.
-    @assert clusters[2].begin === 2;
+    @assert clusters[2].start === 2;
     @assert clusters[2].end === 3;
     // space from position 3 to 4.
-    @assert clusters[3].begin === 3;
+    @assert clusters[3].start === 3;
     @assert clusters[3].end === 4;
     // ☺️ from position 4 to 6.
-    @assert clusters[4].begin === 4;
+    @assert clusters[4].start === 4;
     @assert clusters[4].end === 6;
     // ❤️ from position 6 to 8.
-    @assert clusters[5].begin === 6;
+    @assert clusters[5].start === 6;
     @assert clusters[5].end === 8;
 
 - name: 2d.text.measure.text-clusters-exceptions.tentative