Skip to content

Commit cb912e9

Browse files
VT interop: Add waitForCompositorReady to several VT tests (#52701)
This adds waiting for compositor ready to several tests. This ensures that the tests are resilient to start up conditions [email protected] Change-Id: I4babaf579d172454586f1d633ab4ce5c4cb139ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6569910 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1463527} Co-authored-by: Vladimir Levin <[email protected]>
1 parent 5c28beb commit cb912e9

6 files changed

+17
-2
lines changed

css/css-view-transitions/group-animation-for-root-transition.html

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,15 @@
44
<link rel="help" href="https://drafts.csswg.org/css-view-transitions-1/">
55
<link rel="author" href="mailto:[email protected]">
66

7+
<script src="/dom/events/scrolling/scroll_support.js"></script>
78
<script src="/resources/testharness.js"></script>
89
<script src="/resources/testharnessreport.js"></script>
910

11+
<body>
1012
<script>
11-
promise_test(() => {
13+
promise_test(async () => {
1214
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
15+
await waitForCompositorReady();
1316
return new Promise(async (resolve, reject) => {
1417
let transition = document.startViewTransition();
1518
transition.ready.then(() => {
@@ -45,3 +48,4 @@
4548
});
4649
}, "incorrect UA animations for root transition");
4750
</script>
51+
</body>

css/css-view-transitions/no-crash-set-exception.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<link rel="help" href="https://drafts.csswg.org/css-view-transitions-1/">
55
<link rel="author" href="mailto:[email protected]">
66

7+
<script src="/dom/events/scrolling/scroll_support.js"></script>
78
<script src="/resources/testharness.js"></script>
89
<script src="/resources/testharnessreport.js"></script>
910

@@ -30,6 +31,7 @@
3031
<script>
3132
promise_test(async t => {
3233
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
34+
await waitForCompositorReady();
3335
return new Promise((resolve, reject) => {
3436
document.startViewTransition(() => {
3537
resolve();

css/css-view-transitions/no-raf-while-render-blocked.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<link rel="help" href="https://drafts.csswg.org/css-view-transitions-1/">
66
<link rel="author" href="mailto:[email protected]">
77

8+
<script src="/dom/events/scrolling/scroll_support.js"></script>
89
<script src="/resources/testharness.js"></script>
910
<script src="/resources/testharnessreport.js"></script>
1011

@@ -23,8 +24,9 @@
2324
<script>
2425
let renderBlocked = true;
2526

26-
promise_test(() => {
27+
promise_test(async () => {
2728
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
29+
await waitForCompositorReady();
2830
return new Promise(async (resolve, reject) => {
2931
requestAnimationFrame(() => {
3032
document.startViewTransition(() => {

css/css-view-transitions/paused-animation-at-end.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<link rel="help" href="https://www.w3.org/TR/css-view-transitions-1/">
44
<link rel="author" href="mailto:[email protected]">
55

6+
<script src="/dom/events/scrolling/scroll_support.js"></script>
67
<script src="/resources/testharness.js"></script>
78
<script src="/resources/testharnessreport.js"></script>
89

@@ -25,6 +26,8 @@
2526

2627
<script>
2728
promise_test(async (t) => {
29+
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
30+
await waitForCompositorReady();
2831
return new Promise((resolve, reject) => {
2932
let transition = document.startViewTransition(() => {
3033
target.classList.replace("one", "two");

css/css-view-transitions/transition-skipped-after-animation-started.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<link rel="help" href="https://www.w3.org/TR/css-view-transitions-1/">
55
<link rel="author" href="mailto:[email protected]">
66

7+
<script src="/dom/events/scrolling/scroll_support.js"></script>
78
<script src="/resources/testharness.js"></script>
89
<script src="/resources/testharnessreport.js"></script>
910

@@ -26,6 +27,7 @@
2627
<script>
2728
promise_test(async t => {
2829
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
30+
await waitForCompositorReady();
2931
return new Promise(async (resolve, reject) => {
3032
let transition = document.startViewTransition();
3133
await transition.ready;

css/css-view-transitions/view-transition-name-on-removed-element.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<link rel="help" href="https://www.w3.org/TR/css-view-transitions-1/">
55
<link rel="author" href="mailto:[email protected]">
66

7+
<script src="/dom/events/scrolling/scroll_support.js"></script>
78
<script src="/resources/testharness.js"></script>
89
<script src="/resources/testharnessreport.js"></script>
910

@@ -23,6 +24,7 @@
2324
<script>
2425
promise_test(async t => {
2526
assert_implements(document.startViewTransition, "Missing document.startViewTransition");
27+
await waitForCompositorReady();
2628
return new Promise(async (resolve, reject) => {
2729
// Remove an uncontained element. Because this element is not visited when
2830
// discovering named elements, the transition is not skipped.

0 commit comments

Comments
 (0)