Skip to content

Commit f4bc67f

Browse files
Don't set test fail status in web-extensions-helper.js. (#61149)
web-extension-helper.js was overriding the test status to just `test.FAIL`, leaving out the test message. This causes a test failure to look like: `FAIL message: Undefined.UNDEFINED` since the message and stack are `undefined`. `test.set_status(status, message, stack);` is already being handled by testharness.js in the `step()` method (see line 2878) so we can just rely on that.
1 parent 20a4998 commit f4bc67f

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

resources/web-extensions-helper.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ globalThis.runTestsWithWebExtension = function(extensionPath) {
2727

2828
test.done();
2929

30-
if (!data.result) {
31-
test.set_status(test.FAIL);
32-
}
33-
3430
if (data.remainingTests) {
3531
return;
3632
}

0 commit comments

Comments
 (0)