fix: only recheck pin status if pinning or queued (#2236)

olizilla · web-flow · commit 949f866b1845 · 2023-03-17T15:17:35.000Z
pickup will list a pin as "pinning" while it internally retries after an
error. If fetching the DAG times our, or repeatedly errors for some
other reason, pickup wont keep retrying it. The pin status will either
be queued, pinning, pinned, or failed.

change the logic of the pins cron to only recheck pins that are queued
or pinning.

License: MIT

Signed-off-by: Oli Evans &lt;oli@protocol.ai&gt;
diff --git a/packages/cron/src/jobs/pins.js b/packages/cron/src/jobs/pins.js
@@ -106,7 +106,7 @@ export async function updatePinStatuses ({ cluster, db }) {
         return null
       }
 
-      if (status !== 'Pinned') reSyncPins.push(pin)
+      if (status === 'PinQueued' || status === 'Pinning') reSyncPins.push(pin)
 
       if (status === pin.status) {
         log(`🙅 ${pin.contentCid}@${pin.location.peerId}: No status change (${status})`)

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ export async function updatePinStatuses ({ cluster, db }) {`
`106`	`106`	`return null`
`107`	`107`	`}`
`108`	`108`
`109`		`- if (status !== 'Pinned') reSyncPins.push(pin)`
	`109`	`+ if (status === 'PinQueued' \|\| status === 'Pinning') reSyncPins.push(pin)`
`110`	`110`
`111`	`111`	`if (status === pin.status) {`
`112`	`112`	log(`🙅 ${pin.contentCid}@${pin.location.peerId}: No status change (${status})`)