Keep quest checkpoints advancing

Author: web3blind

app/index.html

@@ -191,7 +191,7 @@
     <script src="js/ui/screens/map.js?v=20260621h"></script>
     <script src="js/ui/screens/marketplace.js?v=20260621k"></script>
     <script src="js/ui/screens/crafting.js?v=20260621j"></script>
-    <script src="js/ui/screens/quests.js?v=20260621m"></script>
+    <script src="js/ui/screens/quests.js?v=20260621n"></script>
     <script src="js/ui/screens/world-boss.js"></script>
     <script src="js/ui/screens/settings.js"></script>
     <script src="js/ui/screens/help.js"></script>

app/js/ui/screens/quests.js

@@ -328,9 +328,11 @@ var QuestsScreen = (function() {
             }
 
             var user = VizAccount.getCurrentUser();
-            var finalBlockNum = (result && result.block_num) ||
+            var currentHead = StateEngine.getState().headBlock || 0;
+            var finalBlockNum =
+                (result && result.block_num) ||
                 (result && result.action && result.action.block_num) ||
-                (StateEngine.getState().headBlock || 0);
+                (currentHead + 1);
             var event = null;
             if (kind === 'accept') {
                 event = StateEngine.processQuestAcceptResult(user, questId, isDaily, dailyBlock, finalBlockNum);

app/sw.js

@@ -1,5 +1,5 @@
 // Viz Magic — Service Worker
-var CACHE_NAME = 'viz-magic-v26';
+var CACHE_NAME = 'viz-magic-v27';
 var ASSETS = [
     '/',
     '/index.html',

tests/core-screen-accessibility-smoke.test.js

@@ -90,7 +90,7 @@ async function run() {
     var badLogs = logs.filter(function(l) { return l.type === 'error' || l.type === 'pageerror'; });
     assert.deepStrictEqual(failed, [], 'all core screens should render with named controls and no raw keys');
     assert.deepStrictEqual(badLogs, [], 'core screen smoke should not emit console errors/page errors');
-    assert.ok(result.cachesKeys.indexOf('viz-magic-v26') !== -1, 'service worker cache should use latest cache name');
+    assert.ok(result.cachesKeys.indexOf('viz-magic-v27') !== -1, 'service worker cache should use latest cache name');
     assert.ok(result.scripts.some(function(src) { return src.indexOf('helpers.js?v=20260621l') !== -1; }), 'helpers script should be cache-busted');
     assert.ok(result.scripts.some(function(src) { return src.indexOf('territory.js?v=20260621l') !== -1; }), 'territory script should be cache-busted');
     assert.ok(result.scripts.some(function(src) { return src.indexOf('state-engine.js?v=20260621m') !== -1; }), 'state engine script should be cache-busted');

tests/player-bug-regressions.test.js

@@ -327,7 +327,7 @@ test('high-traffic UI narration and inventory stat labels are translated', funct
 
 test('service worker updates quickly and keeps navigations network-first', function () {
   const swJs = read('app/sw.js');
-  assert.ok(/viz-magic-v26/.test(swJs), 'service worker cache version should be bumped');
+  assert.ok(/viz-magic-v27/.test(swJs), 'service worker cache version should be bumped');
   assert.ok(/self\.skipWaiting\(\)/.test(swJs), 'service worker should activate new cache without waiting for all tabs to close');
   assert.ok(/self\.clients\.claim\(\)/.test(swJs), 'service worker should claim clients after activation');
   assert.ok(/event\.request\.mode === 'navigate'[\s\S]*fetch\(event\.request\)/.test(swJs), 'navigation requests should prefer network to avoid stale cached index');

tests/quest-browser-transaction-smoke.test.js

@@ -51,7 +51,11 @@ async function run() {
       var calls = [];
       VizBroadcast.questAction = function(type, data, callback) {
         calls.push({ type: type, data: JSON.parse(JSON.stringify(data || {})) });
-        callback(null, { block_num: 12010 });
+        if (calls.length === 1) {
+          callback(null, {});
+        } else {
+          callback(null, { block_num: 12010 + calls.length });
+        }
       };
 
       App.navigateTo('quests');
@@ -63,6 +67,7 @@ async function run() {
       var questId = acceptBtn.getAttribute('data-quest-id');
       acceptBtn.click();
       await new Promise(function(resolve) { setTimeout(resolve, 120); });
+      var headAfterAccept = StateEngine.getState().headBlock;
       var activeAfterAccept = StateEngine.getState().quests['quest-smoke'].active.map(function(q) { return q.id; });
       document.querySelector('[data-tab="active"]').click();
       await new Promise(function(resolve) { setTimeout(resolve, 80); });
@@ -84,6 +89,7 @@ async function run() {
       return {
         calls: calls,
         questId: questId,
+        headAfterAccept: headAfterAccept,
         activeAfterAccept: activeAfterAccept,
         activeAfterAbandon: activeAfterAbandon,
         activeAfterDaily: activeAfterDaily,
@@ -94,13 +100,14 @@ async function run() {
     assert.ifError(result.error);
     assert.strictEqual(result.calls[0].type, 'quest.accept', 'available quest accept should broadcast VM action');
     assert.strictEqual(result.calls[0].data.quest_id, result.questId, 'quest id should be sent on chain');
+    assert.strictEqual(result.headAfterAccept, 12001, 'quest accept without returned block should still advance checkpoint head');
     assert.ok(result.activeAfterAccept.indexOf(result.questId) !== -1, 'accepted quest should update StateEngine after broadcast');
     assert.strictEqual(result.calls[1].type, 'quest.abandon', 'abandon should broadcast VM action');
     assert.deepStrictEqual(result.activeAfterAbandon, [], 'abandoned quest should update StateEngine after broadcast');
     assert.strictEqual(result.calls[2].type, 'quest.accept', 'daily quest accept should broadcast VM action');
     assert.strictEqual(result.calls[2].data.daily, true, 'daily quest should include deterministic daily marker');
     assert.ok(result.activeAfterDaily.length === 1 && /^daily_/.test(result.activeAfterDaily[0]), 'daily quest should be accepted through StateEngine');
-    assert.strictEqual(result.headBlock, 12010, 'local checkpoint head should advance to broadcast block');
+    assert.strictEqual(result.headBlock, 12013, 'local checkpoint head should advance to latest broadcast block');
     console.log('PASS quest browser transaction smoke');
   } finally {
     if (browser) await browser.close();