Fix quest and chronicle display regressions

Author: web3blind

app/index.html

@@ -141,7 +141,7 @@
     <script src="js/data/spells.js"></script>
     <script src="js/data/recipes.js"></script>
     <script src="js/data/regions.js"></script>
-    <script src="js/data/quests.js"></script>
+    <script src="js/data/quests.js?v=20260621e"></script>
 
     <!-- Game engine -->
     <script src="js/engine/types.js"></script>
@@ -161,10 +161,10 @@
     <script src="js/engine/block-processor.js"></script>
     <script src="js/engine/world-events.js"></script>
     <script src="js/engine/world-boss.js"></script>
-    <script src="js/engine/quest-system.js"></script>
+    <script src="js/engine/quest-system.js?v=20260621e"></script>
     <script src="js/engine/loci.js"></script>
     <script src="js/engine/npc-framework.js"></script>
-    <script src="js/engine/state-engine.js"></script>
+    <script src="js/engine/state-engine.js?v=20260621e"></script>
     <script src="js/engine/daily-leaderboard-storage.js"></script>
     <script src="js/engine/daily-leaderboard.js"></script>
 
@@ -184,14 +184,14 @@
     <script src="js/ui/screens/character.js"></script>
     <script src="js/ui/screens/hunt.js"></script>
     <script src="js/ui/screens/inventory.js"></script>
-    <script src="js/ui/screens/chronicle.js"></script>
+    <script src="js/ui/screens/chronicle.js?v=20260621f"></script>
     <script src="js/ui/screens/duel.js"></script>
     <script src="js/ui/screens/arena.js?v=20260621d"></script>
     <script src="js/ui/screens/guild.js?v=20260621d"></script>
     <script src="js/ui/screens/map.js"></script>
     <script src="js/ui/screens/marketplace.js"></script>
     <script src="js/ui/screens/crafting.js"></script>
-    <script src="js/ui/screens/quests.js"></script>
+    <script src="js/ui/screens/quests.js?v=20260621e"></script>
     <script src="js/ui/screens/world-boss.js"></script>
     <script src="js/ui/screens/settings.js"></script>
     <script src="js/ui/screens/help.js"></script>

app/js/engine/quest-system.js

@@ -238,6 +238,7 @@ var QuestSystem = (function() {
         playerQuests.active.splice(questIndex, 1);
         playerQuests.completed.push({
             id: quest.id,
+            titleKey: quest.titleKey || (questTemplate && questTemplate.titleKey) || '',
             completedBlock: blockNum
         });
 

app/js/engine/state-engine.js

@@ -696,7 +696,7 @@ var StateEngine = (function() {
         if (!guild) return [];
         var ok = GuildSystem.joinGuild(guild, sender, blockNum);
         if (!ok) return [];
-        return [{ type: 'guild_joined', guildId: data.guild_id, account: sender }];
+        return [{ type: 'guild_joined', guildId: data.guild_id, guildName: guild.name || data.guild_id, account: sender }];
     }
 
     function _handleGuildLeave(sender, data, blockNum) {

app/js/i18n/en.js

@@ -772,6 +772,7 @@ var LangEN = {
     quest_completed: 'Quest completed!',
     quest_abandon: 'Abandon',
     quest_abandoned: 'Quest abandoned.',
+    chronicle_unknown_guild: 'an unknown guild',
     quest_type_hunt: 'Hunt',
     quest_type_craft: 'Craft',
     quest_type_duel: 'Duel',

app/js/i18n/ru.js

@@ -772,6 +772,7 @@ var LangRU = {
     quest_completed: 'Задание выполнено!',
     quest_abandon: 'Отказаться',
     quest_abandoned: 'Задание отменено.',
+    chronicle_unknown_guild: 'неизвестная гильдия',
     quest_type_hunt: 'Охота',
     quest_type_craft: 'Ковка',
     quest_type_duel: 'Дуэль',

app/js/ui/screens/chronicle.js

@@ -456,10 +456,10 @@ var ChronicleScreen = (function() {
                 var itemName = (ev0 && ev0.itemName) ? ev0.itemName : '';
                 return t('chronicle_narrative_craft', { name: name, item: itemName });
             case 'guild.create':
-                var guildName = (ev0 && ev0.guildName) ? ev0.guildName : '';
+                var guildName = _guildNameForCreateAction(action, ev0);
                 return t('chronicle_narrative_guild_created', { name: name, guild: guildName });
             case 'guild.accept':
-                var gJoin = (ev0 && ev0.guildName) ? ev0.guildName : '';
+                var gJoin = _guildDisplayName(ev0 && ev0.guildId, ev0 && ev0.guildName);
                 return t('chronicle_narrative_guild_join', { name: name, guild: gJoin });
             case 'boss.attack':
                 return name + ' ' + (t('boss_attack') || 'attacks the boss') + '!';
@@ -477,6 +477,38 @@ var ChronicleScreen = (function() {
         return (charInfo && charInfo.name) ? charInfo.name : account;
     }
 
+    function _guildNameForCreateAction(action, ev0) {
+        if (ev0 && (ev0.guildName || ev0.guildId)) {
+            return _guildDisplayName(ev0.guildId, ev0.guildName);
+        }
+
+        var state = StateEngine.getState();
+        if (state && state.guilds) {
+            for (var guildId in state.guilds) {
+                if (!state.guilds.hasOwnProperty(guildId)) continue;
+                var guild = state.guilds[guildId];
+                if (!guild) continue;
+                if (action && guild.createdBlock && action.blockNum && guild.createdBlock === action.blockNum) {
+                    return guild.name || guildId;
+                }
+                if (action && action.sender && guild.founder === action.sender) {
+                    return guild.name || guildId;
+                }
+            }
+        }
+
+        return Helpers.t('chronicle_unknown_guild');
+    }
+
+    function _guildDisplayName(guildId, eventName) {
+        if (eventName) return eventName;
+        var state = StateEngine.getState();
+        if (guildId && state && state.guilds && state.guilds[guildId]) {
+            return state.guilds[guildId].name || guildId;
+        }
+        return guildId || Helpers.t('chronicle_unknown_guild');
+    }
+
     function _filterByTab(entries, state) {
         if (currentTab === 'all') return entries;
 

app/js/ui/screens/quests.js

@@ -177,15 +177,27 @@ var QuestsScreen = (function() {
         var html = '<ul class="quest-list completed" role="list">';
         for (var i = completed.length - 1; i >= Math.max(0, completed.length - 20); i--) {
             var q = completed[i];
+            var title = _completedQuestTitle(q, t);
             html += '<li class="quest-card quest-completed-card">' +
                 '<span class="quest-icon" aria-hidden="true">\u2714</span>' +
-                '<span class="quest-name">' + Helpers.t(q.id) + '</span>' +
+                '<span class="quest-name">' + Helpers.escapeHtml(title) + '</span>' +
             '</li>';
         }
         html += '</ul>';
         return html;
     }
 
+    function _completedQuestTitle(q, t) {
+        if (!q) return '';
+        if (q.titleKey) return t(q.titleKey);
+        if (typeof GameQuests !== 'undefined' && GameQuests.getQuest) {
+            var quest = GameQuests.getQuest(q.id);
+            if (quest && quest.titleKey) return t(quest.titleKey);
+        }
+        if (/^daily_[0-9]+_[0-9]+$/.test(q.id || '')) return t('quest_daily_hunt');
+        return String(q.id || '').replace(/^q_/, '').replace(/_/g, ' ');
+    }
+
     function _renderQuestCard(quest, t, showActions) {
         var html = '<li class="quest-card' + (quest.completed ? ' quest-ready' : '') + '" role="listitem">';
         html += '<div class="quest-card-header">';

app/sw.js

@@ -1,5 +1,5 @@
 // Viz Magic — Service Worker
-var CACHE_NAME = 'viz-magic-v16';
+var CACHE_NAME = 'viz-magic-v19';
 var ASSETS = [
     '/',
     '/index.html',
@@ -65,6 +65,8 @@ self.addEventListener('install', function(event) {
     event.waitUntil(
         caches.open(CACHE_NAME).then(function(cache) {
             return cache.addAll(ASSETS);
+        }).then(function() {
+            return self.skipWaiting();
         })
     );
 });
@@ -76,11 +78,32 @@ self.addEventListener('activate', function(event) {
                 names.filter(function(n) { return n !== CACHE_NAME; })
                      .map(function(n) { return caches.delete(n); })
             );
+        }).then(function() {
+            return self.clients.claim();
         })
     );
 });
 
 self.addEventListener('fetch', function(event) {
+    if (event.request.mode === 'navigate') {
+        event.respondWith(
+            fetch(event.request).then(function(response) {
+                if (response && response.status === 200 && response.type === 'basic') {
+                    var clone = response.clone();
+                    caches.open(CACHE_NAME).then(function(cache) {
+                        cache.put(event.request, clone);
+                    });
+                }
+                return response;
+            }).catch(function() {
+                return caches.match(event.request).then(function(cached) {
+                    return cached || caches.match('/index.html');
+                });
+            })
+        );
+        return;
+    }
+
     event.respondWith(
         caches.match(event.request).then(function(cached) {
             return cached || fetch(event.request).then(function(response) {
@@ -91,11 +114,6 @@ self.addEventListener('fetch', function(event) {
                     });
                 }
                 return response;
-            }).catch(function() {
-                // Offline fallback
-                if (event.request.mode === 'navigate') {
-                    return caches.match('/index.html');
-                }
             });
         })
     );

tests/player-bug-regressions.test.js

@@ -34,6 +34,7 @@ const inventoryJs = read('app/js/ui/screens/inventory.js');
 const huntJs = read('app/js/ui/screens/hunt.js');
 const mapJs = read('app/js/ui/screens/map.js');
 const chronicleJs = read('app/js/ui/screens/chronicle.js');
+const questScreenJs = read('app/js/ui/screens/quests.js');
 const guildJs = read('app/js/ui/screens/guild.js');
 const leaderboardJs = read('app/js/ui/screens/leaderboard.js');
 const characterJs = read('app/js/ui/screens/character.js');
@@ -123,6 +124,22 @@ test('chronicle keeps loaded tabs visible and shows sent blessings immediately',
   assert.ok(/_injectLocalBlessing\(account, energy\)/.test(chronicleJs), 'blessing success path should inject visible local action');
 });
 
+
+
+test('completed quest list resolves quest titles instead of raw ids', function () {
+  assert.ok(/titleKey: quest\.titleKey/.test(read('app/js/engine/quest-system.js')), 'completed quest records should preserve titleKey for future claims');
+  assert.ok(/function _completedQuestTitle/.test(questScreenJs), 'quest screen should resolve completed quest titles');
+  assert.ok(/GameQuests\.getQuest\(q\.id\)/.test(questScreenJs), 'completed quest title should fall back to quest template');
+  assert.ok(!/Helpers\.t\(q\.id\)/.test(questScreenJs), 'completed quest list must not translate raw quest ids');
+});
+
+test('chronicle guild narratives have a guild-name fallback', function () {
+  assert.ok(/function _guildDisplayName/.test(chronicleJs), 'chronicle should resolve guild display names');
+  assert.ok(/function _guildNameForCreateAction/.test(chronicleJs), 'chronicle should recover guild names for old create entries');
+  assert.ok(/guildName: guild\.name/.test(stateEngineJs), 'guild join events should carry guildName');
+  assert.ok(/chronicle_unknown_guild/.test(chronicleJs + ruJs + enJs), 'unknown guild fallback copy should exist');
+});
+
 test('stale checkpoint catch-up keeps using scaled batches after first batch', function () {
   assert.ok(/function _nextCatchupBatchEnd/.test(appJs), 'app should centralize catch-up batch sizing');
   assert.ok(/var remaining = Math\.max\(0, chainHead - startBlock \+ 1\)/.test(appJs), 'batch sizing should use remaining gap');
@@ -164,6 +181,16 @@ test('high-traffic UI narration and inventory stat labels are translated', funct
   });
 });
 
+
+
+test('service worker updates quickly and keeps navigations network-first', function () {
+  const swJs = read('app/sw.js');
+  assert.ok(/viz-magic-v19/.test(swJs), 'service worker cache version should be bumped');
+  assert.ok(/self\.skipWaiting\(\)/.test(swJs), 'service worker should activate new cache without waiting for all tabs to close');
+  assert.ok(/self\.clients\.claim\(\)/.test(swJs), 'service worker should claim clients after activation');
+  assert.ok(/event\.request\.mode === 'navigate'[\s\S]*fetch\(event\.request\)/.test(swJs), 'navigation requests should prefer network to avoid stale cached index');
+});
+
 test('leaderboard has local character fallback while 24h scan is empty or slow', function () {
   assert.ok(/function _fallbackRowsFromState/.test(leaderboardJs), 'leaderboard should expose local fallback rows');
   assert.ok(/rows = _fallbackRowsFromState\(\)/.test(leaderboardJs), 'leaderboard should use fallback when snapshot rows are empty');