Fix player-reported gameplay UX issues

Author: web3blind

app/js/data/quests.js

@@ -83,7 +83,7 @@ var GameQuests = (function() {
             minLevel: 3,
             maxLevel: 50,
             objectives: [
-                { type: 'explore', required: 3 }
+                { type: 'explore', required: 3, uniqueTarget: true }
             ],
             rewards: {
                 xp: 250,
@@ -100,7 +100,7 @@ var GameQuests = (function() {
             minLevel: 1,
             maxLevel: 50,
             objectives: [
-                { type: 'social', target: 'blessing', required: 5 }
+                { type: 'social', target: 'blessing', required: 5, uniqueTarget: true }
             ],
             rewards: {
                 xp: 200,

app/js/engine/quest-system.js

@@ -77,7 +77,9 @@ var QuestSystem = (function() {
                 target: obj.target || '',
                 required: obj.required,
                 current: 0,
-                completed: false
+                completed: false,
+                uniqueTarget: !!obj.uniqueTarget,
+                seenTargets: []
             });
         }
 
@@ -113,7 +115,28 @@ var QuestSystem = (function() {
                         continue;
                     }
 
-                    obj.current += (eventData.count || 1);
+                    if (obj.uniqueTarget) {
+                        if (!eventData || !eventData.uniqueKey) {
+                            continue;
+                        }
+                        if (!obj.seenTargets) {
+                            obj.seenTargets = [];
+                        }
+                        var alreadySeen = false;
+                        for (var st = 0; st < obj.seenTargets.length; st++) {
+                            if (obj.seenTargets[st] === eventData.uniqueKey) {
+                                alreadySeen = true;
+                                break;
+                            }
+                        }
+                        if (alreadySeen) {
+                            continue;
+                        }
+                        obj.seenTargets.push(eventData.uniqueKey);
+                        obj.current = obj.seenTargets.length;
+                    } else {
+                        obj.current += (eventData.count || 1);
+                    }
                     if (obj.current >= obj.required) {
                         obj.current = obj.required;
                         obj.completed = true;

app/js/engine/state-engine.js

@@ -597,7 +597,7 @@ var StateEngine = (function() {
 
         if (typeof QuestSystem !== 'undefined' && data.zone && data.zone !== previousZone) {
             _ensureQuests(sender);
-            QuestSystem.updateQuestProgress(worldState.quests[sender], 'explore', { target: data.zone, count: 1 });
+            QuestSystem.updateQuestProgress(worldState.quests[sender], 'explore', { target: data.zone, uniqueKey: data.zone, count: 1 });
         }
 
         return [{
@@ -631,7 +631,7 @@ var StateEngine = (function() {
         });
 
         if (typeof QuestSystem !== 'undefined' && worldState.quests && worldState.quests[award.initiator]) {
-            QuestSystem.updateQuestProgress(worldState.quests[award.initiator], 'social', { target: 'blessing', count: 1 });
+            QuestSystem.updateQuestProgress(worldState.quests[award.initiator], 'social', { target: 'blessing', uniqueKey: award.receiver, count: 1 });
         }
     }
 

app/js/i18n/en.js

@@ -119,6 +119,8 @@ var LangEN = {
     char_intellect: 'Intellect',
     char_fortune: 'Fortune',
     char_core: 'Magic Core',
+        char_stats_growth_hint: 'Stats grow from level, Core power, equipment, enchantments, and rare trophies. To improve one specific stat, find or craft items with that stat in the bag and workshop.',
+        char_stats_growth_hint: 'Stats grow from level, Core power, equipment, enchantments, and rare trophies. To improve one specific stat, find or craft items with that stat in the bag and workshop.',
     char_core_power: 'Core Power',
     char_core_per_stat: 'Core Power / 5: +{value} to each main stat',
     char_mana_regen: 'Mana Regeneration',
@@ -145,7 +147,8 @@ var LangEN = {
     hunt_choose_creature: 'Choose your prey',
     hunt_no_creatures_here: 'There are currently no huntable creatures in this location.',
     hunt_no_creatures_hint: 'Open the map and return to The Commons of First Light, or wait until creatures appear in this region.',
-    hunt_return_to_commons: 'Return to First Light',
+    hunt_return_to_commons: 'Return to Commons of First Light',
+    hunt_returned_to_commons: 'You returned to the Commons of First Light. Hunt is available again.',
     hunt_choose_spell: 'Choose a spell',
     hunt_attack: 'Attack',
     hunt_victory: 'Victory!',
@@ -165,8 +168,8 @@ var LangEN = {
     hunt_mana_cost: 'Costs {cost} Mana',
     hunt_not_enough_mana: 'Not enough Mana. Wait for regeneration.',
     hunt_armageddon_title: 'Armageddon',
-    hunt_armageddon_desc: 'Consume 100% Mana for 100x XP. Requires Armageddon Stone artifact.',
-    hunt_armageddon_no_stone: 'You need an Armageddon Stone to use this ability.',
+    hunt_armageddon_desc: 'Consume 100% Mana for 100x XP. The Armageddon Stone is consumed on launch.',
+    hunt_armageddon_no_stone: 'Find an Armageddon Stone as a rare Thornvine (Lv5+) drop or craft it at level 10 from Echo Shards, Shadow Shard, and Fire Dust.',
     hunt_armageddon_no_mana: 'Armageddon requires full Mana (100%). Wait for full regeneration.',
     hunt_armageddon_confirm: 'I understand that after using Armageddon I will not be able to play until my Mana fully regenerates (~5 days).',
     hunt_armageddon_launch: 'UNLEASH ARMAGEDDON !!!',
@@ -590,6 +593,7 @@ var LangEN = {
     craft_error_wrong_class: 'Wrong class.',
     craft_error_wrong_location: 'Wrong location.',
     craft_error_not_enough_mana: 'Not enough mana.',
+    craft_required_mana: 'Required: {cost} Mana.',
     craft_error_missing_materials: 'Missing materials.',
     craft_error_unknown: 'Unknown error.',
 
@@ -622,6 +626,8 @@ var LangEN = {
     enchant_select_item_first: 'Select an item first.',
     enchant_consumables: 'Consumables',
     consume_success: 'Item consumed!',
+    consume_success_hp: 'Item consumed: health +{amount} HP. Now {current}/{max} HP.',
+    consume_success_mana: 'Item consumed: Mana +{amount}. Now {current}.',
     consume_error: 'Failed to consume item.',
 
     // Enchantment types

app/js/i18n/ru.js

@@ -119,6 +119,7 @@ var LangRU = {
     char_intellect: 'Дух',
     char_fortune: 'Удача',
     char_core: 'Магическое Ядро',
+    char_stats_growth_hint: 'Характеристики растут от уровня, Ядра, экипировки, зачарований и редких трофеев. Если хочешь усилить конкретную черту, ищи или создавай предметы с этой характеристикой в сумке и мастерской.',
     char_core_power: 'Сила Ядра',
     char_core_per_stat: 'Сила Ядра / 5: +{value} к каждому основному стату',
     char_mana_regen: 'Регенерация Маны',
@@ -146,6 +147,7 @@ var LangRU = {
     hunt_no_creatures_here: 'В этой локации сейчас нет доступной добычи для охоты.',
     hunt_no_creatures_hint: 'Откройте карту и вернитесь в The Commons of First Light или дождитесь появления существ в этом регионе.',
     hunt_return_to_commons: 'Вернуться в First Light',
+    hunt_returned_to_commons: 'Вы вернулись в Общины Первого Света. Охота снова доступна.',
     hunt_choose_spell: 'Выбери заклинание',
     hunt_attack: 'Атаковать',
     hunt_victory: 'Победа!',
@@ -165,8 +167,8 @@ var LangRU = {
     hunt_mana_cost: 'Стоит {cost} маны',
     hunt_not_enough_mana: 'Маны мало. Подожди восстановления.',
     hunt_armageddon_title: 'Армагеддон',
-    hunt_armageddon_desc: 'Потратить 100% маны для получения 100x XP. Требует артефакт Камень Армагеддона.',
-    hunt_armageddon_no_stone: 'Для этого нужен Камень Армагеддона.',
+    hunt_armageddon_desc: 'Потратить 100% маны для получения 100x XP. Камень Армагеддона расходуется при запуске.',
+    hunt_armageddon_no_stone: 'Камень Армагеддона можно получить редким дропом с Thornvine (Lv5+) или создать в Мастерской на 10 уровне из Echo Shards, Shadow Shard и Fire Dust.',
     hunt_armageddon_no_mana: 'Армагеддон требует полной маны (100%). Подождите полного восстановления.',
     hunt_armageddon_confirm: 'Я понимаю, что после запуска Армагеддона не смогу играть, пока мана не восстановится полностью (~5 дней).',
     hunt_armageddon_launch: 'UNLEASH ARMAGEDDON !!!',
@@ -590,6 +592,7 @@ var LangRU = {
     craft_error_wrong_class: 'Неподходящий класс.',
     craft_error_wrong_location: 'Нужно быть в другом месте.',
     craft_error_not_enough_mana: 'Мало маны.',
+    craft_required_mana: 'Нужно: {cost} маны.',
     craft_error_missing_materials: 'Не хватает материалов.',
     craft_error_unknown: 'Неизвестная ошибка.',
 
@@ -622,6 +625,8 @@ var LangRU = {
     enchant_select_item_first: 'Сначала выберите предмет.',
     enchant_consumables: 'Расходники',
     consume_success: 'Предмет использован!',
+    consume_success_hp: 'Предмет использован: здоровье +{amount} HP. Сейчас {current}/{max} HP.',
+    consume_success_mana: 'Предмет использован: мана +{amount}. Сейчас {current}.',
     consume_error: 'Не удалось использовать предмет.',
 
     // Enchantment types

app/js/ui/app.js

@@ -51,7 +51,7 @@ var App = (function() {
         VizConnection.init(function(err) {
             if (err) {
                 console.log('Connection failed, working offline');
-                Toast.info(Helpers.t('conn_disconnected'));
+                Toast.info(Helpers.t('conn_disconnected'), 4000, { key: 'conn_disconnected' });
             } else {
                 console.log('Connected to VIZ network');
                 _checkHistoryCapabilityNotice();
@@ -128,7 +128,7 @@ var App = (function() {
             Toast.success(Helpers.t('conn_connected'));
         });
         VizConnection.onDisconnect(function() {
-            Toast.info(Helpers.t('conn_disconnected'));
+            Toast.info(Helpers.t('conn_disconnected'), 4000, { key: 'conn_disconnected' });
         });
 
         // Register PWA install
@@ -322,7 +322,7 @@ var App = (function() {
             if (err || !capability || capability.historicalBlocks) return;
             console.log('App: Selected VIZ node has limited history; archive mirror may be needed for old recovery');
             if (capability.recentBlocks && typeof Toast !== 'undefined') {
-                Toast.info(Helpers.t('conn_history_limited'));
+                Toast.info(Helpers.t('conn_history_limited'), 4000, { key: 'conn_history_limited' });
             }
         });
     }

app/js/ui/components/toast.js

@@ -5,6 +5,7 @@ var Toast = (function() {
     'use strict';
 
     var container = null;
+    var activeKeys = {};
 
     function _getContainer() {
         if (!container) {
@@ -28,8 +29,16 @@ var Toast = (function() {
         duration = duration || 3000;
         options = options || {};
 
+        if (options.key && activeKeys[options.key] && activeKeys[options.key].parentNode) {
+            return activeKeys[options.key];
+        }
+
         var toast = document.createElement('div');
         toast.className = 'toast toast-' + type;
+        if (options.key) {
+            toast.setAttribute('data-toast-key', options.key);
+            activeKeys[options.key] = toast;
+        }
         toast.textContent = message;
         toast.setAttribute('role', 'alert');
 
@@ -67,6 +76,9 @@ var Toast = (function() {
             toast.classList.remove('show');
             setTimeout(function() {
                 if (toast.parentNode) toast.parentNode.removeChild(toast);
+                if (options.key && activeKeys[options.key] === toast) {
+                    delete activeKeys[options.key];
+                }
             }, 300);
         }, duration);
     }

app/js/ui/screens/character.js

@@ -38,6 +38,7 @@ var CharacterScreen = (function() {
                     _statRow(t('char_intellect'), totalInt) +
                     _statRow(t('char_fortune'), totalFor) +
                 '</div>' +
+                '<p class="quest-desc">' + t('char_stats_growth_hint') + '</p>' +
                 '<h2>' + t('char_core') + '</h2>' +
                 '<p>' + t('char_core_power') + ': ' + Helpers.formatNumber(ch.coreBonus) + '</p>' +
                 '<p>' + t('char_core_per_stat', { value: corePerStat }) + '</p>' +

app/js/ui/screens/chronicle.js

@@ -11,6 +11,7 @@ var ChronicleScreen = (function() {
     var BLESS_MEMO_PREFIX = 'viz://vm/bless/';
     var currentTab = 'all'; // all, guild, friends, world
     var REQUIRED_TAG = '#viz_magic';
+    var cachedFeedHtml = {};
 
     function render() {
         var t = Helpers.t;
@@ -110,7 +111,12 @@ var ChronicleScreen = (function() {
         var feed = Helpers.$('chronicle-feed');
         if (!feed) return;
 
-        feed.innerHTML = '<p class="empty-state">' + Helpers.t('loading') + '</p>';
+        if (cachedFeedHtml[currentTab]) {
+            feed.innerHTML = cachedFeedHtml[currentTab];
+            _bindBlessButtons(feed);
+        } else {
+            feed.innerHTML = '<p class="empty-state">' + Helpers.t('loading') + '</p>';
+        }
 
         var state = StateEngine.getState();
         var entries = _collectPostEntries(state);
@@ -269,6 +275,7 @@ var ChronicleScreen = (function() {
         if (entries.length === 0) {
             feed.innerHTML = '<p class="empty-state">' + Helpers.t('chronicle_empty') + '</p>' +
                 '<p class="chronicle-hint">' + Helpers.t('chronicle_bless_posts_only_hint') + '</p>';
+            cachedFeedHtml[currentTab] = feed.innerHTML;
             return;
         }
 
@@ -280,7 +287,11 @@ var ChronicleScreen = (function() {
             html += _renderEntry(entries[k]);
         }
         feed.innerHTML = html;
+        cachedFeedHtml[currentTab] = html;
+        _bindBlessButtons(feed);
+    }
 
+    function _bindBlessButtons(feed) {
         var blessBtns = feed.querySelectorAll('.bless-button');
         for (var m = 0; m < blessBtns.length; m++) {
             blessBtns[m].addEventListener('click', _onBless);
@@ -314,6 +325,23 @@ var ChronicleScreen = (function() {
         });
     }
 
+    function _injectLocalBlessing(account, energy) {
+        var state = StateEngine.getState();
+        var user = VizAccount.getCurrentUser();
+        if (!state || !user || !account) return;
+        state.recentActions.push({
+            type: 'blessing_sent',
+            sender: user,
+            receiver: account,
+            blockNum: (state.headBlock || 0) + 1,
+            timestamp: Date.now(),
+            energy: energy || BLESS_ENERGY_LOW,
+            memo: BLESS_MEMO_PREFIX + account,
+            events: []
+        });
+        cachedFeedHtml = {};
+    }
+
     function _renderEntry(entry) {
         var t = Helpers.t;
         var charInfo = StateEngine.getCharacter(entry.account);
@@ -365,8 +393,10 @@ var ChronicleScreen = (function() {
             if (err) {
                 Toast.error(Helpers.t('error_low_mana'));
             } else {
+                _injectLocalBlessing(account, energy);
                 Toast.success('\u2728 ' + Helpers.t('chronicle_blessed'));
                 SoundManager.play('bless_recv');
+                _loadFeed();
             }
         });
     }

app/js/ui/screens/crafting.js

@@ -116,7 +116,11 @@ var CraftingScreen = (function() {
             html += '<span class="recipe-ready">' + t('craft_ready') + '</span>';
         } else {
             var errorKey = 'craft_error_' + (recipeInfo.error || 'unknown');
-            html += '<span class="recipe-locked-text">' + t(errorKey) + '</span>';
+            var errorText = t(errorKey);
+            if (recipeInfo.error === 'not_enough_mana' && recipe.manaCost) {
+                errorText += ' ' + t('craft_required_mana', { cost: Helpers.bpToPercent(recipe.manaCost) });
+            }
+            html += '<span class="recipe-locked-text">' + errorText + '</span>';
         }
         html += '</div>';
         html += '</div>';
@@ -461,7 +465,12 @@ var CraftingScreen = (function() {
         // Validate
         var validation = CraftingSystem.validateRecipe(selectedRecipe, character, inventory, character.currentZone || '');
         if (!validation.valid) {
-            Toast.error(t('craft_error_' + validation.error));
+            var validationMessage = t('craft_error_' + validation.error);
+            var validationRecipe = GameRecipes.getRecipe(selectedRecipe);
+            if (validation.error === 'not_enough_mana' && validationRecipe && validationRecipe.manaCost) {
+                validationMessage += ' ' + t('craft_required_mana', { cost: Helpers.bpToPercent(validationRecipe.manaCost) });
+            }
+            Toast.error(validationMessage);
             SoundManager.play('error');
             return;
         }
@@ -630,6 +639,24 @@ var CraftingScreen = (function() {
         });
     }
 
+    function _consumeSuccessMessage(t, result, character) {
+        var effect = result ? result.effect : null;
+        if (effect && effect.type === 'hp_restore') {
+            return t('consume_success_hp', {
+                amount: effect.amount || 0,
+                current: character.hp || 0,
+                max: character.maxHp || 0
+            });
+        }
+        if (effect && effect.type === 'mana_restore') {
+            return t('consume_success_mana', {
+                amount: Helpers.bpToPercent(effect.amount || 0),
+                current: Helpers.bpToPercent(character.mana || 0)
+            });
+        }
+        return t('consume_success');
+    }
+
     /**
      * Execute consume
      */
@@ -654,7 +681,7 @@ var CraftingScreen = (function() {
             } else {
                 var result = EnchantingSystem.consumeItem(item, character);
                 if (result.success) {
-                    Toast.success(t('consume_success'));
+                    Toast.success(_consumeSuccessMessage(t, result, character));
                     SoundManager.play('success');
                     SoundManager.vibrate('light');
                 }