Complete gameplay recovery and QA coverage

Author: web3blind

app/index.html

@@ -118,7 +118,7 @@
     <script src="js/i18n/en.js?v=20260621d"></script>
 
     <!-- Utilities -->
-    <script src="js/utils/helpers.js"></script>
+    <script src="js/utils/helpers.js?v=20260621l"></script>
     <script src="js/utils/crypto.js"></script>
     <script src="js/utils/a11y.js"></script>
 
@@ -153,7 +153,7 @@
     <script src="js/engine/duel-state.js"></script>
     <script src="js/engine/validator.js"></script>
     <script src="js/engine/guild.js?v=20260621d"></script>
-    <script src="js/engine/territory.js"></script>
+    <script src="js/engine/territory.js?v=20260621l"></script>
     <script src="js/engine/crafting.js?v=20260621j"></script>
     <script src="js/engine/enchanting.js"></script>
     <script src="js/engine/marketplace.js"></script>
@@ -164,7 +164,7 @@
     <script src="js/engine/quest-system.js?v=20260621e"></script>
     <script src="js/engine/loci.js"></script>
     <script src="js/engine/npc-framework.js"></script>
-    <script src="js/engine/state-engine.js?v=20260621k"></script>
+    <script src="js/engine/state-engine.js?v=20260621l"></script>
     <script src="js/engine/daily-leaderboard-storage.js"></script>
     <script src="js/engine/daily-leaderboard.js"></script>
 
@@ -181,13 +181,13 @@
     <script src="js/ui/screens/login.js"></script>
     <script src="js/ui/screens/onboarding.js"></script>
     <script src="js/ui/screens/home.js"></script>
-    <script src="js/ui/screens/character.js"></script>
+    <script src="js/ui/screens/character.js?v=20260621l"></script>
     <script src="js/ui/screens/hunt.js"></script>
-    <script src="js/ui/screens/inventory.js"></script>
+    <script src="js/ui/screens/inventory.js?v=20260621l"></script>
     <script src="js/ui/screens/chronicle.js?v=20260621h"></script>
     <script src="js/ui/screens/duel.js"></script>
     <script src="js/ui/screens/arena.js?v=20260621d"></script>
-    <script src="js/ui/screens/guild.js?v=20260621d"></script>
+    <script src="js/ui/screens/guild.js?v=20260621l"></script>
     <script src="js/ui/screens/map.js?v=20260621h"></script>
     <script src="js/ui/screens/marketplace.js?v=20260621k"></script>
     <script src="js/ui/screens/crafting.js?v=20260621j"></script>

app/js/engine/state-engine.js

@@ -37,6 +37,30 @@ var StateEngine = (function() {
         };
     }
 
+    function _normalizeWorldState(state) {
+        var empty = _createEmptyState();
+        if (!state || typeof state !== 'object') return empty;
+        for (var key in empty) {
+            if (empty.hasOwnProperty(key) && typeof state[key] === 'undefined') {
+                state[key] = empty[key];
+            }
+        }
+        if (typeof state.headBlock !== 'number' || isNaN(state.headBlock) || state.headBlock < 0) state.headBlock = 0;
+        if (typeof state.checkpointBlock !== 'number' || isNaN(state.checkpointBlock) || state.checkpointBlock < 0) state.checkpointBlock = state.headBlock || 0;
+        state.characters = state.characters || {};
+        state.inventories = state.inventories || {};
+        state.guilds = state.guilds || {};
+        state.territories = state.territories || {};
+        state.recentActions = state.recentActions || [];
+        state.social = state.social || { knownAccounts: [] };
+        state.social.knownAccounts = state.social.knownAccounts || [];
+        state.guildListings = state.guildListings || [];
+        state.quests = state.quests || {};
+        state.loci = state.loci || {};
+        state.activeEvents = state.activeEvents || [];
+        return state;
+    }
+
     /**
      * Initialize the state engine.
      * Tries to load from checkpoint, otherwise starts fresh.
@@ -52,7 +76,7 @@ var StateEngine = (function() {
 
             CheckpointSystem.loadLatestCheckpoint('global', function(err, checkpoint) {
                 if (checkpoint && checkpoint.state) {
-                    worldState = checkpoint.state;
+                    worldState = _normalizeWorldState(checkpoint.state);
                     console.log('StateEngine: Loaded checkpoint at block', worldState.headBlock);
                 } else {
                     console.log('StateEngine: No checkpoint found, starting fresh');

app/js/engine/territory.js

@@ -238,6 +238,12 @@ var TerritorySystem = (function() {
                     siege.state = SIEGE_STATE.FAILED;
                     result = { winner: 'defender', siege: siege };
                 }
+                // A siege resolution is itself a territory-control decision.
+                // Prevent the periodic delegation recalculation in the same
+                // block from immediately overwriting the resolved controller,
+                // especially for fixture/early territories that have no
+                // delegation rows yet.
+                territory.lastRecalcBlock = blockNum;
                 return result;
             }
         }

app/js/ui/screens/character.js

@@ -12,6 +12,8 @@ var CharacterScreen = (function() {
         var user = VizAccount.getCurrentUser();
         var ch = StateEngine.getCharacter(user);
         if (!ch) { ch = { name: user || 'Unknown', className: 'embercaster', level: 1, pot: 10, res: 6, swf: 8, int: 7, for_: 5, coreBonus: 0, spells: ['firebolt'], maxHp: 100, hp: 100 }; }
+        ch.coreBonus = ch.coreBonus || 0;
+        ch.spells = ch.spells || [];
 
         var corePerStat = Math.floor((ch.coreBonus || 0) / 5);
         var totalPot = (typeof CharacterSystem !== 'undefined' && CharacterSystem.getTotalStat) ? CharacterSystem.getTotalStat(ch, 'pot') : ((ch.pot || 0) + corePerStat);

app/js/ui/screens/guild.js

@@ -746,7 +746,7 @@ var GuildScreen = (function() {
             html += '<div class="active-key-status active-key-missing">';
             html += '<p class="active-key-notice">' + t('guild_active_key_needed') + '</p>';
             html += '<label class="input-label" for="input-active-key">' + t('guild_active_key_label') + '</label>';
-            html += '<input type="password" class="input-field" id="input-active-key" placeholder="5J..." autocomplete="off">';
+            html += '<input type="password" class="input-field" id="input-active-key" placeholder="5J..." autocomplete="off" aria-label="' + t('guild_active_key_label') + '">';
             html += '<button class="btn btn-primary btn-sm" id="btn-save-active-key">' + t('guild_active_key_save') + '</button>';
             html += '</div>';
         }

app/js/ui/screens/inventory.js

@@ -91,7 +91,7 @@ var InventoryScreen = (function() {
 
         html += '<div class="settings-field settings-toggle">';
         html += '<label for="inv-compact" class="settings-toggle-label">' + t('inv_compact_mode') + '</label>';
-        html += '<button id="inv-compact" class="settings-toggle-btn' + (compact ? ' active' : '') + '" role="switch" aria-checked="' + compact + '">';
+        html += '<button id="inv-compact" class="settings-toggle-btn' + (compact ? ' active' : '') + '" role="switch" aria-checked="' + compact + '" aria-label="' + Helpers.escapeHtml(t('inv_compact_mode')) + '">';
         html += '<span class="toggle-knob"></span>';
         html += '</button>';
         html += '</div>';

app/js/utils/helpers.js

@@ -144,6 +144,7 @@ var Helpers = (function() {
      * @returns {string}
      */
     function formatNumber(num) {
+        if (num === null || typeof num === 'undefined' || isNaN(num)) num = 0;
         return num.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ',');
     }
 

app/sw.js

@@ -1,5 +1,5 @@
 // Viz Magic — Service Worker
-var CACHE_NAME = 'viz-magic-v24';
+var CACHE_NAME = 'viz-magic-v25';
 var ASSETS = [
     '/',
     '/index.html',

plan.md

@@ -307,7 +307,7 @@ Acceptance criteria:
 
 ## Remaining work item 5 — Archive Mirror / PM2 health
 
-Status: production endpoint works; SQLite data size was around 9 MB in the last check. PM2 RAM was not rechecked in the final attempt because aaPanel cron PATH did not expose `pm2`/`node`.
+Status: completed in the 2026-06-21 08:03 UTC pass. aaPanel one-shot health check resolved the Node/PM2 path, showed `vizmagic-game-archive` online at ~37 MB RSS and `vizmagic-game-archive-indexer` online at ~70 MB RSS, and archive data size around 10 MB. Public `/archive-mirror/health`, `/archive-mirror/v1/guilds`, and `/archive-mirror/v1/range?...` were responsive. `/archive-mirror/v1/health` returns 404 on this Nginx mapping, while `/archive-mirror/health` is the live health path.
 
 Goal: confirm Archive Mirror process RAM stays below the target ~200 MB and endpoints remain responsive.
 
@@ -339,7 +339,7 @@ Acceptance criteria:
 
 ## Remaining work item 6 — Mobile accessibility / TalkBack QA
 
-Status: needs focused pass.
+Status: completed in the 2026-06-21 08:03 UTC pass with `tests/core-screen-accessibility-smoke.test.js` and `node /tmp/vizmagic_screen_smoke.js`. All core screens rendered with visible text, no blank controls, no raw internal keys, and latest cache-busted scripts. High-impact fixes added: missing numeric fallback in `Helpers.formatNumber`, character fallback defaults for `coreBonus`/`spells`, accessible names for Inventory compact switch and Guild active-key input.
 
 Goal: ensure core screens are practical for Denis with TalkBack.
 
@@ -375,7 +375,7 @@ Acceptance criteria:
 
 ## Remaining work item 7 — World Boss / Territory / Siege
 
-Status: deep mechanics not fully covered.
+Status: local fixture/replay smoke completed in the 2026-06-21 08:03 UTC pass. No disruptive live-chain war/siege/boss broadcast was made. `tests/world-boss-territory-siege-smoke.test.js` verifies replay of guild create, siege declare/commit, boss attack, and territory claim; it also caught and fixed same-block territory recalculation overwriting a siege winner.
 
 Goal: verify these screens do not break, and distinguish smoke from full gameplay coverage.
 
@@ -433,14 +433,16 @@ Suggested prompt for a new Hermes session:
 
 ## Completion ledger
 
+Last updated: 2026-06-21 08:03 UTC.
+
 Mark items here as the next session completes them:
 
 - [x] Crafting E2E — local fixture + regression coverage; live-chain broadcast intentionally not spent
-- [ ] Marketplace E2E
-- [ ] Two-browser Guild smoke
-- [ ] Two-browser Arena smoke
-- [ ] Checkpoint recovery matrix
-- [ ] Archive Mirror / PM2 RAM health
-- [ ] Mobile accessibility / TalkBack QA
-- [ ] World Boss / Territory / Siege smoke
-- [ ] Economy / item consistency audit
+- [x] Marketplace E2E — state-engine authoritative list/cancel/buy, checkpoint on live action, replay transfer without duplication
+- [x] Two-browser Guild smoke — isolated-browser replay fixture confirms invite/member state on Browser B
+- [x] Two-browser Arena smoke — isolated-browser replay fixture confirms challenge visibility and accepted active duel state on Browser B
+- [x] Checkpoint recovery matrix — fresh/recent/old partial IndexedDB checkpoints normalize to the current schema without hanging
+- [x] Archive Mirror / PM2 RAM health — production archive endpoints responsive; PM2 archive API/indexer online under ~200 MB RSS
+- [x] Mobile accessibility / TalkBack QA — core screen smoke covers names/raw keys/blank controls; high-impact blockers fixed
+- [x] World Boss / Territory / Siege smoke — local replay fixture covers boss attack, siege lifecycle, and territory claim without live-chain mutation
+- [x] Economy / item consistency audit — catalog/loot/recipe/material coverage regression remains passing in `tests/player-bug-regressions.test.js`

tests/accessibility-regressions.test.js

@@ -29,6 +29,10 @@ const onboardingJs = read('app/js/ui/screens/onboarding.js');
 const settingsJs = read('app/js/ui/screens/settings.js');
 const accessibilityCss = read('app/css/accessibility.css');
 const mainCss = read('app/css/main.css');
+const helpersJs = read('app/js/utils/helpers.js');
+const characterJs = read('app/js/ui/screens/character.js');
+const inventoryJs = read('app/js/ui/screens/inventory.js');
+const guildJs = read('app/js/ui/screens/guild.js');
 
 test('manifest does not lock orientation', function () {
   assert.ok(!Object.prototype.hasOwnProperty.call(manifest, 'orientation'), 'orientation lock should be removed');
@@ -77,6 +81,14 @@ test('skip link styles are present', function () {
   assert.ok(/\.skip-link/.test(mainCss), 'skip-link CSS missing');
 });
 
+test('core screen fallbacks avoid blank controls and fixture crashes', function () {
+  assert.ok(/typeof num === 'undefined'/.test(helpersJs), 'formatNumber should tolerate missing numeric values');
+  assert.ok(/ch\.coreBonus = ch\.coreBonus \|\| 0/.test(characterJs), 'character screen should default missing coreBonus');
+  assert.ok(/ch\.spells = ch\.spells \|\| \[\]/.test(characterJs), 'character screen should default missing spells');
+  assert.ok(/id="inv-compact"[\s\S]*aria-label=/.test(inventoryJs), 'inventory compact switch needs an accessible name');
+  assert.ok(/id="input-active-key"[\s\S]*aria-label=/.test(guildJs), 'guild active key input needs an accessible name for TalkBack');
+});
+
 if (process.exitCode) {
   process.exit(process.exitCode);
 }