Persist marketplace state for checkpoints

Author: web3blind

app/index.html

@@ -137,7 +137,7 @@
     <script src="js/protocols/market-protocol.js"></script>
 
     <!-- Game data -->
-    <script src="js/data/creatures.js?v=20260621i"></script>
+    <script src="js/data/creatures.js?v=20260621j"></script>
     <script src="js/data/spells.js"></script>
     <script src="js/data/recipes.js"></script>
     <script src="js/data/regions.js"></script>
@@ -154,7 +154,7 @@
     <script src="js/engine/validator.js"></script>
     <script src="js/engine/guild.js?v=20260621d"></script>
     <script src="js/engine/territory.js"></script>
-    <script src="js/engine/crafting.js?v=20260621i"></script>
+    <script src="js/engine/crafting.js?v=20260621j"></script>
     <script src="js/engine/enchanting.js"></script>
     <script src="js/engine/marketplace.js"></script>
     <script src="js/engine/checkpoint.js"></script>
@@ -164,7 +164,7 @@
     <script src="js/engine/quest-system.js?v=20260621e"></script>
     <script src="js/engine/loci.js"></script>
     <script src="js/engine/npc-framework.js"></script>
-    <script src="js/engine/state-engine.js?v=20260621i"></script>
+    <script src="js/engine/state-engine.js?v=20260621j"></script>
     <script src="js/engine/daily-leaderboard-storage.js"></script>
     <script src="js/engine/daily-leaderboard.js"></script>
 
@@ -190,7 +190,7 @@
     <script src="js/ui/screens/guild.js?v=20260621d"></script>
     <script src="js/ui/screens/map.js?v=20260621h"></script>
     <script src="js/ui/screens/marketplace.js"></script>
-    <script src="js/ui/screens/crafting.js?v=20260621i"></script>
+    <script src="js/ui/screens/crafting.js?v=20260621j"></script>
     <script src="js/ui/screens/quests.js?v=20260621e"></script>
     <script src="js/ui/screens/world-boss.js"></script>
     <script src="js/ui/screens/settings.js"></script>

app/js/engine/state-engine.js

@@ -142,8 +142,10 @@ var StateEngine = (function() {
         }
 
         // Expire marketplace listings
+        _ensureMarketplace();
         if (typeof MarketplaceEngine !== 'undefined') {
             MarketplaceEngine.expireListings(blockNum);
+            _syncMarketplaceState();
         }
 
         // Register crafted item templates if needed
@@ -903,6 +905,8 @@ var StateEngine = (function() {
             return [];
         }
 
+        _syncMarketplaceState();
+
         return [{
             type: 'market_listed',
             account: sender,
@@ -922,6 +926,8 @@ var StateEngine = (function() {
             return [];
         }
 
+        _syncMarketplaceState();
+
         return [{
             type: 'market_cancelled',
             account: sender,
@@ -938,6 +944,8 @@ var StateEngine = (function() {
             return [];
         }
 
+        _syncMarketplaceState();
+
         return [{
             type: 'market_sold',
             buyer: sender,
@@ -970,19 +978,24 @@ var StateEngine = (function() {
      * Ensure marketplace state is initialized
      */
     function _ensureMarketplace() {
-        if (!worldState.marketplace) {
-            worldState.marketplace = {};
+        if (!worldState.marketplace || !worldState.marketplace.listings) {
+            worldState.marketplace = {
+                listings: {},
+                history: [],
+                priceHistory: {}
+            };
         }
         if (typeof MarketplaceEngine !== 'undefined') {
-            // Sync marketplace state from world state if needed
-            var mState = MarketplaceEngine.getMarketState();
-            if (!mState.listings) {
-                MarketplaceEngine.setMarketState({
-                    listings: {},
-                    history: [],
-                    priceHistory: {}
-                });
-            }
+            // Keep the replay/checkpoint world state and the marketplace module
+            // on the same object so listings survive save/load and buy/cancel
+            // handlers do not mutate a detached in-memory marketplace.
+            MarketplaceEngine.setMarketState(worldState.marketplace);
+        }
+    }
+
+    function _syncMarketplaceState() {
+        if (typeof MarketplaceEngine !== 'undefined') {
+            worldState.marketplace = MarketplaceEngine.getMarketState();
         }
     }
 

app/sw.js

@@ -1,5 +1,5 @@
 // Viz Magic — Service Worker
-var CACHE_NAME = 'viz-magic-v22';
+var CACHE_NAME = 'viz-magic-v23';
 var ASSETS = [
     '/',
     '/index.html',

tests/player-bug-regressions.test.js

@@ -116,6 +116,16 @@ test('crafting replay consumes the selected material ids only once', function ()
   assert.ok(/CraftingSystem\.craftWithMaterialIds/.test(stateEngineJs), 'state-engine craft replay should use exact material ids');
 });
 
+test('marketplace state is mirrored into world state for checkpoints', function () {
+  const stateEngine = read('app/js/engine/state-engine.js');
+  assert.ok(/function _syncMarketplaceState\(\)/.test(stateEngine), 'state engine should expose marketplace checkpoint sync helper');
+  assert.ok(/MarketplaceEngine\.setMarketState\(worldState\.marketplace\)/.test(stateEngine), 'marketplace engine should replay from checkpoint world state');
+  assert.ok(/worldState\.marketplace = MarketplaceEngine\.getMarketState\(\)/.test(stateEngine), 'marketplace mutations should be mirrored back into world state');
+  assert.ok(/_handleMarketList[\s\S]*_syncMarketplaceState\(\)/.test(stateEngine), 'market list should sync after successful mutation');
+  assert.ok(/_handleMarketCancel[\s\S]*_syncMarketplaceState\(\)/.test(stateEngine), 'market cancel should sync after successful mutation');
+  assert.ok(/_handleMarketBuy[\s\S]*_syncMarketplaceState\(\)/.test(stateEngine), 'market buy should sync after successful mutation');
+});
+
 test('crafting recipes have templates and obtainable materials', function () {
   const context = { console, VizMagicConfig: { RARITY: { COMMON: 0, UNCOMMON: 1, RARE: 2, EPIC: 3, LEGENDARY: 4 } } };
   vm.createContext(context);
@@ -229,7 +239,7 @@ test('high-traffic UI narration and inventory stat labels are translated', funct
 
 test('service worker updates quickly and keeps navigations network-first', function () {
   const swJs = read('app/sw.js');
-  assert.ok(/viz-magic-v22/.test(swJs), 'service worker cache version should be bumped');
+  assert.ok(/viz-magic-v23/.test(swJs), 'service worker cache version should be bumped');
   assert.ok(/self\.skipWaiting\(\)/.test(swJs), 'service worker should activate new cache without waiting for all tabs to close');
   assert.ok(/self\.clients\.claim\(\)/.test(swJs), 'service worker should claim clients after activation');
   assert.ok(/event\.request\.mode === 'navigate'[\s\S]*fetch\(event\.request\)/.test(swJs), 'navigation requests should prefer network to avoid stale cached index');