Fix archive guild browser hydration

Author: web3blind

app/index.html

@@ -111,11 +111,11 @@
     <script src="lib/viz.min.js"></script>
 
     <!-- Config -->
-    <script src="js/config.js?v=20260620c"></script>
+    <script src="js/config.js?v=20260621a"></script>
 
     <!-- I18n -->
-    <script src="js/i18n/ru.js?v=20260620c"></script>
-    <script src="js/i18n/en.js?v=20260620c"></script>
+    <script src="js/i18n/ru.js?v=20260621a"></script>
+    <script src="js/i18n/en.js?v=20260621a"></script>
 
     <!-- Utilities -->
     <script src="js/utils/helpers.js"></script>
@@ -125,7 +125,7 @@
     <!-- Blockchain layer -->
     <script src="js/blockchain/connection.js"></script>
     <script src="js/blockchain/account.js"></script>
-    <script src="js/blockchain/history-source.js?v=20260620c"></script>
+    <script src="js/blockchain/history-source.js?v=20260621a"></script>
     <script src="js/blockchain/broadcast.js"></script>
     <script src="js/blockchain/invite.js"></script>
 
@@ -152,7 +152,7 @@
     <script src="js/engine/duel.js"></script>
     <script src="js/engine/duel-state.js"></script>
     <script src="js/engine/validator.js"></script>
-    <script src="js/engine/guild.js"></script>
+    <script src="js/engine/guild.js?v=20260621a"></script>
     <script src="js/engine/territory.js"></script>
     <script src="js/engine/crafting.js"></script>
     <script src="js/engine/enchanting.js"></script>
@@ -187,7 +187,7 @@
     <script src="js/ui/screens/chronicle.js"></script>
     <script src="js/ui/screens/duel.js"></script>
     <script src="js/ui/screens/arena.js"></script>
-    <script src="js/ui/screens/guild.js?v=20260620c"></script>
+    <script src="js/ui/screens/guild.js?v=20260621a"></script>
     <script src="js/ui/screens/map.js"></script>
     <script src="js/ui/screens/marketplace.js"></script>
     <script src="js/ui/screens/crafting.js"></script>

app/js/engine/guild.js

@@ -342,6 +342,7 @@ var GuildSystem = (function() {
      */
     function checkWarExpiry(guild, blockNum) {
         if (!guild) return;
+        if (!guild.wars) guild.wars = [];
         for (var i = 0; i < guild.wars.length; i++) {
             var war = guild.wars[i];
             if (war.state === WAR_STATE.ACTIVE && blockNum >= war.endBlock) {

app/js/ui/screens/guild.js

@@ -323,13 +323,15 @@ var GuildScreen = (function() {
         for (var i = 0; i < guilds.length; i++) {
             var guild = guilds[i];
             if (!guild || !guild.id) continue;
+            _normalizeGuild(guild);
             if (!state.guilds[guild.id] || state.guilds[guild.id].isPlaceholder) {
                 state.guilds[guild.id] = guild;
                 changed = true;
             }
         }
         for (var gid in guildMap) {
             if (!guildMap.hasOwnProperty(gid)) continue;
+            _normalizeGuild(guildMap[gid]);
             if (!state.guilds[gid] || state.guilds[gid].isPlaceholder) {
                 state.guilds[gid] = guildMap[gid];
                 changed = true;
@@ -366,7 +368,7 @@ var GuildScreen = (function() {
                 if (err || !directory) return;
                 if (_mergeArchiveGuildDirectory(StateEngine.getState(), directory)) {
                     var container = Helpers.$('screen-guild');
-                    if (container && !container.getAttribute('aria-hidden')) render();
+                    if (_isScreenVisible(container)) render();
                 }
             });
         }
@@ -405,7 +407,7 @@ var GuildScreen = (function() {
                                         currentState.guilds[guildId] = guild;
                                         // Re-render if guild screen is active
                                         var container = Helpers.$('screen-guild');
-                                        if (container && !container.getAttribute('aria-hidden')) {
+                                        if (_isScreenVisible(container)) {
                                             render();
                                         }
                                     }
@@ -427,6 +429,7 @@ var GuildScreen = (function() {
         if (!state.guilds) return list;
         for (var gid in state.guilds) {
             if (state.guilds.hasOwnProperty(gid)) {
+                _normalizeGuild(state.guilds[gid]);
                 list.push(state.guilds[gid]);
             }
         }
@@ -438,6 +441,27 @@ var GuildScreen = (function() {
         return list;
     }
 
+    function _normalizeGuild(guild) {
+        if (!guild) return guild;
+        guild.charter = guild.charter || {};
+        if (!guild.charter.membership) guild.charter.membership = 'open';
+        if (typeof guild.charter.tithe_pct !== 'number') guild.charter.tithe_pct = 1000;
+        if (typeof guild.charter.min_shares !== 'number') guild.charter.min_shares = 0;
+        guild.members = guild.members || {};
+        guild.invites = guild.invites || {};
+        guild.wars = guild.wars || [];
+        guild.quests = guild.quests || [];
+        guild.announcements = guild.announcements || [];
+        if (typeof guild.totalDelegated !== 'number') guild.totalDelegated = 0;
+        if (typeof guild.level !== 'number') guild.level = 1;
+        if (typeof guild.xp !== 'number') guild.xp = 0;
+        return guild;
+    }
+
+    function _isScreenVisible(container) {
+        return !!(container && container.getAttribute('aria-hidden') !== 'true');
+    }
+
     /**
      * Bind guild hall events
      */
@@ -920,7 +944,7 @@ var GuildScreen = (function() {
             Helpers.EventBus.on(events[i], function() {
                 // Re-render only if guild screen is currently visible
                 var container = Helpers.$('screen-guild');
-                if (container && !container.getAttribute('aria-hidden')) {
+                if (_isScreenVisible(container)) {
                     render();
                 }
             });

app/sw.js

@@ -1,5 +1,5 @@
 // Viz Magic — Service Worker
-var CACHE_NAME = 'viz-magic-v12';
+var CACHE_NAME = 'viz-magic-v13';
 var ASSETS = [
     '/',
     '/index.html',

tests/player-bug-regressions.test.js

@@ -133,6 +133,15 @@ test('guild joining explains and enforces preparation requirements', function ()
   assert.ok(/character\.level < GUILD_JOIN_MIN_LEVEL/.test(guildJs), 'join handler should guard low-level direct clicks');
 });
 
+test('archive-backed guilds normalize missing optional arrays and rerender visible screen', function () {
+  assert.ok(/function _normalizeGuild/.test(guildJs), 'guild screen should normalize archive guild payloads');
+  assert.ok(/guild\.wars = guild\.wars \|\| \[\]/.test(guildJs), 'archive guilds should get default wars array');
+  assert.ok(/guild\.quests = guild\.quests \|\| \[\]/.test(guildJs), 'archive guilds should get default quests array');
+  assert.ok(/guild\.announcements = guild\.announcements \|\| \[\]/.test(guildJs), 'archive guilds should get default announcements array');
+  assert.ok(/function _isScreenVisible/.test(guildJs), 'guild screen should have an aria-hidden visibility helper');
+  assert.ok(/getAttribute\('aria-hidden'\) !== 'true'/.test(guildJs), 'aria-hidden="false" should count as visible');
+});
+
 test('high-traffic UI narration and inventory stat labels are translated', function () {
   ['char_level_up', 'stat_pot', 'stat_res', 'stat_swf', 'stat_int', 'stat_for', 'duel_narrator_pre', 'duel_narrator_seal', 'duel_narrator_sealed', 'duel_narrator_waiting', 'duel_narrator_reveal'].forEach(function (key) {
     assert.ok(enJs.indexOf(key + ':') !== -1, 'English translation missing: ' + key);