Sitemap.xml builder find hidden root pages

[ecentral-mk]

We are using a multi-domain typo3 6.2.29 system with more then 50 domains. The task "Sitemap.xml builder" also finds hidden rootpages. We used version 2.0.1.

Reason:
The class "getRootPages" in Metaseo\Metaseo\Scheduler\Task\AbstractTask dont ignore hidden pages.

Fix:
Edit this function and add a "AND hidden=0" tho sql query.

/**
 * Scheduler Task Sitemap Base
 */
abstract class AbstractTask extends T3AbstractTask
{
...
    /**
     * Get list of root pages in current typo3
     *
     * @return  array
     */
    protected function getRootPages()
    {
        $query = 'SELECT uid
                    FROM pages
                   WHERE is_siteroot = 1
                     AND deleted = 0';

        return DatabaseUtility::getColWithIndex($query);
    }

[cedricziel]

Fixed in #273

[ecentral-mk]

Thx 👍

[cedricziel]

No problem. Easy pick. Let's hope for a merge.

[thomaszbz]

For the merge, I'll reopen this issue. Will be closed when merge is done.

[thomaszbz]

Scheduler/Task/AbstractTask is only implemented/used by SitemapTxtTask and SitemapXmlTask.

Basically, that means that we use it for generation of sitemaps only. It is never used for editing/showing something in the backend etc.

However, we should still consider hidden root pages for generation of sitemaps because even if a root page is hidden, it could easily happen that non-hidden subpages of the root page are supposed to be indexed and rendered in a sitemap.

In the sitemap, of course, hidden pages should not occur (no matter if root page or normal page).

@ecentral if you want to disable a root page, I recommend to do that in Metaseo's control center:

Basically that means that your use case already is covered by metaseo, and rendering hidden root pages is wanted behaviour, therefore not a bug.

If single hidden pages get rendered in your sitemap's output, please file a new issue (this would also be something different and eventually be a bug).