chore/update code format, remove one place package usage (#845)

Author: potapovDim

.github/dependabot.yml

@@ -8,8 +8,6 @@ updates:
   open-pull-requests-limit: 10
   versioning-strategy: increase-if-necessary
   ignore:
-    - dependency-name: "fs-extra"
-      update-types: ["version-update:semver-major"]
     - dependency-name: "got"
       update-types: ["version-update:semver-major"]
     - dependency-name: "mocha"
@@ -25,14 +23,14 @@ updates:
     - dependency-name: "eslint-plugin-prettier"
       update-types: ["version-update:semver-major"]
     - dependency-name: "eslint"
-      update-types: ["version-update:semver-major"]  
+      update-types: ["version-update:semver-major"]
     - dependency-name: "execa"
-      update-types: ["version-update:semver-major"]  
+      update-types: ["version-update:semver-major"]
     - dependency-name: "find-process"
-      update-types: ["version-update:semver-major"]  
+      update-types: ["version-update:semver-major"]
     - dependency-name: "fkill"
-      update-types: ["version-update:semver-major"]  
+      update-types: ["version-update:semver-major"]
     - dependency-name: "prettier"
-      update-types: ["version-update:semver-major"]  
+      update-types: ["version-update:semver-major"]
+
 
-      

lib/check-paths-existence.js

@@ -1,17 +1,13 @@
-module.exports = checkPathsExistence;
+const fs = require('fs');
 
-const fse = require('fs-extra');
+const checkPathsExistence = (paths) => {
+  const pathValues = Object.values(paths);
 
-async function checkPathsExistence(paths) {
-  const pathValues = Object.keys(paths).map((key) => {
-    return paths[key];
+  pathValues.forEach((path) => {
+    if (!fs.existsSync(path)) {
+      throw new Error('Missing ' + path);
+    }
   });
+};
 
-  return Promise.all(
-    pathValues.map(async (path) => {
-      if (!(await fse.pathExists(path))) {
-        throw new Error('Missing ' + path);
-      }
-    })
-  );
-}
+module.exports = checkPathsExistence;

lib/compute-download-urls.js

@@ -1,5 +1,3 @@
-module.exports = { computeDownloadUrls, resolveDownloadPath, getLastChromedriverVersionFromMajor, getLatestChromium };
-
 const got = require('got');
 const util = require('util');
 const { isSelenium4 } = require('./isSelenium4');
@@ -343,3 +341,5 @@ async function getPackageInfo(version, arh, channel, baseUrl) {
 
   return { latestVersion, url };
 }
+
+module.exports = { computeDownloadUrls, resolveDownloadPath, getLastChromedriverVersionFromMajor, getLatestChromium };

lib/compute-fs-paths.js

@@ -1,13 +1,11 @@
-module.exports = computeFsPaths;
-
 const path = require('path');
 const { getLastChromedriverVersionFromMajor, getLatestChromium } = require('./compute-download-urls');
 const { validateMajorVersionPrefix } = require('./validation');
 const { detectBrowserPlatformCustom } = require('./platformDetection');
 
 const basePath = path.join(__dirname, '..', '.selenium');
 
-async function computeFsPaths(options) {
+const computeFsPaths = async (options) => {
   let fsPaths = {};
   const opts = Object.assign({}, options);
   opts.basePath = opts.basePath || basePath;
@@ -104,4 +102,6 @@ async function computeFsPaths(options) {
   }, fsPaths);
 
   return fsPaths;
-}
+};
+
+module.exports = computeFsPaths;

lib/get-selenium-status-url.js

@@ -7,27 +7,25 @@ const PROCESS_TYPES = {
   GRID_NODE: 2,
   DISTRIBUTOR_NODE: 3,
 };
-exports.PROCESS_TYPES = PROCESS_TYPES;
 
-function parseRole(role) {
+const parseRole = (role) => {
   if (!role || role === 'standalone') return PROCESS_TYPES.STANDALONE;
   if (role === 'hub') return PROCESS_TYPES.GRID_HUB;
   if (role === 'node') return PROCESS_TYPES.GRID_NODE;
   if (role === 'distributor') return PROCESS_TYPES.DISTRIBUTOR_NODE;
-  return undefined;
-}
+};
 
-function getDefaultPort(processType) {
+const getDefaultPort = (processType) => {
   switch (processType) {
     case PROCESS_TYPES.STANDALONE:
     case PROCESS_TYPES.GRID_HUB:
       return 4444;
     case PROCESS_TYPES.GRID_NODE:
       return 5555;
   }
-}
+};
 
-exports.getRunningProcessType = function (seleniumArgs) {
+const getRunningProcessType = (seleniumArgs) => {
   const roleArg = Math.max(
     seleniumArgs.indexOf('hub'),
     seleniumArgs.indexOf('node'),
@@ -44,7 +42,7 @@ exports.getRunningProcessType = function (seleniumArgs) {
  * @param {object} opts
  * @returns {URL}
  */
-exports.getSeleniumStatusUrl = function (seleniumArgs, opts) {
+const getSeleniumStatusUrl = (seleniumArgs, opts) => {
   const nodeConfigArg = seleniumArgs.indexOf('-nodeConfig');
 
   // args prefix differs for selenium3 and selenium4
@@ -58,7 +56,7 @@ exports.getSeleniumStatusUrl = function (seleniumArgs, opts) {
   let host = 'localhost';
   let port;
   let config;
-  let processType = this.getRunningProcessType(seleniumArgs);
+  let processType = getRunningProcessType(seleniumArgs);
 
   // If node config path is pass via -nodeConfig, we have to take settings from there,
   // and override them with possible command line options, as later ones have higher priority
@@ -109,3 +107,9 @@ exports.getSeleniumStatusUrl = function (seleniumArgs, opts) {
   statusURI.port = port || getDefaultPort(processType);
   return statusURI;
 };
+
+module.exports = {
+  getSeleniumStatusUrl,
+  getRunningProcessType,
+  PROCESS_TYPES,
+};

package-lock.json

@@ -46,7 +46,6 @@
     "execa": "^5.1.1",
     "find-process": "^1.4.7",
     "fkill": "^7.2.1",
-    "fs-extra": "^10.0.0",
     "got": "^11.8.2",
     "is-port-reachable": "^3.0.0",
     "lodash.mapvalues": "^4.6.0",