Reduziere Deprecations, löse kleinere Code Inspectons (Case 183951) (#55)

- Beerbe nicht-deprecated Klasse
- Nutze first class callable syntax
- Inline value
- Entferne redundante Condition
- Nutze Null-safe-Operator

Author: MalteWunsch

src/Config/WfdMetaConfigCacheFactory.php

@@ -88,7 +88,7 @@ private function fillCache($callback, ConfigCacheInterface $cache): void
         $cs->execute($cache->getPath(), function () use ($callback, $cache) {
             if (!$cache->isFresh()) {
                 // Our turn and the cache is still stale. Rebuild. */
-                \call_user_func($callback, $cache);
+                $callback($cache);
             } // else: Our turn, but cache is fresh. Must have been rebuilt while we were blocked. Use it.
         });
     }

src/Controller/TemplateController.php

@@ -111,7 +111,7 @@ public function templateAction(
 
         if ($private) {
             $response->setPrivate();
-        } elseif (false === $private || (null === $private && ($maxAge || $sharedAge))) {
+        } elseif (false === $private || ($maxAge || $sharedAge)) {
             $response->setPublic();
         }
 

src/DependencyInjection/WebfactoryWfdMetaExtension.php

@@ -10,9 +10,9 @@
 
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Extension\Extension;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
-use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 
 class WebfactoryWfdMetaExtension extends Extension
 {

src/Provider.php

@@ -148,8 +148,6 @@ private function getTimestampOrNull($fetchValue): ?int
             return null;
         }
 
-        $dateTime = new DateTime($fetchValue);
-
-        return $dateTime->getTimestamp();
+        return (new DateTime($fetchValue))->getTimestamp();
     }
 }

src/Util/CriticalSection.php

@@ -132,8 +132,6 @@ private function getLock(string $name): LockInterface
      */
     private function debug(string $message): void
     {
-        if ($this->logger) {
-            $this->logger->debug($message, ['pid' => getmypid()]);
-        }
+        $this->logger?->debug($message, ['pid' => getmypid()]);
     }
 }