A few minor issues in imageBlur

[mkvenkit]

Thanks for the interesting sample!

I noticed these minor issues:

1. buffer0 and buffer1 in main.ts are associated with flip in the the shader, but where are these buffers being written to? I didn't see associated buffer write calls.
2. samp seems unused in the shader.
3. cubeTexture - naming is a little confusing.

[greggman]

1. buffer0 and buffer1 in main.ts are associated with flip in the the shader, but where are these buffers being written to? I didn't see associated buffer write calls.

They are set when they are created using mappedAtCreation, calling getMappedRange(), setting the value, and then unmaping.

• buffer0 is just a buffer with 0 in it
• buffer1 is just a buffer with 1 in it

One or the other is bound to flip. Bind buffer0 to not flip, bind buffer1 to flip. They don't need to be updated.

2. samp seems unused in the shader.

samp is used, line 52 of blur.wsgl

3. cubeTexture - naming is a little confusing.

Agreed. Will rename

[mkvenkit]

They are set when they are created using mappedAtCreation, calling getMappedRange(), setting the value, and then unmaping.

Sorry, missed that. Thanks for the quick response!