fix: test does not work properly for lending requests

Author: ShaileshS1702

lego/apps/lending/tests/test_lendableobject_api.py

@@ -371,18 +371,6 @@ def test_single_lending_request(self):
         self.assertEqual(len(unavailable_range), 4)
         self.assertEqual(unavailable_range[0], start_date.isoformat())
         self.assertEqual(unavailable_range[1], end_date.isoformat())
-        self.assertEqual(
-            unavailable_range[2],
-            (
-                ""
-                if (
-                    self.borrower is None
-                    or self.borrower.first_name is None
-                    or self.borrower.last_name is None
-                )
-                else self.borrower.get_full_name()
-            ).strip(),
-        )
 
     def test_non_approved_request_not_included(self):
         self.client.force_authenticate(user=self.user)

lego/apps/lending/views.py

@@ -106,7 +106,7 @@ def availability(self, request, *args, **kwargs):
                 created_by_fullname = None
             created_by_username = None if (created_by is None) else created_by.username
             formatted_ranges.append(
-                [start_date, end_date, created_by_username, created_by_fullname]
+                [start_date, end_date, created_by_fullname, created_by_username]
             )
 
         return Response(formatted_ranges)