Feature - Delete Membership history (#3737)

* Add: method to delete membership history

Author: ch0rizo

.gitignore

@@ -57,6 +57,7 @@ target/
 # Pycharm
 .idea/
 
+.venv/
 venv/
 lego/settings/local.py
 lego/db.sqlite

lego/apps/users/tests/test_membership_history.py

@@ -1,7 +1,10 @@
+from datetime import timedelta
+
+from django.utils import timezone
 from rest_framework import status
 
 from lego.apps.users.constants import GROUP_OTHER
-from lego.apps.users.models import AbakusGroup, User
+from lego.apps.users.models import AbakusGroup, MembershipHistory, User
 from lego.utils.test_utils import BaseAPITestCase
 
 
@@ -42,3 +45,66 @@ def test_list_history_as_authenticated(self):
         response = self.client.get(self.url)
         self.assertEqual(status.HTTP_200_OK, response.status_code)
         self.assertEqual(0, len(response.json()["results"]))
+
+    def test_delete_history(self):
+        user = User.objects.get(username="test1")
+        group = AbakusGroup.objects.get(id=26)
+
+        MembershipHistory.objects.create(
+            user=user,
+            abakus_group=group,
+            start_date=timezone.now(),
+            end_date=timezone.now() + timedelta(days=2),
+        )
+        MembershipHistory.objects.create(
+            user=user,
+            abakus_group=group,
+            start_date=timezone.now() + timedelta(days=4),
+            end_date=timezone.now() + timedelta(days=6),
+        )
+
+        self.client.force_authenticate(user)
+        request_body = {"group_id": 26}
+        response = self.client.delete(self.url, request_body)
+        self.assertEqual(status.HTTP_200_OK, response.status_code)
+        self.assertEqual("AbaBrygg got deleted", response.json()["result"])
+        self.assertFalse(
+            MembershipHistory.objects.filter(user=user, abakus_group=group).exists()
+        )
+
+    def test_delete_history_empty_query(self):
+        user = User.objects.get(username="test1")
+        group = AbakusGroup.objects.get(id=26)
+
+        MembershipHistory.objects.create(
+            user=user,
+            abakus_group=group,
+            start_date=timezone.now(),
+            end_date=timezone.now() + timedelta(days=2),
+        )
+        MembershipHistory.objects.create(
+            user=user,
+            abakus_group=group,
+            start_date=timezone.now() + timedelta(days=4),
+            end_date=timezone.now() + timedelta(days=6),
+        )
+
+        self.client.force_authenticate(user)
+        request_body = {"group_id": 0}
+        response = self.client.delete(self.url, request_body)
+        self.assertEqual(status.HTTP_400_BAD_REQUEST, response.status_code)
+        self.assertTrue(
+            MembershipHistory.objects.filter(user=user, abakus_group=group).exists()
+        )
+
+    def test_delete_history_no_group_history(self):
+        user = User.objects.get(username="test1")
+        group = AbakusGroup.objects.get(id=26)
+
+        self.client.force_authenticate(user)
+        request_body = {"group_id": 26}
+        response = self.client.delete(self.url, request_body)
+        self.assertEqual(status.HTTP_400_BAD_REQUEST, response.status_code)
+        self.assertFalse(
+            MembershipHistory.objects.filter(user=user, abakus_group=group).exists()
+        )

lego/apps/users/views/membership_history.py

@@ -1,9 +1,10 @@
-from rest_framework import mixins, permissions, viewsets
+from rest_framework import mixins, permissions, status, viewsets
+from rest_framework.response import Response
 
 from lego.apps.permissions.constants import EDIT
-from lego.apps.users.constants import PUBLIC_GROUPS
+from lego.apps.users.constants import GROUP_INTEREST, PUBLIC_GROUPS
 from lego.apps.users.filters import MembershipHistoryFilterSet
-from lego.apps.users.models import Membership, MembershipHistory
+from lego.apps.users.models import AbakusGroup, Membership, MembershipHistory
 from lego.apps.users.serializers.membership_history import MembershipHistorySerializer
 
 
@@ -27,3 +28,25 @@ def get_queryset(self):
             return queryset.filter(abakus_group__type__in=PUBLIC_GROUPS)
 
         return queryset
+
+    def delete(self, request):
+        try:
+            group = AbakusGroup.objects.get(id=request.data["group_id"])
+            user_membership_history = MembershipHistory.objects.filter(
+                user__id=request.user.id, abakus_group__id=group.id
+            )
+
+            if group.type == GROUP_INTEREST and len(user_membership_history) != 0:
+                name = user_membership_history[0].abakus_group.name
+                user_membership_history.delete()
+                return Response(
+                    {"result": f"{name} got deleted"}, status=status.HTTP_200_OK
+                )
+            return Response(
+                {"result": "Nothing to delete"}, status=status.HTTP_400_BAD_REQUEST
+            )
+        except Exception as e:
+            return Response(
+                {"result": f"Unexpected error: {str(e)}"},
+                status=status.HTTP_400_BAD_REQUEST,
+            )